New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 623991 link

Starred by 1 user

Issue metadata

Status: Duplicate
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug-Security



Sign in to add a comment

Corrupt-block in sk_free_releaseproc

Project Member Reported by ClusterFuzz, Jun 28 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4698549258551296

Fuzzer: inferno_canvas_wrecker
Job Type: windows_syzyasan_chrome
Platform Id: windows

Crash Type: Corrupt-block
Crash Address: 0x7fff7030
Crash State:
  sk_free_releaseproc
  v8::String::ExternalStringResourceBase::Dispose
  SkBitmap::~SkBitmap
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=windows_syzyasan_chrome&range=402058:402059

Minimized Testcase (12.99 Kb): https://cluster-fuzz.appspot.com/download/AMIfv95A8LqoApRWsKZx-ScGladStccW0D-GmXaqnseu2Mq2-LCWDusOt711eCi8R2T5Z8D2TjB1PAPxHiY2oPJ5oumPlJlmiD_S0iHsW_6GD1rNQ4giZjA7o1Y1rZdzLH2iQ04rmHxBM5s5zfgkMCLomhhi5ZMzsA?testcase_id=4698549258551296

Filer: tanin

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 

Comment 1 by palmer@chromium.org, Jun 28 2016

Cc: bsalomon@chromium.org
Components: Internals>Skia
Labels: M-53 OS-Android OS-Chrome OS-Linux OS-Mac
Owner: reed@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 2 by sheriffbot@chromium.org, Jun 29 2016

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 29 2016

Labels: Pri-1

Comment 4 by reed@chromium.org, Jun 29 2016

Cc: mtklein@chromium.org
Cc: mtkl...@google.com
Project Member

Comment 6 by sheriffbot@chromium.org, Jun 30 2016

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by mtkl...@google.com, Jun 30 2016

Looks like the problem is related to a bitmap we allocate to back a saveLayer().  Looking at the calls to saveLayer() in the minimized repro case, I see them calling sk_calloc() a couple times: 144800 bytes, 141600 bytes, then 1798655148 bytes.  That last one is unusually large (1.8G), especially on a 32-bit build like this.

FWIW, content_shell is not crashing on a Linux desktop with infinite RAM.
M53 is branched today (2785) and will be promoted to Beta this month.Your bug is labelled as Beta ReleaseBlock, pls make sure to land and merge the fix to M53 branch 2785 by 5:00 PM PST on Friday 07/22 (sooner the better so it gets chance to bake in M53 dev releases it self). Thank you.
Project Member

Comment 9 by sheriffbot@chromium.org, Jul 14 2016

reed: Uh oh! This issue still open and hasn't been updated in the last 14 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
M53 beta launch is coming soon.Your bug is labelled as Beta ReleaseBlock, pls make sure to land the fix before 6:00 PM PST, Monday (07/18/16). Thank you.
M53 beta launch is next week.Your bug is labelled as Beta ReleaseBlock, pls make sure to land the fix before 6:00 PM PST, Friday (07/22/16). Thank you.
Project Member

Comment 12 by sheriffbot@chromium.org, Jul 21 2016

Labels: -Security_Impact-Head Security_Impact-Beta
Project Member

Comment 13 by sheriffbot@chromium.org, Jul 21 2016

Labels: -ReleaseBlock-Beta ReleaseBlock-Stable

Comment 14 by reed@chromium.org, Jul 21 2016

Cc: reed@chromium.org
Owner: reed@google.com

Comment 15 by reed@google.com, Jul 21 2016

Cc: fmalita@chromium.org
Labels: -Security_Impact-Beta -ReleaseBlock-Stable Security_Impact-Head ReleaseBlock-Beta
I'm afraid sheriffbot's label changes were a hiccup - this is still a blocker for Friday's M53. 

Mergedinto: 627455
Status: Duplicate (was: Assigned)
Labels: -ReleaseBlock-Beta
Project Member

Comment 19 by sheriffbot@chromium.org, Dec 6 2016

Labels: -Restrict-View-SecurityTeam allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment