New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 623989 link

Starred by 22 users

Issue metadata

Status: Fixed
Owner:
gone, assign your bugs elsewhere :)
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature


Sign in to add a comment

Roll SDK to N

Project Member Reported by jbudorick@chromium.org, Jun 28 2016

Issue description

It's that time of year again: the N SDK was recently released.

I'm planning to roll next week. Beware.
 
Showing comments 8 - 107 of 107 Older

Comment 8 by stip@chromium.org, Jul 29 2016

Waiting on the source to be released...
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e00674ac2c822e76c19f38bc6b7c79a0d8d980d2

commit e00674ac2c822e76c19f38bc6b7c79a0d8d980d2
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Fri Jul 29 02:30:50 2016

Roll src/third_party/catapult/ 9902cd872..c880a714d (2 commits).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/9902cd872fed..c880a714d6b1

$ git log 9902cd872..c880a714d --date=short --no-merges --format='%ad %ae %s'

BUG= 623989 

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2189273002
Cr-Commit-Position: refs/heads/master@{#408559}

[modify] https://crrev.com/e00674ac2c822e76c19f38bc6b7c79a0d8d980d2/DEPS

Comment 11 by stip@chromium.org, Aug 9 2016

Blocking: 636092

Comment 12 by torne@chromium.org, Aug 15 2016

Do we really need to block this on checking in the sources? WebView is blocked upstreaming the N java code on this, which means right now nobody can build a current version webview properly from the open source repo :(

Comment 13 by torne@chromium.org, Aug 15 2016

Cc: torne@chromium.org
We've got the sources checked in for the SDK, and I'd be uncomfortable checking in the N SDK alongside the M SDK sources. I don't know if we've asked the open source folks about this specifically, though.

Comment 15 by torne@chromium.org, Aug 15 2016

Why do we have the sources at all? It's not obvious to me :)
On further inspection, it's not clear to me, either. aurimas first added them with SDK 20 in https://bugs.chromium.org/p/chromium/issues/detail?id=393019 but didn't discuss the addition in either the bug or the CL.
Cc: henrika@chromium.org
 Issue 638109  has been merged into this issue.
Thanks for working on this. Is it possible to get an ETA here?
I added sources purely for convenience of autocomplete in IDE. Feel free to delete them.
Ah, thanks Aurimas. In that case, I think we can proceed with the N SDK & remove the sources from the sdk directory.

Comment 21 by stip@chromium.org, Aug 19 2016

We'll take this on next week.

Comment 22 by boliu@chromium.org, Aug 24 2016

ETA? (I'm wondering if I should start some dependent work, maybe roll will have happened when my work is ready to land?)
It would be highly appreciated if the SDK was updated to N as soon as possible. Many thanks.
Any progress for updating the SDK to N?
Labels: M-55 ReleaseBlock-Beta
We're still urgently awaiting this to upstream the WebView N changes. External users are now querying why they can't build an N webview :/

Not blaming anyone for the delay here because there was legitimate confusion about whether we needed to wait for the AOSP source release or not, but we've now missed upstreaming the WebView code for M51, M52, M53 and M54. :(

For future rolls, we need to make this a priority that happens as soon as the public SDK is available - waiting for the AOSP source release is definitely much too late.

I'm setting this as an M55 beta blocker to get it on people's dashboards, but it needs to be done several weeks before the M55 branch point to give us time to actually upstream the webview changes that depend on it.
Waiting on the source was my fault. Sorry about that; we won't do it again.
Blocking: 643660
Blocking: 645059
Is there an ETA for this work?  It seems like several folks are waiting for it and it would be great to have an idea of when we can start building against it for planning purposes.

Comment 30 by stip@chromium.org, Sep 13 2016

Sorry for the delays here, I'm working through a lint issue and things were delayed last week due to some production outages. My ETA is by the end of the week.

Comment 31 by stip@chromium.org, Sep 19 2016

Still working on this.
Project Member

Comment 32 by bugdroid1@chromium.org, Sep 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/android_tools/+/ff2bf0560cbe6671ba4160423af196feafee4bf9

commit ff2bf0560cbe6671ba4160423af196feafee4bf9
Author: Mike Stipicevic <stip@chromium.org>
Date: Fri Sep 16 23:37:27 2016

Move to Android N SDK.

BUG= 623989 

Change-Id: I51ee2673ec4e7e68eb6d36f3ea2d59fc17821e4f
Reviewed-on: https://chromium-review.googlesource.com/376960
Tested-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>

[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/values-w720dp/bools.xml
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-xxhdpi/progressbar_indeterminate_holo3.png
[delete] https://crrev.com/25d57ead05d3dfef26e9c19b13ed10b0a69829cf/sdk/platforms/android-23/data/res/drawable-xhdpi/btn_radio_to_off_mtrl_009.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-ldpi/btn_keyboard_key_normal_off.9.png
[add] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/values-mcc310-mnc230-si-rLK/strings.xml
[add] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/values-mcc310-mnc230-da/strings.xml
[delete] https://crrev.com/25d57ead05d3dfef26e9c19b13ed10b0a69829cf/sdk/platforms/android-23/data/res/values-si-rLK/strings.xml
[add] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/values-mcc310-mnc160-hi/strings.xml
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/values-cs-rCZ/donottranslate-maps.xml
[add] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/values-fr-watch/strings.xml
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-xxxhdpi/perm_group_accessibility_features.png
[add] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/values-mcc310-mnc250-af/strings.xml
[add] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/values-mcc310-mnc660-sk/strings.xml
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-hdpi/ic_cab_done_holo.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-mdpi/ic_menu_edit.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-ldpi/ic_popup_sync_4.png
[add] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/values-mcc310-mnc240-ms-rMY/strings.xml
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-hdpi/ic_menu_allfriends.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-hdpi/btn_check_label_background.9.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-ldpi/btn_close_normal.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-hdpi/ic_audio_notification_am_alpha.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-mdpi/ic_settings.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-hdpi/ic_coins_s.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-xhdpi/rate_star_big_on_holo_light.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable/status_bar_item_app_background.xml
[delete] https://crrev.com/25d57ead05d3dfef26e9c19b13ed10b0a69829cf/sdk/platforms/android-23/data/fonts/NotoSansYi-Regular.ttf
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-hdpi/rate_star_small_half_holo_dark.png
[delete] https://crrev.com/25d57ead05d3dfef26e9c19b13ed10b0a69829cf/sdk/platforms/android-23/data/res/drawable-hdpi/btn_radio_to_on_mtrl_015.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/anim/input_method_enter.xml
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-xxhdpi/textfield_disabled_focused_holo_light.9.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-hdpi/btn_keyboard_key_fulltrans_normal_on.9.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-hdpi/ic_jog_dial_answer.png
[delete] https://crrev.com/25d57ead05d3dfef26e9c19b13ed10b0a69829cf/sdk/platforms/android-23/data/res/layout/time_picker_header_material.xml
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/layout/am_compat_mode_dialog.xml
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-xxhdpi/btn_toggle_on_disabled_holo_dark.9.png
[add] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/fonts/NotoSansGurmukhiUI-Regular.ttf
[add] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/values-zh-rHK/strings.xml
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-xhdpi/btn_toggle_on_disabled_focused_holo_light.9.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/interpolator/decelerate_quart.xml
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-xhdpi/btn_default_transparent_normal.9.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-hdpi/quickcontact_badge_overlay_focused_light_am.9.png
[add] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/values-mcc310-mnc220-zu/strings.xml
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-hdpi/status_bar_background.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-mdpi/menu_separator.9.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-hdpi/switch_thumb_pressed_holo_light.9.png
[add] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/tools/lib/monitor-x86_64/plugins/com.android.ide.eclipse.hierarchyviewer_25.1.7.2879327.jar
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/layout/dialog_title_icons.xml
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/raw-vi/incognito_mode_start_page.html
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/anim/input_method_fancy_enter.xml
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-mdpi/menu_submenu_background.9.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-xxhdpi/btn_star_off_focused_holo_light.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-ldpi/emo_im_surprised.png
[add] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-xhdpi/pointer_alias_large.png
[add] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/values-mcc310-mnc200-ro/strings.xml
[add] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/values-pa-rIN/strings.xml
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/layout/preference_category_holo.xml
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-hdpi/btn_plus_default.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-mdpi/btn_check_off_disabled_focused_holo_light.png
[add] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/layout/notification_template_progress.xml
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/skins/WVGA854/key.png
[add] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/values-mcc310-mnc240-lv/strings.xml
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-xxhdpi/scrubber_control_on_pressed_mtrl_alpha.png
[add] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/values-mcc310-mnc210-az-rAZ/strings.xml
[delete] https://crrev.com/25d57ead05d3dfef26e9c19b13ed10b0a69829cf/sdk/platforms/android-23/data/res/values-ca-watch/strings.xml
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-hdpi/spinner_white_48.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-hdpi/btn_star_on_disabled_focused_holo_light.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable/ic_find_previous_material.xml
[add] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/fonts/NanumGothic.ttf
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/raw-da-xlarge/incognito_mode_start_page.html
[add] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/values-mcc310-mnc160-be-rBY/strings.xml
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/color/list_highlight_material.xml
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-xxhdpi/btn_switch_to_off_mtrl_00006.9.png
[add] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/layout/search_view.xml
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-ldpi/ic_media_rew.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-ldpi/btn_check_off_disable.png
[delete] https://crrev.com/25d57ead05d3dfef26e9c19b13ed10b0a69829cf/sdk/platforms/android-23/data/fonts/Roboto-Light.ttf
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/layout/simple_account_item.xml
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-hdpi/ic_menu_paste_holo_dark.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/layout/preference_widget_seekbar.xml
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/raw-id/incognito_mode_start_page.html
[add] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/values-mcc730-mnc01/config.xml
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-mdpi/ic_jog_dial_answer_and_end.png
[delete] https://crrev.com/25d57ead05d3dfef26e9c19b13ed10b0a69829cf/sdk/build-tools/23.0.1/renderscript/lib/intermediates/mips/libcompiler_rt.a
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-xhdpi/scrubber_track_holo_dark.9.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-xhdpi/list_selector_disabled_holo_light.9.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable/jog_tab_bar_left_unlock.xml
[delete] https://crrev.com/25d57ead05d3dfef26e9c19b13ed10b0a69829cf/sdk/platforms/android-23/data/features.txt
[modify] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/tools/lib/hierarchyviewer2.jar
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-ldpi/keyboard_key_feedback_more_background.9.png
[add] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/values-mcc310-mnc200-th/strings.xml
[delete] https://crrev.com/25d57ead05d3dfef26e9c19b13ed10b0a69829cf/sdk/platforms/android-23/data/fonts/NotoSansSaurashtra-Regular.ttf
[add] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/values-mk-rMK/strings.xml
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-xxhdpi/ic_media_fullscreen.png
[delete] https://crrev.com/25d57ead05d3dfef26e9c19b13ed10b0a69829cf/sdk/platforms/android-23/data/res/layout/preference_widget_switch.xml
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/anim/wallpaper_exit.xml
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-hdpi/btn_switch_to_off_mtrl_00010.9.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-xhdpi/dialog_ic_close_pressed_holo_light.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/skins/HVGA/button.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-xxhdpi/ic_find_next_mtrl_alpha.png
[delete] https://crrev.com/25d57ead05d3dfef26e9c19b13ed10b0a69829cf/sdk/platforms/android-23/data/res/values-mcc302-mnc220/config.xml
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/layout/screen_simple.xml
[add] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/fonts/NotoSansTibetan-Regular.ttf
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-ldpi/ic_jog_dial_unlock.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-xhdpi/textfield_search_empty_pressed.9.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-xhdpi/btn_default_pressed_holo.9.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-xhdpi/textfield_selected.9.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-mdpi/tab_press_bar_right.9.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-xxhdpi/ic_menu_myplaces.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/layout/simple_list_item_activated_2.xml
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-xhdpi/btn_rating_star_on_normal.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable/app_icon_background.xml
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-xhdpi/sym_keyboard_num2.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/interpolator/fast_out_linear_in.xml
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-hdpi/sym_keyboard_space.png
[delete] https://crrev.com/25d57ead05d3dfef26e9c19b13ed10b0a69829cf/sdk/platforms/android-23/data/res/layout/notification_template_material_media.xml
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-xhdpi/ic_menu_play_clip.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platform-tools/systrace/catapult/systrace/systrace/LICENSE
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-xhdpi/title_bar_tall.9.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-hdpi/list_selector_background_focused.9.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-mdpi/perm_group_accessibility_features.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-hdpi/light_header.9.png
[add] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/values-mcc310-mnc160-az-rAZ/strings.xml
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/values-mcc310-mnc260/config.xml
[delete] https://crrev.com/25d57ead05d3dfef26e9c19b13ed10b0a69829cf/sdk/build-tools/23.0.1/renderscript/clang-include/popcntintrin.h
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-xxhdpi/combobox_disabled.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/values-de-rLI/donottranslate-maps.xml
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/layout/dialog_title_icons_holo.xml
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-xxhdpi/indicator_input_error.png
[add] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/values-mcc310-mnc250-ko/strings.xml
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/layout/screen_simple_overlay_action_mode.xml
[delete] https://crrev.com/25d57ead05d3dfef26e9c19b13ed10b0a69829cf/sdk/platforms/android-23/data/fonts/NotoSansThaiUI-Regular.ttf
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-hdpi/btn_keyboard_key_pressed.9.png
[add] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/values-mcc310-mnc490-lv/strings.xml
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-xhdpi/ic_dialog_alert_holo_dark.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable/spinner_default_holo_light.xml
[delete] https://crrev.com/25d57ead05d3dfef26e9c19b13ed10b0a69829cf/sdk/platforms/android-23/data/res/values-kk-rKZ-watch/strings.xml
[add] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/values-mcc310-mnc270-zu/strings.xml
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-ldpi/sym_keyboard_num1.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/values-television/dimens.xml
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable/btn_radio_holo_dark.xml
[add] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/values-mcc310-mnc200-sv/strings.xml
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-xhdpi/spinner_focused_holo_light_am.9.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-mdpi/ab_share_pack_holo_dark.9.png
[add] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-xhdpi/pointer_copy.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-hdpi/btn_radio_on_focused_holo_dark.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-ldpi/ic_emergency.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-ldpi/numberpicker_input_disabled.9.png
[add] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable/decor_close_button_light.xml
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-mdpi/ic_vibrate.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-xhdpi/ic_print_error.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-mdpi/button_onoff_indicator_off.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-ldpi/stat_sys_battery_60.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable/ic_folder_24dp.xml
[delete] https://crrev.com/25d57ead05d3dfef26e9c19b13ed10b0a69829cf/sdk/platforms/android-23/data/res/values-it/strings.xml
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/interpolator/trim_start_interpolator.xml
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-hdpi/dropdown_pressed_holo_dark.9.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-xhdpi/ic_media_route_off_holo_light.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-xxhdpi/btn_switch_to_off_mtrl_00008.9.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-hdpi/perm_group_bookmarks.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-xhdpi/divider_horizontal_bright_opaque.9.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-hdpi/textfield_search_default_holo_light.9.png
[add] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-xhdpi/pointer_nodrop.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-mdpi/textfield_disabled_focused_holo_dark.9.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-ldpi/jog_tab_bar_right_end_normal.9.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-hdpi/transportcontrol_bg.9.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/skins/WQVGA432/hardware.ini
[add] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/values-mcc310-mnc310-es-rUS/strings.xml
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-ldpi/btn_star_big_off_disable.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-xxhdpi/cling_button_pressed.9.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-mdpi/popup_inline_error_above_holo_dark_am.9.png
[rename] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafee4bf9/sdk/platforms/android-24/data/res/drawable-mdpi/ic_jog_dial_decline.png
[add] https://crrev.com/ff2bf0560cbe6671ba4160423af196feafe

Comment 33 by stip@chromium.org, Sep 20 2016

We've landed the SDK in android_tools, and verified that with lint errors suppressed we get a functional binary. Progressing on the CL with the lint errors correctly suppressed.

Comment 34 by stip@chromium.org, Sep 26 2016

Still making progress on the lint suppressions.
Project Member

Comment 35 by bugdroid1@chromium.org, Sep 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0922fe51e2ce01ab7dc1644d81bb15801a41286a

commit 0922fe51e2ce01ab7dc1644d81bb15801a41286a
Author: stip <stip@chromium.org>
Date: Mon Sep 26 04:09:31 2016

build/android lint suppressions needed for Android SDK roll.

This is only part of the suppressions needed for a full compile, I'm splitting them up into separate CLs to make OWNERS review easier.

BUG= 623989 

Review-Url: https://codereview.chromium.org/2362753005
Cr-Commit-Position: refs/heads/master@{#420871}

[modify] https://crrev.com/0922fe51e2ce01ab7dc1644d81bb15801a41286a/build/android/incremental_install/java/org/chromium/incrementalinstall/ClassLoaderPatcher.java

Project Member

Comment 36 by bugdroid1@chromium.org, Sep 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d43e73df37649c6e82aa0b05ace70eca1a6898f

commit 9d43e73df37649c6e82aa0b05ace70eca1a6898f
Author: stip <stip@chromium.org>
Date: Mon Sep 26 22:52:46 2016

Lint suppressions needed for Android SDK roll.

This is only part of the suppressions needed for a full compile, I'm splitting them up into separate CLs to make OWNERS review easier.

BUG= 623989 
R=jbudorick@chromium.org, dtrainor@chromium.org

Review-Url: https://codereview.chromium.org/2371513002
Cr-Commit-Position: refs/heads/master@{#421028}

[modify] https://crrev.com/9d43e73df37649c6e82aa0b05ace70eca1a6898f/blimp/client/app/android/java/src/org/chromium/blimp/BlimpRendererActivity.java

Project Member

Comment 37 by bugdroid1@chromium.org, Sep 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfa4cb2fde5051bf56444ae4cadb7b903a10bfe2

commit dfa4cb2fde5051bf56444ae4cadb7b903a10bfe2
Author: stip <stip@chromium.org>
Date: Mon Sep 26 23:07:15 2016

android_webview lint suppressions needed for Android SDK roll.

This is only part of the suppressions needed for a full compile, I'm splitting them up into separate CLs to make OWNERS review easier.

BUG= 623989 

Review-Url: https://codereview.chromium.org/2366083002
Cr-Commit-Position: refs/heads/master@{#421030}

[modify] https://crrev.com/dfa4cb2fde5051bf56444ae4cadb7b903a10bfe2/android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java
[modify] https://crrev.com/dfa4cb2fde5051bf56444ae4cadb7b903a10bfe2/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java

Project Member

Comment 38 by bugdroid1@chromium.org, Sep 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13c9e5a7a59249e65a240fe4127134d36addb21a

commit 13c9e5a7a59249e65a240fe4127134d36addb21a
Author: stip <stip@chromium.org>
Date: Mon Sep 26 23:12:36 2016

testing/android lint suppressions needed for Android SDK roll.

This is only part of the suppressions needed for a full compile, I'm splitting them up into separate CLs to make OWNERS review easier.

BUG= 623989 
R=jbudorick@chromium.org

Review-Url: https://codereview.chromium.org/2371623002
Cr-Commit-Position: refs/heads/master@{#421033}

[modify] https://crrev.com/13c9e5a7a59249e65a240fe4127134d36addb21a/testing/android/native_test/java/src/org/chromium/native_test/NativeTestInstrumentationTestRunner.java

Blocking: 640643
Project Member

Comment 41 by bugdroid1@chromium.org, Sep 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/748a60e398d3b38dfc372d56437d3419b230956d

commit 748a60e398d3b38dfc372d56437d3419b230956d
Author: stip <stip@chromium.org>
Date: Fri Sep 30 00:53:08 2016

net/ lint suppressions needed for Android SDK roll.

This is only part of the suppressions needed for a full compile, I'm splitting them up into separate CLs to make OWNERS review easier.

BUG= 623989 

Review-Url: https://codereview.chromium.org/2367273002
Cr-Commit-Position: refs/heads/master@{#422000}

[modify] https://crrev.com/748a60e398d3b38dfc372d56437d3419b230956d/net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java
[modify] https://crrev.com/748a60e398d3b38dfc372d56437d3419b230956d/net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java

Comment 42 by bshe@chromium.org, Sep 30 2016

Blocking: 389343
Project Member

Comment 43 by bugdroid1@chromium.org, Oct 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c3bcc5d9fee0074cb50aee243bfd75ebc33d542

commit 4c3bcc5d9fee0074cb50aee243bfd75ebc33d542
Author: stip <stip@chromium.org>
Date: Mon Oct 03 17:09:00 2016

Lint suppressions needed for Android SDK roll.

This is only part of the suppressions needed for a full compile, I'm splitting them up into separate CLs to make OWNERS review easier.

BUG= 623989 

Review-Url: https://codereview.chromium.org/2363113003
Cr-Commit-Position: refs/heads/master@{#422441}

[modify] https://crrev.com/4c3bcc5d9fee0074cb50aee243bfd75ebc33d542/base/android/java/src/org/chromium/base/SecureRandomInitializer.java
[modify] https://crrev.com/4c3bcc5d9fee0074cb50aee243bfd75ebc33d542/base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java
[modify] https://crrev.com/4c3bcc5d9fee0074cb50aee243bfd75ebc33d542/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
[modify] https://crrev.com/4c3bcc5d9fee0074cb50aee243bfd75ebc33d542/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java
[modify] https://crrev.com/4c3bcc5d9fee0074cb50aee243bfd75ebc33d542/chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkWidgetService.java
[modify] https://crrev.com/4c3bcc5d9fee0074cb50aee243bfd75ebc33d542/chrome/android/java/src/org/chromium/chrome/browser/customtabs/RequestThrottler.java
[modify] https://crrev.com/4c3bcc5d9fee0074cb50aee243bfd75ebc33d542/chrome/android/java/src/org/chromium/chrome/browser/externalauth/ExternalAuthUtils.java
[modify] https://crrev.com/4c3bcc5d9fee0074cb50aee243bfd75ebc33d542/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CreateRouteRequest.java
[modify] https://crrev.com/4c3bcc5d9fee0074cb50aee243bfd75ebc33d542/chrome/android/java/src/org/chromium/chrome/browser/ntp/UiConfig.java
[modify] https://crrev.com/4c3bcc5d9fee0074cb50aee243bfd75ebc33d542/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java
[modify] https://crrev.com/4c3bcc5d9fee0074cb50aee243bfd75ebc33d542/chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionView.java
[modify] https://crrev.com/4c3bcc5d9fee0074cb50aee243bfd75ebc33d542/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionStatsPreference.java
[modify] https://crrev.com/4c3bcc5d9fee0074cb50aee243bfd75ebc33d542/chrome/android/java/src/org/chromium/chrome/browser/services/gcm/InvalidationGcmUpstreamSender.java
[modify] https://crrev.com/4c3bcc5d9fee0074cb50aee243bfd75ebc33d542/chrome/android/java/src/org/chromium/chrome/browser/signin/ConfirmSyncDataStateMachine.java
[modify] https://crrev.com/4c3bcc5d9fee0074cb50aee243bfd75ebc33d542/chrome/android/java/src/org/chromium/chrome/browser/upgrade/PackageReplacedBroadcastReceiver.java
[modify] https://crrev.com/4c3bcc5d9fee0074cb50aee243bfd75ebc33d542/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkVersionManager.java
[modify] https://crrev.com/4c3bcc5d9fee0074cb50aee243bfd75ebc33d542/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/UrlBarTest.java
[modify] https://crrev.com/4c3bcc5d9fee0074cb50aee243bfd75ebc33d542/chrome/android/javatests/src/org/chromium/chrome/browser/partnercustomizations/PartnerHomepageIntegrationTest.java
[modify] https://crrev.com/4c3bcc5d9fee0074cb50aee243bfd75ebc33d542/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java
[modify] https://crrev.com/4c3bcc5d9fee0074cb50aee243bfd75ebc33d542/chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/DexOptimizer.java
[modify] https://crrev.com/4c3bcc5d9fee0074cb50aee243bfd75ebc33d542/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
[modify] https://crrev.com/4c3bcc5d9fee0074cb50aee243bfd75ebc33d542/content/public/android/java/src/org/chromium/content/browser/PepperPluginManager.java
[modify] https://crrev.com/4c3bcc5d9fee0074cb50aee243bfd75ebc33d542/content/public/android/java/src/org/chromium/content/browser/SpeechRecognition.java
[modify] https://crrev.com/4c3bcc5d9fee0074cb50aee243bfd75ebc33d542/content/public/android/java/src/org/chromium/content/browser/TracingControllerAndroid.java
[modify] https://crrev.com/4c3bcc5d9fee0074cb50aee243bfd75ebc33d542/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java
[modify] https://crrev.com/4c3bcc5d9fee0074cb50aee243bfd75ebc33d542/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
[modify] https://crrev.com/4c3bcc5d9fee0074cb50aee243bfd75ebc33d542/content/public/android/java/src/org/chromium/content/common/FileDescriptorInfo.java
[modify] https://crrev.com/4c3bcc5d9fee0074cb50aee243bfd75ebc33d542/content/public/android/javatests/src/org/chromium/content/browser/webcontents/WebContentsTest.java
[modify] https://crrev.com/4c3bcc5d9fee0074cb50aee243bfd75ebc33d542/tools/android/checkstyle/chromium-style-5.0.xml
[modify] https://crrev.com/4c3bcc5d9fee0074cb50aee243bfd75ebc33d542/tools/android/checkstyle/suppressions.xml
[modify] https://crrev.com/4c3bcc5d9fee0074cb50aee243bfd75ebc33d542/ui/android/java/src/org/chromium/ui/picker/MonthPicker.java
[modify] https://crrev.com/4c3bcc5d9fee0074cb50aee243bfd75ebc33d542/ui/android/java/src/org/chromium/ui/picker/MultiFieldTimePickerDialog.java

Blocking: 651999
Project Member

Comment 46 by bugdroid1@chromium.org, Oct 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/android_tools/+/15695bfb7df744a52d3974c9d9b51f02f68038a3

commit 15695bfb7df744a52d3974c9d9b51f02f68038a3
Author: Mike Stipicevic <stip@chromium.org>
Date: Thu Oct 06 20:43:12 2016

Use java1.7 dx.jar.

BUG= 623989 

Change-Id: I763eb7452c9ff417ff67ae7c77634857dc502c8a
Reviewed-on: https://chromium-review.googlesource.com/394828
Reviewed-by: John Budorick <jbudorick@chromium.org>
Tested-by: John Budorick <jbudorick@chromium.org>

[modify] https://crrev.com/15695bfb7df744a52d3974c9d9b51f02f68038a3/sdk/build-tools/24.0.2/lib/dx.jar

It's great to see the progress on this bug but I was wondering if the plan is to merge the remainder of the changes (I'm not sure how much work is left) into the M55 release branch or if teams dependent on these changes will need to work out of M56 for their N specific functionality and features.
Project Member

Comment 48 by bugdroid1@chromium.org, Oct 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11837e363c671aa15024b9d1228057fc2bacd6eb

commit 11837e363c671aa15024b9d1228057fc2bacd6eb
Author: agrieve <agrieve@chromium.org>
Date: Wed Oct 12 20:59:40 2016

Don't base android lint version off of android sdk version.

If downstream overrides sdk version, we don't want the lint version to
change.

BUG= 623989 

Review-Url: https://codereview.chromium.org/2418433003
Cr-Commit-Position: refs/heads/master@{#424847}

[modify] https://crrev.com/11837e363c671aa15024b9d1228057fc2bacd6eb/build/config/android/config.gni

Project Member

Comment 49 by bugdroid1@chromium.org, Oct 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0a9c9a7654cc74ece6b7255560d8ce37bf3ef36

commit e0a9c9a7654cc74ece6b7255560d8ce37bf3ef36
Author: agrieve <agrieve@chromium.org>
Date: Wed Oct 12 21:23:37 2016

Fix a FindBugs warning in JsonSanitizer.java

It appeared when trying to switch to Android N sdk:

  SF_SWITCH_NO_DEFAULT: Switch statement found where default case is missing
    In class org.chromium.components.safejson.JsonSanitizer
    In method org.chromium.components.safejson.JsonSanitizer.sanitize(String)
    At JsonSanitizer.java:[lines 54-100]

BUG= 623989 

Review-Url: https://codereview.chromium.org/2417623002
Cr-Commit-Position: refs/heads/master@{#424859}

[modify] https://crrev.com/e0a9c9a7654cc74ece6b7255560d8ce37bf3ef36/components/safe_json/android/java/src/org/chromium/components/safejson/JsonSanitizer.java

Project Member

Comment 50 by bugdroid1@chromium.org, Oct 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/acd4e48ea65c9aad8bdc1fe3db7d529e4ddc5204

commit acd4e48ea65c9aad8bdc1fe3db7d529e4ddc5204
Author: agrieve <agrieve@chromium.org>
Date: Thu Oct 13 00:17:14 2016

Fix UnusedResoruces android lint warning in castshell_java

It thought the app icon was unused because it wasn't being passed the
AndroidManifest.xml

BUG= 623989 

Review-Url: https://codereview.chromium.org/2404413003
Cr-Commit-Position: refs/heads/master@{#424918}

[modify] https://crrev.com/acd4e48ea65c9aad8bdc1fe3db7d529e4ddc5204/chromecast/browser/android/BUILD.gn

Project Member

Comment 51 by bugdroid1@chromium.org, Oct 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/android_tools/+/3d6ba29a6693bf3db1343fc213eea47c7d940413

commit 3d6ba29a6693bf3db1343fc213eea47c7d940413
Author: Andrew Grieve <agrieve@chromium.org>
Date: Wed Oct 12 19:57:25 2016

Revert uiautomator.jar to that of platforms/android-23

The android-24 was compiled with -target 1.8 :(

BUG= 623989 

Change-Id: I9f9303e62935ad392c3e305713799055f6b3aa83
Reviewed-on: https://chromium-review.googlesource.com/397639
Reviewed-by: Mike Stipicevic <stip@chromium.org>
Tested-by: Andrew Grieve <agrieve@chromium.org>

[modify] https://crrev.com/3d6ba29a6693bf3db1343fc213eea47c7d940413/sdk/platforms/android-24/uiautomator.jar

Project Member

Comment 52 by bugdroid1@chromium.org, Oct 13 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/src-internal.git/+/4955a95c8879bd6340c6a28bb657e970c2156c0c

commit 4955a95c8879bd6340c6a28bb657e970c2156c0c
Author: Andrew Grieve <agrieve@chromium.org>
Date: Thu Oct 13 00:12:59 2016

Project Member

Comment 53 by bugdroid1@chromium.org, Oct 13 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/src-internal.git/+/4955a95c8879bd6340c6a28bb657e970c2156c0c

commit 4955a95c8879bd6340c6a28bb657e970c2156c0c
Author: Andrew Grieve <agrieve@chromium.org>
Date: Thu Oct 13 00:12:59 2016

Project Member

Comment 54 by bugdroid1@chromium.org, Oct 13 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/9dcd81840baad82019975713d1ba119a857a50c3

commit 9dcd81840baad82019975713d1ba119a857a50c3
Author: Andrew Grieve <agrieve@chromium.org>
Date: Wed Oct 12 20:10:15 2016

Comment 55 by hush@chromium.org, Oct 13 2016

Blocking: 543272
Labels: -ReleaseBlock-Beta ReleaseBlock-Stable
Since we're actually close to the M55 beta release point, having this here is polluting the critical path queue, so I'm going to move it to stable.  Based on some of torne's earlier assertion this should have been fixed a few weeks ago, so hopefully we can make this happen soon?  Glad to see all the recent activity, do we have any ETA?

Comment 57 by stip@chromium.org, Oct 13 2016

Hopefully EoW, but it depends on some findbugs fixes yet to land.

Comment 58 by stip@chromium.org, Oct 14 2016

Cc: agrieve@chromium.org
Project Member

Comment 60 by bugdroid1@chromium.org, Oct 14 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/782a259b2a237105953a062cba77b666fa1a266d

commit 782a259b2a237105953a062cba77b666fa1a266d
Author: Andrew Grieve <agrieve@chromium.org>
Date: Fri Oct 14 16:30:40 2016

Project Member

Comment 61 by bugdroid1@chromium.org, Oct 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90b4cf429c7e73e94f04a43bf573d98f03b80477

commit 90b4cf429c7e73e94f04a43bf573d98f03b80477
Author: agrieve <agrieve@chromium.org>
Date: Fri Oct 14 17:54:50 2016

Fix chrome_java FindBugs errors found when switching to n sdk.

(with some simplification of CrashFileManager.java)

FindBugs reported the following issues:
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE: Possible null pointer dereference due to return value of called method
  In class org.chromium.chrome.browser.crash.CrashFileManager
  In method org.chromium.chrome.browser.crash.CrashFileManager.getAllFilesSorted()
  Method invoked at CrashFileManager.java:[line 258]
  Known null at CrashFileManager.java:[line 257]
OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE: Method may fail to clean up stream or resource on checked exception
  In class org.chromium.chrome.browser.share.ShareHelper$3
  In method org.chromium.chrome.browser.share.ShareHelper$3.doInBackground(Void[])
  Reference type java.io.OutputStream
  Obligation to clean up resource created at ShareHelper.java:[line 398] is not discharged
  Path continues at ShareHelper.java:[line 399]
REC_CATCH_EXCEPTION: Exception is caught when Exception is not thrown
  In class org.chromium.chrome.test.ChromeActivityTestCaseBase
  In method org.chromium.chrome.test.ChromeActivityTestCaseBase.prepareUrlIntent(Intent, String)
  At ChromeActivityTestCaseBase.java:[line 486]
REC_CATCH_EXCEPTION: Exception is caught when Exception is not thrown
  In class org.chromium.chrome.test.ChromeActivityTestCaseBase
  In method org.chromium.chrome.test.ChromeActivityTestCaseBase.endPerfTest(String)
  At ChromeActivityTestCaseBase.java:[line 859]
OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE: Method may fail to clean up stream or resource on checked exception
  In class org.chromium.chrome.test.util.RenderUtils
  In method org.chromium.chrome.test.util.RenderUtils.saveBitmap(Bitmap, File)
  Reference type java.io.OutputStream
  Obligation to clean up resource created at RenderUtils.java:[line 179] is not discharged
  Path continues at RenderUtils.java:[line 180]
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE: Possible null pointer dereference due to return value of called method
  In class org.chromium.chrome.browser.crash.CrashTestCase
  In method org.chromium.chrome.browser.crash.CrashTestCase.tearDown()
  Method invoked at CrashTestCase.java:[line 41]
  Known null at CrashTestCase.java:[line 41]
RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT: Return value of method without side effect is ignored
  In class org.chromium.chrome.browser.customtabs.CustomTabFromChromeExternalNavigationTest
  In method org.chromium.chrome.browser.customtabs.CustomTabFromChromeExternalNavigationTest.testIntentWithRedirectToApp()
  Called method org.chromium.content.browser.test.util.Criteria.equals(Object, Callable)
  At CustomTabFromChromeExternalNavigationTest.java:[line 121]

BUG= 623989 

Review-Url: https://codereview.chromium.org/2416963005
Cr-Commit-Position: refs/heads/master@{#425384}

[modify] https://crrev.com/90b4cf429c7e73e94f04a43bf573d98f03b80477/chrome/android/java/src/org/chromium/chrome/browser/crash/CrashFileManager.java
[modify] https://crrev.com/90b4cf429c7e73e94f04a43bf573d98f03b80477/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java
[modify] https://crrev.com/90b4cf429c7e73e94f04a43bf573d98f03b80477/chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java
[modify] https://crrev.com/90b4cf429c7e73e94f04a43bf573d98f03b80477/chrome/android/javatests/src/org/chromium/chrome/browser/crash/CrashFileManagerTest.java
[modify] https://crrev.com/90b4cf429c7e73e94f04a43bf573d98f03b80477/chrome/android/javatests/src/org/chromium/chrome/browser/crash/CrashTestCase.java
[modify] https://crrev.com/90b4cf429c7e73e94f04a43bf573d98f03b80477/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabFromChromeExternalNavigationTest.java
[modify] https://crrev.com/90b4cf429c7e73e94f04a43bf573d98f03b80477/chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeActivityTestCaseBase.java
[modify] https://crrev.com/90b4cf429c7e73e94f04a43bf573d98f03b80477/chrome/test/android/javatests/src/org/chromium/chrome/test/util/RenderUtils.java

Status: Fixed (was: Assigned)
Marking as fixed. Please reopen if it gets reverted.
Are there any plans to merge this work into M55?
Project Member

Comment 65 by bugdroid1@chromium.org, Oct 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d5a0fb164db4c2c24e83fe859463aa4268918a4

commit 3d5a0fb164db4c2c24e83fe859463aa4268918a4
Author: nednguyen <nednguyen@google.com>
Date: Mon Oct 17 01:36:35 2016

Revert of Upgrade to new Android SDK. (patchset #16 id:300001 of https://codereview.chromium.org/2350013004/ )

Reason for revert:
This may have changed the adb used by adb_logcat_monitor.py  & creates a conflict with the one used by telemetry.

BUG= 656224 

Original issue's description:
> Upgrade to new Android SDK.
>
> BUG= 623989 
>
> Committed: https://crrev.com/e3c21739bcc8d5df70d2dd011c3f575570085b6d
> Cr-Commit-Position: refs/heads/master@{#425423}

TBR=jbudorick@chromium.org,xunjieli@chromium.org,agrieve@chromium.org,stip@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 623989 

Review-Url: https://codereview.chromium.org/2425563002
Cr-Commit-Position: refs/heads/master@{#425604}

[modify] https://crrev.com/3d5a0fb164db4c2c24e83fe859463aa4268918a4/DEPS
[modify] https://crrev.com/3d5a0fb164db4c2c24e83fe859463aa4268918a4/build/android/BUILD.gn
[modify] https://crrev.com/3d5a0fb164db4c2c24e83fe859463aa4268918a4/build/android/devil_chromium.json
[modify] https://crrev.com/3d5a0fb164db4c2c24e83fe859463aa4268918a4/build/android/lint/suppressions.xml
[modify] https://crrev.com/3d5a0fb164db4c2c24e83fe859463aa4268918a4/build/android/pylib/constants/__init__.py
[modify] https://crrev.com/3d5a0fb164db4c2c24e83fe859463aa4268918a4/build/config/android/config.gni
[modify] https://crrev.com/3d5a0fb164db4c2c24e83fe859463aa4268918a4/components/cronet/android/api/build.xml
[modify] https://crrev.com/3d5a0fb164db4c2c24e83fe859463aa4268918a4/components/cronet/tools/generate_javadoc.py
[modify] https://crrev.com/3d5a0fb164db4c2c24e83fe859463aa4268918a4/docs/android_test_instructions.md
[modify] https://crrev.com/3d5a0fb164db4c2c24e83fe859463aa4268918a4/tools/android/eclipse/.classpath

Status: Assigned (was: Fixed)
Re-opening due to revert from yesterday.

Comment 67 by awdf@chromium.org, Oct 18 2016

Cc: awdf@chromium.org
Also curious to find out if this will make it into M55, because if so we'll want to get https://bugs.chromium.org/p/chromium/issues/detail?id=653558 in too 

Comment 68 by kerz@chromium.org, Oct 19 2016

This should not be in 55, there's no reason to do that.
Blocking: 656833
Project Member

Comment 70 by bugdroid1@chromium.org, Oct 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a94bcadb9d91faf3e0b4124c9bfcb5546d82bc1

commit 4a94bcadb9d91faf3e0b4124c9bfcb5546d82bc1
Author: jbudorick <jbudorick@chromium.org>
Date: Thu Oct 20 01:39:02 2016

[Android] Always use devil's adb in the perf recipes.

BUG= 623989 

Review-Url: https://chromiumcodereview.appspot.com/2431963004
Cr-Commit-Position: refs/heads/master@{#426368}

[modify] https://crrev.com/4a94bcadb9d91faf3e0b4124c9bfcb5546d82bc1/infra/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json
[modify] https://crrev.com/4a94bcadb9d91faf3e0b4124c9bfcb5546d82bc1/infra/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__2_.json
[modify] https://crrev.com/4a94bcadb9d91faf3e0b4124c9bfcb5546d82bc1/infra/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__3_.json
[modify] https://crrev.com/4a94bcadb9d91faf3e0b4124c9bfcb5546d82bc1/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__1_.json
[modify] https://crrev.com/4a94bcadb9d91faf3e0b4124c9bfcb5546d82bc1/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__2_.json
[modify] https://crrev.com/4a94bcadb9d91faf3e0b4124c9bfcb5546d82bc1/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__3_.json
[modify] https://crrev.com/4a94bcadb9d91faf3e0b4124c9bfcb5546d82bc1/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__1_.json
[modify] https://crrev.com/4a94bcadb9d91faf3e0b4124c9bfcb5546d82bc1/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__2_.json
[modify] https://crrev.com/4a94bcadb9d91faf3e0b4124c9bfcb5546d82bc1/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__3_.json
[modify] https://crrev.com/4a94bcadb9d91faf3e0b4124c9bfcb5546d82bc1/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__1_.json
[modify] https://crrev.com/4a94bcadb9d91faf3e0b4124c9bfcb5546d82bc1/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__2_.json
[modify] https://crrev.com/4a94bcadb9d91faf3e0b4124c9bfcb5546d82bc1/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__3_.json
[modify] https://crrev.com/4a94bcadb9d91faf3e0b4124c9bfcb5546d82bc1/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__1_.json
[modify] https://crrev.com/4a94bcadb9d91faf3e0b4124c9bfcb5546d82bc1/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__2_.json
[modify] https://crrev.com/4a94bcadb9d91faf3e0b4124c9bfcb5546d82bc1/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__3_.json
[modify] https://crrev.com/4a94bcadb9d91faf3e0b4124c9bfcb5546d82bc1/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_WebView_Perf__1_.json
[modify] https://crrev.com/4a94bcadb9d91faf3e0b4124c9bfcb5546d82bc1/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_WebView_Perf__2_.json
[modify] https://crrev.com/4a94bcadb9d91faf3e0b4124c9bfcb5546d82bc1/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_WebView_Perf__3_.json
[modify] https://crrev.com/4a94bcadb9d91faf3e0b4124c9bfcb5546d82bc1/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__1_.json
[modify] https://crrev.com/4a94bcadb9d91faf3e0b4124c9bfcb5546d82bc1/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__2_.json
[modify] https://crrev.com/4a94bcadb9d91faf3e0b4124c9bfcb5546d82bc1/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__3_.json
[modify] https://crrev.com/4a94bcadb9d91faf3e0b4124c9bfcb5546d82bc1/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__1_.json
[modify] https://crrev.com/4a94bcadb9d91faf3e0b4124c9bfcb5546d82bc1/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__2_.json
[modify] https://crrev.com/4a94bcadb9d91faf3e0b4124c9bfcb5546d82bc1/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__3_.json
[modify] https://crrev.com/4a94bcadb9d91faf3e0b4124c9bfcb5546d82bc1/infra/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__1_.json
[modify] https://crrev.com/4a94bcadb9d91faf3e0b4124c9bfcb5546d82bc1/infra/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__2_.json
[modify] https://crrev.com/4a94bcadb9d91faf3e0b4124c9bfcb5546d82bc1/infra/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__3_.json
[modify] https://crrev.com/4a94bcadb9d91faf3e0b4124c9bfcb5546d82bc1/infra/recipes/android/perf.expected/full_chromium_perf_fyi_Android_Power_Nexus_5X_Perf__1_.json
[modify] https://crrev.com/4a94bcadb9d91faf3e0b4124c9bfcb5546d82bc1/infra/recipes/android/perf.expected/get_perf_test_list_old_data.json
[modify] https://crrev.com/4a94bcadb9d91faf3e0b4124c9bfcb5546d82bc1/infra/recipes/android/perf.expected/host_info_failure.json
[modify] https://crrev.com/4a94bcadb9d91faf3e0b4124c9bfcb5546d82bc1/infra/recipes/android/perf.expected/missing_device.json
[modify] https://crrev.com/4a94bcadb9d91faf3e0b4124c9bfcb5546d82bc1/infra/recipes/android/perf.expected/provision_devices.json
[modify] https://crrev.com/4a94bcadb9d91faf3e0b4124c9bfcb5546d82bc1/infra/recipes/android/perf.expected/src_side_script_fails.json
[modify] https://crrev.com/4a94bcadb9d91faf3e0b4124c9bfcb5546d82bc1/infra/recipes/android/perf.expected/test_failure.json
[modify] https://crrev.com/4a94bcadb9d91faf3e0b4124c9bfcb5546d82bc1/infra/recipes/android/perf.py

Project Member

Comment 71 by bugdroid1@chromium.org, Oct 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/224666e8fc0f55f06eb294b6966dc29663e7df7b

commit 224666e8fc0f55f06eb294b6966dc29663e7df7b
Author: nednguyen <nednguyen@google.com>
Date: Thu Oct 20 10:25:05 2016

Revert of [Android] Always use devil's adb in the perf recipes. (patchset #2 id:20001 of https://codereview.chromium.org/2431963004/ )

Reason for revert:
Suspect causing mass failure on Android perf bots.
BUG=619189

Original issue's description:
> [Android] Always use devil's adb in the perf recipes.
>
> BUG= 623989 

TBR=dtu@chromium.org,stip@chromium.org,jbudorick@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 623989 

Review-Url: https://chromiumcodereview.appspot.com/2437013002
Cr-Commit-Position: refs/heads/master@{#426443}

[modify] https://crrev.com/224666e8fc0f55f06eb294b6966dc29663e7df7b/infra/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json
[modify] https://crrev.com/224666e8fc0f55f06eb294b6966dc29663e7df7b/infra/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__2_.json
[modify] https://crrev.com/224666e8fc0f55f06eb294b6966dc29663e7df7b/infra/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__3_.json
[modify] https://crrev.com/224666e8fc0f55f06eb294b6966dc29663e7df7b/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__1_.json
[modify] https://crrev.com/224666e8fc0f55f06eb294b6966dc29663e7df7b/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__2_.json
[modify] https://crrev.com/224666e8fc0f55f06eb294b6966dc29663e7df7b/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__3_.json
[modify] https://crrev.com/224666e8fc0f55f06eb294b6966dc29663e7df7b/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__1_.json
[modify] https://crrev.com/224666e8fc0f55f06eb294b6966dc29663e7df7b/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__2_.json
[modify] https://crrev.com/224666e8fc0f55f06eb294b6966dc29663e7df7b/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__3_.json
[modify] https://crrev.com/224666e8fc0f55f06eb294b6966dc29663e7df7b/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__1_.json
[modify] https://crrev.com/224666e8fc0f55f06eb294b6966dc29663e7df7b/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__2_.json
[modify] https://crrev.com/224666e8fc0f55f06eb294b6966dc29663e7df7b/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__3_.json
[modify] https://crrev.com/224666e8fc0f55f06eb294b6966dc29663e7df7b/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__1_.json
[modify] https://crrev.com/224666e8fc0f55f06eb294b6966dc29663e7df7b/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__2_.json
[modify] https://crrev.com/224666e8fc0f55f06eb294b6966dc29663e7df7b/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__3_.json
[modify] https://crrev.com/224666e8fc0f55f06eb294b6966dc29663e7df7b/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_WebView_Perf__1_.json
[modify] https://crrev.com/224666e8fc0f55f06eb294b6966dc29663e7df7b/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_WebView_Perf__2_.json
[modify] https://crrev.com/224666e8fc0f55f06eb294b6966dc29663e7df7b/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_WebView_Perf__3_.json
[modify] https://crrev.com/224666e8fc0f55f06eb294b6966dc29663e7df7b/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__1_.json
[modify] https://crrev.com/224666e8fc0f55f06eb294b6966dc29663e7df7b/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__2_.json
[modify] https://crrev.com/224666e8fc0f55f06eb294b6966dc29663e7df7b/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__3_.json
[modify] https://crrev.com/224666e8fc0f55f06eb294b6966dc29663e7df7b/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__1_.json
[modify] https://crrev.com/224666e8fc0f55f06eb294b6966dc29663e7df7b/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__2_.json
[modify] https://crrev.com/224666e8fc0f55f06eb294b6966dc29663e7df7b/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__3_.json
[modify] https://crrev.com/224666e8fc0f55f06eb294b6966dc29663e7df7b/infra/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__1_.json
[modify] https://crrev.com/224666e8fc0f55f06eb294b6966dc29663e7df7b/infra/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__2_.json
[modify] https://crrev.com/224666e8fc0f55f06eb294b6966dc29663e7df7b/infra/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__3_.json
[modify] https://crrev.com/224666e8fc0f55f06eb294b6966dc29663e7df7b/infra/recipes/android/perf.expected/full_chromium_perf_fyi_Android_Power_Nexus_5X_Perf__1_.json
[modify] https://crrev.com/224666e8fc0f55f06eb294b6966dc29663e7df7b/infra/recipes/android/perf.expected/get_perf_test_list_old_data.json
[modify] https://crrev.com/224666e8fc0f55f06eb294b6966dc29663e7df7b/infra/recipes/android/perf.expected/host_info_failure.json
[modify] https://crrev.com/224666e8fc0f55f06eb294b6966dc29663e7df7b/infra/recipes/android/perf.expected/missing_device.json
[modify] https://crrev.com/224666e8fc0f55f06eb294b6966dc29663e7df7b/infra/recipes/android/perf.expected/provision_devices.json
[modify] https://crrev.com/224666e8fc0f55f06eb294b6966dc29663e7df7b/infra/recipes/android/perf.expected/src_side_script_fails.json
[modify] https://crrev.com/224666e8fc0f55f06eb294b6966dc29663e7df7b/infra/recipes/android/perf.expected/test_failure.json
[modify] https://crrev.com/224666e8fc0f55f06eb294b6966dc29663e7df7b/infra/recipes/android/perf.py

Project Member

Comment 72 by bugdroid1@chromium.org, Oct 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9904b2d7e49d8687b1fdd0035d511886ba78cbc2

commit 9904b2d7e49d8687b1fdd0035d511886ba78cbc2
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Thu Oct 20 19:08:47 2016

Roll src/third_party/catapult/ ec142e2a9..03664c987 (1 commit).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/ec142e2a93fe..03664c987557

$ git log ec142e2a9..03664c987 --date=short --no-merges --format='%ad %ae %s'
2016-10-20 jbudorick [devil] Add a prefetch interface to devil_env.

BUG= 623989 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://chromiumcodereview.appspot.com/2437113002
Cr-Commit-Position: refs/heads/master@{#426556}

[modify] https://crrev.com/9904b2d7e49d8687b1fdd0035d511886ba78cbc2/DEPS

Project Member

Comment 73 by bugdroid1@chromium.org, Oct 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/561251aa39a34f681ed23d2e865a2fc9368e7c91

commit 561251aa39a34f681ed23d2e865a2fc9368e7c91
Author: jbudorick <jbudorick@chromium.org>
Date: Thu Oct 20 19:51:16 2016

[Android] Always use devil's adb in the perf recipes. (RELAND)

BUG= 623989 

Review-Url: https://chromiumcodereview.appspot.com/2438563004
Cr-Commit-Position: refs/heads/master@{#426569}

[modify] https://crrev.com/561251aa39a34f681ed23d2e865a2fc9368e7c91/infra/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json
[modify] https://crrev.com/561251aa39a34f681ed23d2e865a2fc9368e7c91/infra/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__2_.json
[modify] https://crrev.com/561251aa39a34f681ed23d2e865a2fc9368e7c91/infra/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__3_.json
[modify] https://crrev.com/561251aa39a34f681ed23d2e865a2fc9368e7c91/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__1_.json
[modify] https://crrev.com/561251aa39a34f681ed23d2e865a2fc9368e7c91/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__2_.json
[modify] https://crrev.com/561251aa39a34f681ed23d2e865a2fc9368e7c91/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__3_.json
[modify] https://crrev.com/561251aa39a34f681ed23d2e865a2fc9368e7c91/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__1_.json
[modify] https://crrev.com/561251aa39a34f681ed23d2e865a2fc9368e7c91/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__2_.json
[modify] https://crrev.com/561251aa39a34f681ed23d2e865a2fc9368e7c91/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__3_.json
[modify] https://crrev.com/561251aa39a34f681ed23d2e865a2fc9368e7c91/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__1_.json
[modify] https://crrev.com/561251aa39a34f681ed23d2e865a2fc9368e7c91/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__2_.json
[modify] https://crrev.com/561251aa39a34f681ed23d2e865a2fc9368e7c91/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__3_.json
[modify] https://crrev.com/561251aa39a34f681ed23d2e865a2fc9368e7c91/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__1_.json
[modify] https://crrev.com/561251aa39a34f681ed23d2e865a2fc9368e7c91/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__2_.json
[modify] https://crrev.com/561251aa39a34f681ed23d2e865a2fc9368e7c91/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__3_.json
[modify] https://crrev.com/561251aa39a34f681ed23d2e865a2fc9368e7c91/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_WebView_Perf__1_.json
[modify] https://crrev.com/561251aa39a34f681ed23d2e865a2fc9368e7c91/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_WebView_Perf__2_.json
[modify] https://crrev.com/561251aa39a34f681ed23d2e865a2fc9368e7c91/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_WebView_Perf__3_.json
[modify] https://crrev.com/561251aa39a34f681ed23d2e865a2fc9368e7c91/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__1_.json
[modify] https://crrev.com/561251aa39a34f681ed23d2e865a2fc9368e7c91/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__2_.json
[modify] https://crrev.com/561251aa39a34f681ed23d2e865a2fc9368e7c91/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__3_.json
[modify] https://crrev.com/561251aa39a34f681ed23d2e865a2fc9368e7c91/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__1_.json
[modify] https://crrev.com/561251aa39a34f681ed23d2e865a2fc9368e7c91/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__2_.json
[modify] https://crrev.com/561251aa39a34f681ed23d2e865a2fc9368e7c91/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__3_.json
[modify] https://crrev.com/561251aa39a34f681ed23d2e865a2fc9368e7c91/infra/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__1_.json
[modify] https://crrev.com/561251aa39a34f681ed23d2e865a2fc9368e7c91/infra/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__2_.json
[modify] https://crrev.com/561251aa39a34f681ed23d2e865a2fc9368e7c91/infra/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__3_.json
[modify] https://crrev.com/561251aa39a34f681ed23d2e865a2fc9368e7c91/infra/recipes/android/perf.expected/full_chromium_perf_fyi_Android_Power_Nexus_5X_Perf__1_.json
[modify] https://crrev.com/561251aa39a34f681ed23d2e865a2fc9368e7c91/infra/recipes/android/perf.expected/get_perf_test_list_old_data.json
[modify] https://crrev.com/561251aa39a34f681ed23d2e865a2fc9368e7c91/infra/recipes/android/perf.expected/host_info_failure.json
[modify] https://crrev.com/561251aa39a34f681ed23d2e865a2fc9368e7c91/infra/recipes/android/perf.expected/missing_device.json
[modify] https://crrev.com/561251aa39a34f681ed23d2e865a2fc9368e7c91/infra/recipes/android/perf.expected/provision_devices.json
[modify] https://crrev.com/561251aa39a34f681ed23d2e865a2fc9368e7c91/infra/recipes/android/perf.expected/src_side_script_fails.json
[modify] https://crrev.com/561251aa39a34f681ed23d2e865a2fc9368e7c91/infra/recipes/android/perf.expected/test_failure.json
[modify] https://crrev.com/561251aa39a34f681ed23d2e865a2fc9368e7c91/infra/recipes/android/perf.py

Cc: joedow@chromium.org
Project Member

Comment 75 by bugdroid1@chromium.org, Oct 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e722f038d1ed8cf00ddb075cc328d7e25aae95c3

commit e722f038d1ed8cf00ddb075cc328d7e25aae95c3
Author: jbudorick <jbudorick@chromium.org>
Date: Thu Oct 20 22:45:10 2016

Revert of [Android] Always use devil's adb in the perf recipes. (RELAND) (patchset #2 id:20001 of https://codereview.chromium.org/2438563004/ )

Reason for revert:
breaking again.

Original issue's description:
> [Android] Always use devil's adb in the perf recipes. (RELAND)
>
> BUG= 623989 

TBR=stip@chromium.org,dtu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 623989 

Review-Url: https://chromiumcodereview.appspot.com/2434403002
Cr-Commit-Position: refs/heads/master@{#426624}

[modify] https://crrev.com/e722f038d1ed8cf00ddb075cc328d7e25aae95c3/infra/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json
[modify] https://crrev.com/e722f038d1ed8cf00ddb075cc328d7e25aae95c3/infra/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__2_.json
[modify] https://crrev.com/e722f038d1ed8cf00ddb075cc328d7e25aae95c3/infra/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__3_.json
[modify] https://crrev.com/e722f038d1ed8cf00ddb075cc328d7e25aae95c3/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__1_.json
[modify] https://crrev.com/e722f038d1ed8cf00ddb075cc328d7e25aae95c3/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__2_.json
[modify] https://crrev.com/e722f038d1ed8cf00ddb075cc328d7e25aae95c3/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__3_.json
[modify] https://crrev.com/e722f038d1ed8cf00ddb075cc328d7e25aae95c3/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__1_.json
[modify] https://crrev.com/e722f038d1ed8cf00ddb075cc328d7e25aae95c3/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__2_.json
[modify] https://crrev.com/e722f038d1ed8cf00ddb075cc328d7e25aae95c3/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__3_.json
[modify] https://crrev.com/e722f038d1ed8cf00ddb075cc328d7e25aae95c3/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__1_.json
[modify] https://crrev.com/e722f038d1ed8cf00ddb075cc328d7e25aae95c3/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__2_.json
[modify] https://crrev.com/e722f038d1ed8cf00ddb075cc328d7e25aae95c3/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__3_.json
[modify] https://crrev.com/e722f038d1ed8cf00ddb075cc328d7e25aae95c3/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__1_.json
[modify] https://crrev.com/e722f038d1ed8cf00ddb075cc328d7e25aae95c3/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__2_.json
[modify] https://crrev.com/e722f038d1ed8cf00ddb075cc328d7e25aae95c3/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__3_.json
[modify] https://crrev.com/e722f038d1ed8cf00ddb075cc328d7e25aae95c3/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_WebView_Perf__1_.json
[modify] https://crrev.com/e722f038d1ed8cf00ddb075cc328d7e25aae95c3/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_WebView_Perf__2_.json
[modify] https://crrev.com/e722f038d1ed8cf00ddb075cc328d7e25aae95c3/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_WebView_Perf__3_.json
[modify] https://crrev.com/e722f038d1ed8cf00ddb075cc328d7e25aae95c3/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__1_.json
[modify] https://crrev.com/e722f038d1ed8cf00ddb075cc328d7e25aae95c3/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__2_.json
[modify] https://crrev.com/e722f038d1ed8cf00ddb075cc328d7e25aae95c3/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__3_.json
[modify] https://crrev.com/e722f038d1ed8cf00ddb075cc328d7e25aae95c3/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__1_.json
[modify] https://crrev.com/e722f038d1ed8cf00ddb075cc328d7e25aae95c3/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__2_.json
[modify] https://crrev.com/e722f038d1ed8cf00ddb075cc328d7e25aae95c3/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__3_.json
[modify] https://crrev.com/e722f038d1ed8cf00ddb075cc328d7e25aae95c3/infra/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__1_.json
[modify] https://crrev.com/e722f038d1ed8cf00ddb075cc328d7e25aae95c3/infra/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__2_.json
[modify] https://crrev.com/e722f038d1ed8cf00ddb075cc328d7e25aae95c3/infra/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__3_.json
[modify] https://crrev.com/e722f038d1ed8cf00ddb075cc328d7e25aae95c3/infra/recipes/android/perf.expected/full_chromium_perf_fyi_Android_Power_Nexus_5X_Perf__1_.json
[modify] https://crrev.com/e722f038d1ed8cf00ddb075cc328d7e25aae95c3/infra/recipes/android/perf.expected/get_perf_test_list_old_data.json
[modify] https://crrev.com/e722f038d1ed8cf00ddb075cc328d7e25aae95c3/infra/recipes/android/perf.expected/host_info_failure.json
[modify] https://crrev.com/e722f038d1ed8cf00ddb075cc328d7e25aae95c3/infra/recipes/android/perf.expected/missing_device.json
[modify] https://crrev.com/e722f038d1ed8cf00ddb075cc328d7e25aae95c3/infra/recipes/android/perf.expected/provision_devices.json
[modify] https://crrev.com/e722f038d1ed8cf00ddb075cc328d7e25aae95c3/infra/recipes/android/perf.expected/src_side_script_fails.json
[modify] https://crrev.com/e722f038d1ed8cf00ddb075cc328d7e25aae95c3/infra/recipes/android/perf.expected/test_failure.json
[modify] https://crrev.com/e722f038d1ed8cf00ddb075cc328d7e25aae95c3/infra/recipes/android/perf.py

Project Member

Comment 76 by bugdroid1@chromium.org, Oct 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8b2a521ccd425935ef26a70e0f65b57de50d788

commit a8b2a521ccd425935ef26a70e0f65b57de50d788
Author: stip <stip@chromium.org>
Date: Fri Oct 21 12:45:55 2016

[Reland] Upgrade to new Android SDK.

https://codereview.chromium.org/2350013004/ was reverted due to breakage on the perf waterfall. After https://codereview.chromium.org/2438563004/, this should hopefully be resolved.

BUG= 623989 

Review-Url: https://chromiumcodereview.appspot.com/2438133002
Cr-Commit-Position: refs/heads/master@{#426777}

[modify] https://crrev.com/a8b2a521ccd425935ef26a70e0f65b57de50d788/DEPS
[modify] https://crrev.com/a8b2a521ccd425935ef26a70e0f65b57de50d788/build/android/BUILD.gn
[modify] https://crrev.com/a8b2a521ccd425935ef26a70e0f65b57de50d788/build/android/devil_chromium.json
[modify] https://crrev.com/a8b2a521ccd425935ef26a70e0f65b57de50d788/build/android/lint/suppressions.xml
[modify] https://crrev.com/a8b2a521ccd425935ef26a70e0f65b57de50d788/build/android/pylib/constants/__init__.py
[modify] https://crrev.com/a8b2a521ccd425935ef26a70e0f65b57de50d788/build/config/android/config.gni
[modify] https://crrev.com/a8b2a521ccd425935ef26a70e0f65b57de50d788/components/cronet/android/api/build.xml
[modify] https://crrev.com/a8b2a521ccd425935ef26a70e0f65b57de50d788/components/cronet/tools/generate_javadoc.py
[modify] https://crrev.com/a8b2a521ccd425935ef26a70e0f65b57de50d788/docs/android_test_instructions.md
[modify] https://crrev.com/a8b2a521ccd425935ef26a70e0f65b57de50d788/tools/android/eclipse/.classpath

Project Member

Comment 77 by bugdroid1@chromium.org, Oct 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2cac736a2e38757f6cfcec2c750f37ed0cc0505

commit f2cac736a2e38757f6cfcec2c750f37ed0cc0505
Author: jbudorick <jbudorick@chromium.org>
Date: Fri Oct 21 14:26:26 2016

[android] Resume passing adb path to the test runner in android/perf.

viable now that we set devil's adb as the adb path in the recipe.

BUG= 623989 
TBR=stip@chromium.org,dtu@chromium.org

Review-Url: https://chromiumcodereview.appspot.com/2442663003
Cr-Commit-Position: refs/heads/master@{#426789}

[modify] https://crrev.com/f2cac736a2e38757f6cfcec2c750f37ed0cc0505/infra/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json
[modify] https://crrev.com/f2cac736a2e38757f6cfcec2c750f37ed0cc0505/infra/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__2_.json
[modify] https://crrev.com/f2cac736a2e38757f6cfcec2c750f37ed0cc0505/infra/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__3_.json
[modify] https://crrev.com/f2cac736a2e38757f6cfcec2c750f37ed0cc0505/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__1_.json
[modify] https://crrev.com/f2cac736a2e38757f6cfcec2c750f37ed0cc0505/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__2_.json
[modify] https://crrev.com/f2cac736a2e38757f6cfcec2c750f37ed0cc0505/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__3_.json
[modify] https://crrev.com/f2cac736a2e38757f6cfcec2c750f37ed0cc0505/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__1_.json
[modify] https://crrev.com/f2cac736a2e38757f6cfcec2c750f37ed0cc0505/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__2_.json
[modify] https://crrev.com/f2cac736a2e38757f6cfcec2c750f37ed0cc0505/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__3_.json
[modify] https://crrev.com/f2cac736a2e38757f6cfcec2c750f37ed0cc0505/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__1_.json
[modify] https://crrev.com/f2cac736a2e38757f6cfcec2c750f37ed0cc0505/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__2_.json
[modify] https://crrev.com/f2cac736a2e38757f6cfcec2c750f37ed0cc0505/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__3_.json
[modify] https://crrev.com/f2cac736a2e38757f6cfcec2c750f37ed0cc0505/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__1_.json
[modify] https://crrev.com/f2cac736a2e38757f6cfcec2c750f37ed0cc0505/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__2_.json
[modify] https://crrev.com/f2cac736a2e38757f6cfcec2c750f37ed0cc0505/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__3_.json
[modify] https://crrev.com/f2cac736a2e38757f6cfcec2c750f37ed0cc0505/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_WebView_Perf__1_.json
[modify] https://crrev.com/f2cac736a2e38757f6cfcec2c750f37ed0cc0505/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_WebView_Perf__2_.json
[modify] https://crrev.com/f2cac736a2e38757f6cfcec2c750f37ed0cc0505/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_WebView_Perf__3_.json
[modify] https://crrev.com/f2cac736a2e38757f6cfcec2c750f37ed0cc0505/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__1_.json
[modify] https://crrev.com/f2cac736a2e38757f6cfcec2c750f37ed0cc0505/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__2_.json
[modify] https://crrev.com/f2cac736a2e38757f6cfcec2c750f37ed0cc0505/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__3_.json
[modify] https://crrev.com/f2cac736a2e38757f6cfcec2c750f37ed0cc0505/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__1_.json
[modify] https://crrev.com/f2cac736a2e38757f6cfcec2c750f37ed0cc0505/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__2_.json
[modify] https://crrev.com/f2cac736a2e38757f6cfcec2c750f37ed0cc0505/infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__3_.json
[modify] https://crrev.com/f2cac736a2e38757f6cfcec2c750f37ed0cc0505/infra/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__1_.json
[modify] https://crrev.com/f2cac736a2e38757f6cfcec2c750f37ed0cc0505/infra/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__2_.json
[modify] https://crrev.com/f2cac736a2e38757f6cfcec2c750f37ed0cc0505/infra/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__3_.json
[modify] https://crrev.com/f2cac736a2e38757f6cfcec2c750f37ed0cc0505/infra/recipes/android/perf.expected/full_chromium_perf_fyi_Android_Power_Nexus_5X_Perf__1_.json
[modify] https://crrev.com/f2cac736a2e38757f6cfcec2c750f37ed0cc0505/infra/recipes/android/perf.expected/get_perf_test_list_old_data.json
[modify] https://crrev.com/f2cac736a2e38757f6cfcec2c750f37ed0cc0505/infra/recipes/android/perf.expected/host_info_failure.json
[modify] https://crrev.com/f2cac736a2e38757f6cfcec2c750f37ed0cc0505/infra/recipes/android/perf.expected/missing_device.json
[modify] https://crrev.com/f2cac736a2e38757f6cfcec2c750f37ed0cc0505/infra/recipes/android/perf.expected/src_side_script_fails.json
[modify] https://crrev.com/f2cac736a2e38757f6cfcec2c750f37ed0cc0505/infra/recipes/android/perf.expected/test_failure.json
[modify] https://crrev.com/f2cac736a2e38757f6cfcec2c750f37ed0cc0505/infra/recipes/android/perf.py

Project Member

Comment 78 by bugdroid1@chromium.org, Oct 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8397f04a7f49909e445d30ccb8d187fedc7959e2

commit 8397f04a7f49909e445d30ccb8d187fedc7959e2
Author: jbudorick <jbudorick@chromium.org>
Date: Fri Oct 21 23:24:56 2016

Revert of [Reland] Upgrade to new Android SDK. (patchset #2 id:20001 of https://codereview.chromium.org/2438133002/ )

Reason for revert:
forward --list issues + gtest perf test adb locations need to be updated.

Original issue's description:
> [Reland] Upgrade to new Android SDK.
>
> https://codereview.chromium.org/2350013004/ was reverted due to breakage on the perf waterfall. After https://codereview.chromium.org/2438563004/, this should hopefully be resolved.
>
> BUG= 623989 
>
> Committed: https://crrev.com/a8b2a521ccd425935ef26a70e0f65b57de50d788
> Cr-Commit-Position: refs/heads/master@{#426777}

TBR=xunjieli@chromium.org,stip@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 623989 

Review-Url: https://chromiumcodereview.appspot.com/2438913004
Cr-Commit-Position: refs/heads/master@{#426926}

[modify] https://crrev.com/8397f04a7f49909e445d30ccb8d187fedc7959e2/DEPS
[modify] https://crrev.com/8397f04a7f49909e445d30ccb8d187fedc7959e2/build/android/BUILD.gn
[modify] https://crrev.com/8397f04a7f49909e445d30ccb8d187fedc7959e2/build/android/devil_chromium.json
[modify] https://crrev.com/8397f04a7f49909e445d30ccb8d187fedc7959e2/build/android/lint/suppressions.xml
[modify] https://crrev.com/8397f04a7f49909e445d30ccb8d187fedc7959e2/build/android/pylib/constants/__init__.py
[modify] https://crrev.com/8397f04a7f49909e445d30ccb8d187fedc7959e2/build/config/android/config.gni
[modify] https://crrev.com/8397f04a7f49909e445d30ccb8d187fedc7959e2/components/cronet/android/api/build.xml
[modify] https://crrev.com/8397f04a7f49909e445d30ccb8d187fedc7959e2/components/cronet/tools/generate_javadoc.py
[modify] https://crrev.com/8397f04a7f49909e445d30ccb8d187fedc7959e2/docs/android_test_instructions.md
[modify] https://crrev.com/8397f04a7f49909e445d30ccb8d187fedc7959e2/tools/android/eclipse/.classpath

Project Member

Comment 79 by bugdroid1@chromium.org, Oct 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99557feac28b32cd281951050b9b7d2397534e31

commit 99557feac28b32cd281951050b9b7d2397534e31
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Sat Oct 22 01:09:34 2016

Roll src/third_party/catapult/ fe41618f8..b7d8fe883 (8 commits).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/fe41618f8d39..b7d8fe883c16

$ git log fe41618f8..b7d8fe883 --date=short --no-merges --format='%ad %ae %s'
2016-10-21 bpastene devil: Add some logging to device_monitor.
2016-10-21 jbudorick Revert of [devil] Roll to ADB 1.0.36. (patchset #1 id:1 of https://codereview.chromium.org/2436373002/ )
2016-10-21 aiolos Add solidSelectedDots option to chart_series config.
2016-10-21 benjhayden Set text-overflow:ellipsis on Name column cells in histogram-set-table.
2016-10-21 benjhayden Fix and test metrics side panel.
2016-10-21 rnephew [Android][Telemetry] Show output of adb.ForwardList when error detected.
2016-10-21 rnephew [Devil] Fix more forwarder logging.
2016-10-21 jbudorick [devil] Roll to ADB 1.0.36.

BUG=649481, 623989 , 655653 , 655625 , 623989 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://chromiumcodereview.appspot.com/2445473002
Cr-Commit-Position: refs/heads/master@{#426940}

[modify] https://crrev.com/99557feac28b32cd281951050b9b7d2397534e31/DEPS

Comment 80 by torne@chromium.org, Oct 24 2016

Thanks for the work everyone (especially stip@) has put in to try to get this rolled.

Once it actually lands and sticks, I think it'd be useful to look at why this was so difficult/time-consuming (past the original issue of waiting for the source when we didn't really need to), and try to figure out if there's anything we can do to make it easier/quicker next time.

WebView's process around new android releases really depends on being able to roll the public SDK in chromium quickly, ideally at least a week before the very next branch point - for the N SDK it would have been ideal to land the roll by mid-august so that we had time to upstream the WebView N code for the M54 branch point, and currently it looks like we're barely going to make M56.
Project Member

Comment 81 by bugdroid1@chromium.org, Oct 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2522b42f5183a9d888977578d7b51d82b06d4c7e

commit 2522b42f5183a9d888977578d7b51d82b06d4c7e
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Mon Oct 24 18:10:44 2016

Roll src/third_party/catapult/ 6962f5c03..4d43e1baa (2 commits).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/6962f5c0344a..4d43e1baaf06

$ git log 6962f5c03..4d43e1baa --date=short --no-merges --format='%ad %ae %s'
2016-10-24 jbudorick [devil]  Add support for run-as in DeviceUtils.RunShellCommand.
2016-10-24 jbudorick [devil] Work around occasionally fatal `adb forward --list` bug.

BUG= 623989 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2444983002
Cr-Commit-Position: refs/heads/master@{#427099}

[modify] https://crrev.com/2522b42f5183a9d888977578d7b51d82b06d4c7e/DEPS

Blockedon: 658319
Project Member

Comment 84 by bugdroid1@chromium.org, Oct 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/760e37b61375f71dfaf6f0014fc9f9e68cee45f3

commit 760e37b61375f71dfaf6f0014fc9f9e68cee45f3
Author: jbudorick <jbudorick@chromium.org>
Date: Wed Oct 26 03:59:59 2016

[android] Make chromium.gpu.fyi bots use devil adb throughout.

BUG= 623989 
TBR=stip@chromium.org,kbr@chromium.org

Review-Url: https://codereview.chromium.org/2453683002

[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/api.py
[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/config.py
[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/example.expected/basic_builder_basic.json
[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/example.expected/coverage_builder_basic.json
[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/example.expected/device_file_format_mismatch.json
[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/example.expected/device_flags_builder_basic.json
[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/example.expected/downgrade_install_tester_basic.json
[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/example.expected/enable_platform_mode_basic.json
[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/example.expected/gerrit_refs.json
[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/example.expected/gerrit_try_builder_basic.json
[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/example.expected/json_results_file_basic.json
[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/example.expected/last_known_devices_basic.json
[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/example.expected/no_cache_builder_basic.json
[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/example.expected/no_strict_mode_tester_basic.json
[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/example.expected/perf_adb_vendor_keys_basic.json
[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/example.expected/perf_runner_allow_high_battery_temp_basic.json
[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/example.expected/perf_runner_allow_low_battery_basic.json
[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/example.expected/perf_runner_basic.json
[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/example.expected/perf_runner_disable_location_basic.json
[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/example.expected/perf_runner_user_build_basic.json
[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/example.expected/perf_tests_failure.json
[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/example.expected/perf_tests_infra_failure.json
[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/example.expected/resource_size_builder_basic.json
[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/example.expected/restart_usb_builder_basic.json
[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/example.expected/result_details_basic.json
[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/example.expected/slow_tester_basic.json
[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/example.expected/specific_install_tester_basic.json
[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/example.expected/telemetry_browser_tests_failures.json
[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/example.expected/telemetry_browser_tests_tester_basic.json
[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/example.expected/tester_basic.json
[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/example.expected/tester_blacklisted_devices.json
[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/example.expected/tester_failing_host_info.json
[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/example.expected/tester_offline_devices.json
[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/example.expected/tester_with_step_warning.json
[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/example.expected/timestamp_as_point_id_basic.json
[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/example.expected/tombstones_m53.json
[add] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/example.expected/use_devil_adb_basic.json
[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/example.expected/webview_cts_basic.json
[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/example.expected/webview_cts_expected_failure.json
[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/example.expected/webview_cts_invalid_output.json
[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/example.expected/webview_cts_invalid_platform.json
[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/example.expected/webview_cts_unexecuted_tests.json
[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/example.expected/webview_cts_unexpected_class_failure.json
[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/example.expected/webview_cts_unexpected_method_failure.json
[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/example.expected/webview_tester_basic.json
[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_android/example.py
[modify] https://crrev.com/760e37b61375f71dfaf6f0014fc9f9e68cee45f3/scripts/slave/recipe_modules/chromium_tests/chromium_gpu_fyi.py

Project Member

Comment 85 by bugdroid1@chromium.org, Oct 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7dc6f8808ab6d9b499efcc6eb54b515eaa02e6bb

commit 7dc6f8808ab6d9b499efcc6eb54b515eaa02e6bb
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Wed Oct 26 15:38:02 2016

Roll src/third_party/catapult/ 8d60f90b4..e1cc507f8 (1 commit).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/8d60f90b4c84..e1cc507f8122

$ git log 8d60f90b4..e1cc507f8 --date=short --no-merges --format='%ad %ae %s'
2016-10-26 jbudorick [telemetry] Pass adb path to tombstones.py.

BUG= 623989 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2452893004
Cr-Commit-Position: refs/heads/master@{#427698}

[modify] https://crrev.com/7dc6f8808ab6d9b499efcc6eb54b515eaa02e6bb/DEPS

Project Member

Comment 86 by bugdroid1@chromium.org, Oct 26 2016

Project Member

Comment 87 by bugdroid1@chromium.org, Oct 26 2016

Project Member

Comment 88 by bugdroid1@chromium.org, Oct 26 2016

Project Member

Comment 89 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d39f07766d7980d4ae46a614e85d5b37ca166e4

commit 7d39f07766d7980d4ae46a614e85d5b37ca166e4
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Thu Oct 27 01:11:52 2016

Roll src/third_party/catapult/ 6097744b7..eeeba06a9 (6 commits).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/6097744b73fe..eeeba06a9874

$ git log 6097744b7..eeeba06a9 --date=short --no-merges --format='%ad %ae %s'
2016-10-26 rnephew [Telemetry] Move from telemetry WaitFor to py_utils WaitFor
2016-10-26 benjhayden Relax RelatedHistogramBreakdown restrictions.
2016-10-26 jbudorick [telemetry] No more raw adb calls!
2016-10-26 eakuefner [Telemetry] Remove --output-format=html2
2016-10-26 benjhayden Allow Histogram to have a singular bin.
2016-10-26 robertocn compare_samples should not fail when runs contain no data.

BUG= 623989 , 659318 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2455523003
Cr-Commit-Position: refs/heads/master@{#427901}

[modify] https://crrev.com/7d39f07766d7980d4ae46a614e85d5b37ca166e4/DEPS

Cc: sanfin@chromium.org
Project Member

Comment 92 by bugdroid1@chromium.org, Oct 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f83518dc187930a5bf43665b2b0f7d885bbd1b3

commit 1f83518dc187930a5bf43665b2b0f7d885bbd1b3
Author: agrieve <agrieve@chromium.org>
Date: Fri Oct 28 15:35:39 2016

Write out useful Android GN vars in a non-gradle-specific form.

My intention is to use these variables in our downstream release
scripts rather than hardcoding the location of the active android sdk.

BUG= 623989 

Review-Url: https://codereview.chromium.org/2447413003
Cr-Commit-Position: refs/heads/master@{#428380}

[modify] https://crrev.com/1f83518dc187930a5bf43665b2b0f7d885bbd1b3/build/android/BUILD.gn
[modify] https://crrev.com/1f83518dc187930a5bf43665b2b0f7d885bbd1b3/build/android/gradle/generate_gradle.py

Project Member

Comment 93 by bugdroid1@chromium.org, Oct 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66729904d0d4b9a00dd671db4714cbc7e40495d0

commit 66729904d0d4b9a00dd671db4714cbc7e40495d0
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Mon Oct 31 22:56:17 2016

Roll src/third_party/catapult/ d44a7cccf..3c6de14e2 (7 commits).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/d44a7cccf2af..3c6de14e28c7

$ git log d44a7cccf..3c6de14e2 --date=short --no-merges --format='%ad %ae %s'
2016-10-31 eakuefner Revert of [Telemetry] Ensure that story display names are unique (patchset #1 id:1 of https://codereview.chromium.org/2465883003/ )
2016-10-31 benjhayden Fix column_chart.drawRect_.
2016-10-31 benjhayden Fix empty Breakdowns.
2016-10-31 alexandermont Add metric for the average power for the whole trace.
2016-10-31 jbudorick Reland of [devil] Roll to ADB 1.0.36. (patchset #1 id:1 of https://codereview.chromium.org/2439243002/ )
2016-10-31 alexandermont Turn on eslint rules that generate no current warnings.
2016-10-31 eakuefner Reland of [Telemetry] Ensure that story display names are unique (patchset #1 id:1 of https://codereview.chromium.org/2457303003/ )

BUG= 623989 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2463013004
Cr-Commit-Position: refs/heads/master@{#428853}

[modify] https://crrev.com/66729904d0d4b9a00dd671db4714cbc7e40495d0/DEPS

Issue 660997 has been merged into this issue.

Comment 95 by awdf@chromium.org, Nov 1 2016

Cc: -awdf@chromium.org
Project Member

Comment 96 by bugdroid1@chromium.org, Nov 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9cb54867442db0d7d556dcae7c139c5f7de77f5

commit e9cb54867442db0d7d556dcae7c139c5f7de77f5
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Tue Nov 01 21:33:17 2016

Roll src/third_party/catapult/ 42836761f..807b60525 (3 commits).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/42836761f6ea..807b60525540

$ git log 42836761f..807b60525 --date=short --no-merges --format='%ad %ae %s'
2016-11-01 charliea Mark template strings as approved for use in Catapult
2016-11-01 jbudorick Revert of [devil] Roll to ADB 1.0.36. (patchset #1 id:1 of https://codereview.chromium.org/2458563002/ )
2016-11-01 benjhayden Fix single-event-sub-view table too wide.

BUG= 623989 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2466253003
Cr-Commit-Position: refs/heads/master@{#429117}

[modify] https://crrev.com/e9cb54867442db0d7d556dcae7c139c5f7de77f5/DEPS

Project Member

Comment 97 by bugdroid1@chromium.org, Nov 2 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/82e67f8e22ce950f822c0dce53766bf7c89ca71e

commit 82e67f8e22ce950f822c0dce53766bf7c89ca71e
Author: Andrew Grieve <agrieve@chromium.org>
Date: Thu Oct 27 15:14:06 2016

Project Member

Comment 98 by bugdroid1@chromium.org, Nov 3 2016

Comment 99 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
Are there plans to update 'default_lint_android_sdk_version' from API level 23 to 24?  I see some lint errors when using new N functionality which are resolved when the lint target is updated.
Yep, this should be updated. Created a CL here: https://codereview.chromium.org/2498503003#

Let's see if it passes dry-run...
Project Member

Comment 102 by bugdroid1@chromium.org, Nov 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a410e098e9497a90722b14604fab8e8fbf79c0b3

commit a410e098e9497a90722b14604fab8e8fbf79c0b3
Author: agrieve <agrieve@chromium.org>
Date: Tue Nov 15 00:53:56 2016

Bump default_lint_android_sdk_version to 24 to match sdk

BUG= 623989 

Review-Url: https://codereview.chromium.org/2498503003
Cr-Commit-Position: refs/heads/master@{#432036}

[modify] https://crrev.com/a410e098e9497a90722b14604fab8e8fbf79c0b3/build/config/android/config.gni

Labels: -M-55 M-56
Will keep this on radars for M56 by setting to M56 RB-Stable but not going to track this as an M55 blocker any longer.
Blocking: 670502
Blocking: -670502
Labels: -ReleaseBlock-Stable
Status: Fixed (was: Assigned)
N MR1 and our lingering adb 1.0.32/1.0.36 issues will be tracked separately.
Showing comments 8 - 107 of 107 Older

Sign in to add a comment