Apologies. Should have filed this under "component:Platform>DevTools>Security". Not sure how to change this.

I can help with that :-)

Oh boy. This uncovered something good.

I think our js minifier doesn't know about backtick strings, because it dropped a trailing space here. (see screenshot).

allada, can you put in a workaround?

In the meantime we'll have to sort out the bug in the minifier... :/

Deleted: Screen Shot 2016-06-30 at 5.49.29 PM.png 156 KB

	Screen Shot 2016-06-30 at 5.49.29 PM.png 156 KB View Download

This appears to have been fixed.

This is not fixed.

After you land the fix can you also get this merged into the 53 branch?

To repeat, you will not be able to reproduce this in a debug_devtools build, as the bug manifests only in the minified network_module.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/111e5134f9b68baf3c1a67ed5732b3de1de2048c

commit 111e5134f9b68baf3c1a67ed5732b3de1de2048c
Author: allada <allada@chromium.org>
Date: Tue Aug 09 04:15:34 2016

[Devtools] Fix RJSMIN for backtick

Fixed RJSMin for backtick string templates not compiling when space was
present at end of backtrick string.

BUG= 623983 

Review-Url: https://codereview.chromium.org/2229683002
Cr-Commit-Position: refs/heads/master@{#410572}

[add] https://crrev.com/111e5134f9b68baf3c1a67ed5732b3de1de2048c/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-filters-internals-expected.txt
[add] https://crrev.com/111e5134f9b68baf3c1a67ed5732b3de1de2048c/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-filters-internals.html
[modify] https://crrev.com/111e5134f9b68baf3c1a67ed5732b3de1de2048c/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/111e5134f9b68baf3c1a67ed5732b3de1de2048c/third_party/WebKit/Source/devtools/devtools.gyp
[modify] https://crrev.com/111e5134f9b68baf3c1a67ed5732b3de1de2048c/third_party/WebKit/Source/devtools/scripts/rjsmin.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79df4803990d12f67cbaba6d912673d163baac12

commit 79df4803990d12f67cbaba6d912673d163baac12
Author: pfeldman <pfeldman@chromium.org>
Date: Tue Aug 09 21:52:37 2016

DevTools: do not use string templates in front-end, minifier is confused.

R=paulirish
BUG= 623983 

Review-Url: https://codereview.chromium.org/2226163002
Cr-Commit-Position: refs/heads/master@{#410842}

[modify] https://crrev.com/79df4803990d12f67cbaba6d912673d163baac12/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4791481181df61d43d75188bf095375a1641401

commit f4791481181df61d43d75188bf095375a1641401
Author: paulirish <paulirish@chromium.org>
Date: Thu Aug 11 00:51:48 2016

Revert of DevTools: do not use string templates in front-end, minifier is confused. (patchset #1 id:1 of https://codereview.chromium.org/2226163002/ )

Reason for revert:
https://codereview.chromium.org/2229683002 landed so we don't need this any longer

Original issue's description:
> DevTools: do not use string templates in front-end, minifier is confused.
>
> R=paulirish
> BUG= 623983 
>
> Committed: https://crrev.com/79df4803990d12f67cbaba6d912673d163baac12
> Cr-Commit-Position: refs/heads/master@{#410842}

TBR=pfeldman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 623983 

Review-Url: https://codereview.chromium.org/2224173005
Cr-Commit-Position: refs/heads/master@{#411208}

[modify] https://crrev.com/f4791481181df61d43d75188bf095375a1641401/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

allada - what's the plan for a merge?

@paulirish I spoke to lushnikov@ and he said lets wait until thursday/friday to ensure there are no side effects.

I'm guessing a merge is moot now that M54 has branched. Is this Fixed?

I forgot to get this going, I'll begin a merge with 53.

[Automated comment] Less than 2 weeks to go before stable on M53, manual review required.

Please note that M53 is already in Stable for Desktop and bar is VERY high, we take this change ONLY if it is important, well baked/verified in Canary/Dev and safe to merge. Otherwise, can it wait until M54 goes to Stable?


Also is this change applicable to all OS or any specific OS?

We can hold off on merging to 53. Thanks for considering

 Issue 646784  has been merged into this issue.

 Issue 656993  has been merged into this issue.