Issue metadata
Sign in to add a comment
|
4.3% regression in page_cycler.intl_es_fr_pt-BR at 402235:402262 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jun 29 2016
=== Auto-CCing suspected CL author mdjones@chromium.org === Hi mdjones@chromium.org, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Watch for RenderFrameHost switch in distillability Author : mdjones Commit description: When navigating to/from a native page, the RenderFrameHost would switch and the distillability service would lose connection. This would cause Reader Mode to be broken for a few navigations. The DistillabilityDriver now listens for this switch and updates the service accordingly. BUG=615327 Review-Url: https://codereview.chromium.org/2060423003 Cr-Commit-Position: refs/heads/master@{#402245} Commit : acf19900a4a4dafcbac2ef2258522abf5f81ba9c Date : Mon Jun 27 19:04:05 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@402234 33178.2 64.2134 6 good chromium@402241 33059.2 82.1596 5 good chromium@402243 33183.8 43.6715 5 good chromium@402244 33200.0 60.0999 5 good chromium@402245 34500.0 97.9617 5 bad <-- chromium@402248 34453.6 81.1714 5 bad chromium@402262 34639.4 92.5867 5 bad Bisect job ran on: android_nexus6_perf_bisect Bug ID: 623979 Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests page_cycler.intl_es_fr_pt-BR Test Metric: vm_private_dirty_final_browser/vm_private_dirty_final_browser Relative Change: 4.37% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus6_perf_bisect/builds/2268 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9008598232303424464 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5804774402818048 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Jun 29 2016
,
Jul 1 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 8 2016
Any update on this?
,
Jul 8 2016
The service we need for the Reader Mode feature is being set up too many times; working on a fix now.
,
Jul 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/70bb9fd22cc806498fc63a5749fdaaaea7354564 commit 70bb9fd22cc806498fc63a5749fdaaaea7354564 Author: mdjones <mdjones@chromium.org> Date: Mon Jul 11 16:58:40 2016 Only setup distillability mojo if needed Prevent extra calls to set up mojo for Reader Mode's distillability logic. Currently the distillability service is set up for any RenderFrameHost that changes (this is not necessarily the main frame) and even if the old service is still alive. This change starts watching for when the service is killed and avoids service setup on non-main frame hosts. BUG= 623979 Review-Url: https://codereview.chromium.org/2131343002 Cr-Commit-Position: refs/heads/master@{#404678} [modify] https://crrev.com/70bb9fd22cc806498fc63a5749fdaaaea7354564/components/dom_distiller/content/browser/distillability_driver.cc [modify] https://crrev.com/70bb9fd22cc806498fc63a5749fdaaaea7354564/components/dom_distiller/content/browser/distillability_driver.h
,
Jul 13 2016
,
Jul 30 2016
,
Jul 30 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Jul 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/74bcb27419c3d35e16fffc977ceb32466f5d53b8 commit 74bcb27419c3d35e16fffc977ceb32466f5d53b8 Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Date: Sat Jul 30 00:31:41 2016 Only setup distillability mojo if needed Prevent extra calls to set up mojo for Reader Mode's distillability logic. Currently the distillability service is set up for any RenderFrameHost that changes (this is not necessarily the main frame) and even if the old service is still alive. This change starts watching for when the service is killed and avoids service setup on non-main frame hosts. BUG= 623979 Review-Url: https://codereview.chromium.org/2131343002 Cr-Commit-Position: refs/heads/master@{#404678} (cherry picked from commit 70bb9fd22cc806498fc63a5749fdaaaea7354564) Review URL: https://codereview.chromium.org/2195123002 . Cr-Commit-Position: refs/branch-heads/2785@{#416} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/74bcb27419c3d35e16fffc977ceb32466f5d53b8/components/dom_distiller/content/browser/distillability_driver.cc [modify] https://crrev.com/74bcb27419c3d35e16fffc977ceb32466f5d53b8/components/dom_distiller/content/browser/distillability_driver.h |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by lanwei@google.com
, Jun 28 2016