Clean up predictor code in chrome_net_benchmarking_message_filter |
||
Issue descriptionThe code in chrome_net_benchmarking_message_filter currently grabs a Profile pointer and accesses the Predictor from there. We should instead - Store a pointer to the Predictor - Observe profile shutdown on the UI thread via KeyedServiceShutdownNotifier and clear the predictor pointer when that happens
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4909ec849b19c4a89caa4413e3e7cb9de9a8fab2 commit 4909ec849b19c4a89caa4413e3e7cb9de9a8fab2 Author: Alexandr Ilin <alexilin@chromium.org> Date: Wed Jun 06 10:22:48 2018 predictors: Update the NetBenchmarking to clear the LoadingPredictor DB NetBenchmarking provides a method to clear network predictor cache. The predictor is migrating to a different service, so this method should clear a different DB. This CL also removes unsafe storing a Profile* on the IO thread. The NetBenchmarking stores weak pointers to predictors instead. Bug: 838949 , 623967 Change-Id: Ie73d57555237aea4ebb7be1a324151e5ea190b68 Reviewed-on: https://chromium-review.googlesource.com/1085450 Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#564846} [modify] https://crrev.com/4909ec849b19c4a89caa4413e3e7cb9de9a8fab2/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/4909ec849b19c4a89caa4413e3e7cb9de9a8fab2/chrome/browser/net/predictor.h [modify] https://crrev.com/4909ec849b19c4a89caa4413e3e7cb9de9a8fab2/chrome/browser/net_benchmarking.cc [modify] https://crrev.com/4909ec849b19c4a89caa4413e3e7cb9de9a8fab2/chrome/browser/net_benchmarking.h [modify] https://crrev.com/4909ec849b19c4a89caa4413e3e7cb9de9a8fab2/chrome/browser/predictors/resource_prefetch_predictor.cc [modify] https://crrev.com/4909ec849b19c4a89caa4413e3e7cb9de9a8fab2/chrome/browser/predictors/resource_prefetch_predictor.h [modify] https://crrev.com/4909ec849b19c4a89caa4413e3e7cb9de9a8fab2/chrome/browser/predictors/resource_prefetch_predictor_unittest.cc
,
Jun 6 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by sheriffbot@chromium.org
, Jun 29 2017Status: Untriaged (was: Available)