New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 623967 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Clean up predictor code in chrome_net_benchmarking_message_filter

Project Member Reported by csharrison@chromium.org, Jun 28 2016

Issue description

The code in chrome_net_benchmarking_message_filter currently grabs a Profile pointer and accesses the Predictor from there.

We should instead
 - Store a pointer to the Predictor
 - Observe profile shutdown on the UI thread via KeyedServiceShutdownNotifier and clear the predictor pointer when that happens
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jun 29 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4909ec849b19c4a89caa4413e3e7cb9de9a8fab2

commit 4909ec849b19c4a89caa4413e3e7cb9de9a8fab2
Author: Alexandr Ilin <alexilin@chromium.org>
Date: Wed Jun 06 10:22:48 2018

predictors: Update the NetBenchmarking to clear the LoadingPredictor DB

NetBenchmarking provides a method to clear network predictor cache. The
predictor is migrating to a different service, so this method should
clear a different DB.

This CL also removes unsafe storing a Profile* on the IO thread. The
NetBenchmarking stores weak pointers to predictors instead.

Bug:  838949 ,  623967 
Change-Id: Ie73d57555237aea4ebb7be1a324151e5ea190b68
Reviewed-on: https://chromium-review.googlesource.com/1085450
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564846}
[modify] https://crrev.com/4909ec849b19c4a89caa4413e3e7cb9de9a8fab2/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/4909ec849b19c4a89caa4413e3e7cb9de9a8fab2/chrome/browser/net/predictor.h
[modify] https://crrev.com/4909ec849b19c4a89caa4413e3e7cb9de9a8fab2/chrome/browser/net_benchmarking.cc
[modify] https://crrev.com/4909ec849b19c4a89caa4413e3e7cb9de9a8fab2/chrome/browser/net_benchmarking.h
[modify] https://crrev.com/4909ec849b19c4a89caa4413e3e7cb9de9a8fab2/chrome/browser/predictors/resource_prefetch_predictor.cc
[modify] https://crrev.com/4909ec849b19c4a89caa4413e3e7cb9de9a8fab2/chrome/browser/predictors/resource_prefetch_predictor.h
[modify] https://crrev.com/4909ec849b19c4a89caa4413e3e7cb9de9a8fab2/chrome/browser/predictors/resource_prefetch_predictor_unittest.cc

Owner: alexilin@chromium.org
Status: Fixed (was: Untriaged)

Sign in to add a comment