New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 623961 link

Starred by 2 users
Status: Fixed
Owner:
█ owenlin@chromium.org
Last visit > 30 days ago
Closed: Jul 2016
Cc:
posciak@chromium.org
█ owenlin@chromium.org
rohi...@chromium.org
ihf@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Fix video_VideoDecodeMemoryUsage test on ARM

Project Member Reported by wuchengli@chromium.org, Jun 28 2016 
I don't think this test is very useful. This test is high level. The increase of memory of one single process does not mean there's memory leak. Does anyone look at chromeperf result or the numbers of this test in the past 12 months? If not, let's remove this test.

https://wmatrix.googleplex.com/unfiltered?hide_missing=True&releases=tot&tests=video_VideoDecodeMemoryUsage

If we want to test memory leak, we should use a lower level of memory usage test. For example, create and release VDA. Then check the system memory.

Comment 1 by wuchengli@chromium.org, Jul 5 2016

Summary: Fix video_VideoDecodeMemoryUsage test on ARM (was: Remove video_VideoDecodeMemoryUsage test)
I felt the test was still useful. But the test is failing on all ARM except exynos. We at least need to disable that failure.

# Paths of files to read graphics memory usage from
X86_GEM_OBJECTS_PATH = '/sys/kernel/debug/dri/0/i915_gem_objects'
ARM_GEM_OBJECTS_PATH = '/sys/kernel/debug/dri/0/exynos_gem_objects'

Comment 2 by wuchengli@chromium.org, Jul 5 2016

Owner: owenlin@chromium.org
Owen. Can you do that?

Comment 3 by owenlin@chromium.org, Jul 6 2016

Status: Started (was: Assigned)
Sure.

Comment 4 by wuchengli@chromium.org, Jul 19 2016 

Owen. Can you disable the failure for GEM objects? Thanks.
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/de6ca53c9650330e962e3dac1dffdac258bac83c

commit de6ca53c9650330e962e3dac1dffdac258bac83c
Author: Owen Lin <owenlin@google.com>
Date: Tue Jul 19 08:22:28 2016

video_VideoDecodeEmoryUsage: Fix get graphics memory on ARM.

The graphic buffer information is not available on most ARM devices
except exynos. Return 0 if the information is not available.

BUG= chromium:623961 
TEST=Run the test on veyron_minnie

Change-Id: I871c8ddfa7b776a855b3d53326d9af9ca27fbc92
Reviewed-on: https://chromium-review.googlesource.com/361650
Commit-Ready: Owen Lin <owenlin@chromium.org>
Tested-by: Owen Lin <owenlin@chromium.org>
Reviewed-by: Owen Lin <owenlin@chromium.org>

[modify] https://crrev.com/de6ca53c9650330e962e3dac1dffdac258bac83c/client/site_tests/video_VideoDecodeMemoryUsage/video_VideoDecodeMemoryUsage.py

Comment 6 by owenlin@chromium.org, Jul 22 2016

Status: Fixed (was: Started)
►

Sign in to add a comment