Focused state incorrectly disappears on chrome menu button
Reported by
jleedev@gmail.com,
Jun 28 2016
|
|||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2781.0 Safari/537.36 Steps to reproduce the problem: 1. Press the Alt key. (Focus ring appears on menu button) 2. Press the Space key. (Menu opens) 3. Press the Esc key. (Menu closes, but menu button still has focus) What is the expected behavior? Old (non-material): The focus ring remains on the menu button to indicate it still has focus. (Pressing Esc again restores focus to the web page.) What went wrong? New (material): The focus ring is not shaded even though it still has focus. Did this work before? Yes 51 stable without top-chrome MD Chrome version: 53.0.2781.0 Channel: canary OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version:
,
Jun 29 2016
Sending this to Evan to figure out how it interacts with the other button focus state stuff.
,
Jul 1 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 18 2016
Issue 629053 has been merged into this issue.
,
Jul 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/efad9e3a50b9ce33582780a860519e40539c3cef commit efad9e3a50b9ce33582780a860519e40539c3cef Author: estade <estade@chromium.org> Date: Tue Jul 26 17:46:48 2016 Restore focus-state ink drop highlight on buttons after ripple animation finishes. At first I just copied the way we restore highlight due to hover (i.e. I triggered StartHighlightAfterRippleTimer() based on ShouldHighlight(), not is_hovered_), but that looked sluggish and broken in comparison to just snapping back to the hover state. BUG= 626307 , 623957 Review-Url: https://codereview.chromium.org/2125223004 Cr-Commit-Position: refs/heads/master@{#407845} [modify] https://crrev.com/efad9e3a50b9ce33582780a860519e40539c3cef/ui/views/animation/ink_drop_impl.cc [modify] https://crrev.com/efad9e3a50b9ce33582780a860519e40539c3cef/ui/views/animation/ink_drop_impl.h [modify] https://crrev.com/efad9e3a50b9ce33582780a860519e40539c3cef/ui/views/animation/ink_drop_impl_unittest.cc
,
Jul 26 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ajha@chromium.org
, Jun 29 2016Labels: M-53 Proj-MaterialDesign-NativeUI
Status: Untriaged (was: Unconfirmed)