New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 623907 link

Starred by 2 users
Status: Fixed
Owner:
dpa...@chromium.org
Closed: Aug 2016
Cc:
nyerramilli@chromium.org
█ tkonch...@chromium.org
█ tsergeant@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression:Focus doesn't traverse to 'Add' button filed after pressing tab key in 'Add search engine' overlay.

Reported by vku...@etouch.net, Jun 28 2016 
Chrome Version:53.0.2782.0 Revision 4f1d832918c5966df3cc8ac1d23c8c1544262cee-refs/heads/master@{#402386}(32/64 bit) 
OS:Windows(7,8,10), Mac(10.10.5, 10.11.4), Linux(14.04 LTS).

What steps will reproduce the problem?
(1)Launch chrome and navigate to chrome://md-settings
(2)Click on iron icon and 'search engine' option,click on 'manage search engines'
(3)Click on 'Add search engine', input data in all search engine field.
(4)Press tab key such that focus reaches 'cancel' button again hit tab key and observe.

Actual: Focus doesn't traverse to Add button filed after pressing tab key.

Expected: Focus should traverse to Add button filed after pressing tab key.

This is a regression issue broken in 'M53' and will soon update other info

Comment 1 by vku...@etouch.net, Jun 28 2016

Labels: hasbisect
Owner: tsergeant@chromium.org
Status: Assigned (was: Unconfirmed)
Manual regression range:
Good build: 53.0.2748.0 
Bad build:  53.0.2749.0 

Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/17ab3580c8d3081a1c728eb33d6e5f35684fd5a5..3644e8c55d11a9b4693aa20001b116cdbca266e2?pretty=fuller&n=10

Suspecting: r395826
Kindly help to re-assign, if your changes are not cause for this issue.
Actual_search engine.mov
2.0 MB Download
Expected_search engine.mov
2.1 MB Download

Comment 2 by tkonch...@chromium.org, Jun 28 2016

Labels: Proj-MaterialDesign-WebUI

Comment 3 by tsergeant@chromium.org, Jun 28 2016

Cc: tsergeant@chromium.org
Owner: dpa...@chromium.org
Re-assigning to dpapad@ as the author of <settings-search-engine-dialog>

From a quick poke around the Polymer roll, it looks like the culprit is the changes to https://codereview.chromium.org/1984963002/diff/20001/third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/iron-overlay-behavior-extracted.js

This adds a focus trap to the <settings-dialog>, based on the elements that are focusable when it is opened. Since the action button is disabled at first, it gets excluded from the focus trap and is skipped over when tabbing.

Comment 4 by dpa...@chromium.org, Jun 29 2016 

Thanks for the initial investigation. It turns out there is already a bug filed about this, https://github.com/PolymerElements/iron-overlay-behavior/issues/184.
Project Member

Comment 5 by sheriffbot@chromium.org, Jul 2 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by tbuck...@chromium.org, Jul 22 2016

Labels: Hotlist-MD-Settings-SearchEngines
Status: ExternalDependency (was: Assigned)

Comment 7 by dpa...@chromium.org, Jul 22 2016 

FYI, this can also be fixed (or to be precise it will not be affecting Chrome), when  crbug.com/625332  is addressed (WIP).

Comment 8 by dpa...@chromium.org, Aug 1 2016

Status: Fixed (was: ExternalDependency)
I can no longer reproduce. Fixed as part of https://bugs.chromium.org/p/chromium/issues/detail?id=625332.

The underlying Polymer issue (https://github.com/PolymerElements/iron-overlay-behavior/issues/184) has not been addressed yet, but it no longer affects <cr-dialog>.
►

Sign in to add a comment