Issue metadata
Sign in to add a comment
|
Long press on empty area triggers text selection
Reported by
mahesh...@samsung.com,
Jun 28 2016
|
||||||||||||||||||
Issue descriptionSteps to reproduce the problem: 1. Load www.google.com 2. Long press on Google image -> Context menu is shown. 3. Select "Open Image in new tab" 4. Goto the tab in which the image is opened. 5. Long Press empty area below the image. What is the expected behavior? No text selection should happen What went wrong? SelectActionMode is shown and Text handles are shown Did this work before? Yes It worked well before https://codereview.chromium.org/1845193002/ was committed. Chrome version: 51.0.2704.103 Channel: dev OS Version: 6.0.1 Flash Version: Shockwave Flash 22.0 r0
,
Jun 28 2016
Although this is a regression, the scenario seems too unusual/useless to be worth prioritizing.
,
Jun 29 2016
mahesh.ma@ is working: http://crrev.com/2104883002
,
Jun 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e099723055362705266d6d4c70d4fdaa4c071c6 commit 6e099723055362705266d6d4c70d4fdaa4c071c6 Author: mahesh.ma <mahesh.ma@samsung.com> Date: Wed Jun 29 10:51:41 2016 Change text selection iterator behaviour for non-editable empty selection When the iterator that supports Image selection in editable fields is used in cases where there is empty selection, it still returns some non-empty character and hence makes a selection at empty areas too. Following commit: https://codereview.chromium.org/1845193002/ is causing this behaviour. So, in-order to maintain both use-cases, change iterator behavior to as it was previously for non-editable cases. BUG= 623906 Review-Url: https://codereview.chromium.org/2104883002 Cr-Commit-Position: refs/heads/master@{#402771} [modify] https://crrev.com/6e099723055362705266d6d4c70d4fdaa4c071c6/AUTHORS [modify] https://crrev.com/6e099723055362705266d6d4c70d4fdaa4c071c6/third_party/WebKit/Source/core/editing/SelectionController.cpp [modify] https://crrev.com/6e099723055362705266d6d4c70d4fdaa4c071c6/third_party/WebKit/Source/web/tests/WebViewTest.cpp
,
Aug 18 2017
|
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by rsgav...@chromium.org
, Jun 28 2016Status: Assigned (was: Unconfirmed)