New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 623903 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Regression

Blocking:
issue 589681



Sign in to add a comment

Regression: Weird behavior is seen on chrome://md-settings page after clicking on back/forward navigation button.

Reported by rk...@etouch.net, Jun 28 2016

Issue description

Chrome Version: 53.0.2782.0 Revision 4f1d832918c5966df3cc8ac1d23c8c1544262cee-refs/heads/master@{#402386}(32/64 bit)
OS: Windows(7,8,10), Mac(10.11.4,10.10.5),Linux (14.04 LTS)

What steps will reproduce the problem?
(1) Launch chrome, navigate to chrome://md-settings page.
(2) Click on 'Manage search engine', then click on iron icon near to the Settings text(settings overlay opened).
(3) Click on back and forward navigation button near to the omnibox and observe. 

Weird behavior is seen after clicking on back and forward navigation button.

No such behavior should seen after clicking on back and forward navigation button.

This is a regression issue, broken in 'M-53', below is manual bisect and narrow bisect:

Good Build : 53.0.2770.0
Bad Build : 53.0.2772.0

Narrow Bisect info:
https://chromium.googlesource.com/chromium/src/+log/cb1d6bdee0b6971ae77243cf78668e3973265a7a..be655fd4fb9ab3291a855a939496111674037a2f?pretty=fuller&n=100

Suspecting: r400554
 
Actual_Video.mp4
837 KB View Download
Expected_Video.mp4
489 KB View Download
Labels: Proj-MaterialDesign-WebUI
Cc: michae...@chromium.org
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 2 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Started (was: Assigned)
dschuyler: this is probably the same root cause as  issue #626612  which you just assigned to me. are you actively working on this?
Blocking: 589681
Labels: Hotlist-MD-Settings-Navigation
@michaelpg, It looks like a different cause to me.
For this bug, the drawer should close. For 626612 the drawer should stay open.
I don't see them as the same issue and don't expect them to have the same solution.
Labels: -OS-Linux -OS-Windows -OS-Mac OS-All
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2e8191e41dae27a051bc54271fbd971db1bfafd

commit f2e8191e41dae27a051bc54271fbd971db1bfafd
Author: dschuyler <dschuyler@chromium.org>
Date: Fri Jul 22 22:55:16 2016

[MD settings] close the side nav when navigating back/forward

This CL solves a problem with the side nav menu drawer staying open when
using the back/forward buttons. The drawer now closes when navigating
forward or back.

BUG= 623903 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2170223002
Cr-Commit-Position: refs/heads/master@{#407290}

[modify] https://crrev.com/f2e8191e41dae27a051bc54271fbd971db1bfafd/chrome/browser/resources/settings/settings_ui/settings_ui.js

Status: Fixed (was: Started)

Sign in to add a comment