New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 623900 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug-Regression

Blocked on:
issue 647439



Sign in to add a comment

Please show TCP Port if not default in Dev Tools

Reported by jeromin....@gmail.com, Jun 28 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2774.3 Safari/537.36

Steps to reproduce the problem:
There are two areas where showing the TCP Port would be nice. They are shown only in mouse tool tip.

Network Tab:
While initializing a Websocket the Name column shows the Host/IP. 
If the Port is not 80 it would be nice if the Port is added.

Application Tab:
Entry "Top" could get the Host/IP (+Port if not default)

What is the expected behavior?

What went wrong?
Screenshot with annotation is added.

Did this work before? N/A 

Chrome version: 53.0.2774.3  Channel: dev
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: Shockwave Flash 22.0 r0
 
describing screenshots.png
56.6 KB View Download
Cc: allada@chromium.org
Status: WontFix (was: Unconfirmed)
Network tab.
You can use "remote address" column to help differentiate. (see screenshot)
I'm not clear why the IP is also the "name" of your websockets, as that is extracted through the URL.path typically.  But that name is somewhat in your control.. I think you can just use a /endpoint/url/ rather than connecting to the root of the origin?

Application tab.
We are grouping by frames there, not by origin, so we will be putting all origins together. Sources is where the files are split by origin.


Closing this for now, but let me know if the network panel url situation is different than I understand it.
Screen Shot 2016-07-01 at 2.13.59 PM.png
156 KB View Download
My HTTP and WS Connection is to the IP (no hostname involved), so no problem there. 

Thanks for your suggestion, but "remote address" is empty for websocket connections. No column has useful information for me. 8-/

My endpoints are two servers with the same API. 
I am unsure if changing the path has breaking changes. 
describing screenshots2.png
13.7 KB View Download
I just tested manipulating the path. The result of URL.path is quite surprising.
Should i open another issue for that? I can fake anything in this...
describing screenshots3.png
16.5 KB View Download
Can someone reopen this issue? The suggested fix did not worked as my screenshots shows.
Cc: -allada@chromium.org
Labels: -Type-Bug -Pri-2 Pri-1 Type-Bug-Regression
Owner: allada@chromium.org
Status: Assigned (was: WontFix)
Confirmed, This was caused from a regression caused from some refactoring to allow custom columns in network here: https://codereview.chromium.org/2150713002/

I have identified the problem and a patch should hit canary soon.

Thanks for this info!
Thanks for looking into it!
I can't understand how a refactoring in August 19 can produce a bug at June 28. But I am happy when the problem is solved :-)
#6 Regardless, the changes I did would have broke it anyway.
Labels: M-54
Components: Platform>DevTools>Network
Labels: Merge-Request-54

Comment 12 by dimu@chromium.org, Sep 14 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Is the fix in chrome canary d19c087b9bfdf76a8af91e2f0a0e791bf2ffcafa-refs/heads/master@{#418438}?
"Remote" column is still empty for websockets and "name" has not changed.
chrome623900_canary.png
12.0 KB View Download
Labels: -OS-Windows -Pri-1 OS-All Pri-2
#13 I have confirmed that this did not fix it for websockets. Websockets use different protocol messages to alert devtools of requests and websockets protocol commands do not have ip address information which means I need to pipe the info into devtools first which requires a bit more approvals for the CL. I'll put it in my queue, but it is not a high priority at this point.

Thanks!
Labels: -Merge-Approved-54 Merge-Rejected-54
Please request a merge when its ready to go.
Blockedon: 647439
Project Member

Comment 17 by bugdroid1@chromium.org, Sep 17 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c34ab544231d1c5e6e0eb438f3d8a34e587b9fa

commit 2c34ab544231d1c5e6e0eb438f3d8a34e587b9fa
Author: allada <allada@chromium.org>
Date: Sat Sep 17 01:11:20 2016

[Devtools] Fixed not showing remoteaddress in network log

Fixed bug where network log view was not showing certain
columns (like remoteaddress).

R=lushnikov
BUG= 623900 
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2330613002
Cr-Commit-Position: refs/heads/master@{#418141}
(cherry picked from commit a5326e37b41001c675d27d0c160daedcbc1b1d97)

Review-Url: https://codereview.chromium.org/2349023003
Cr-Commit-Position: refs/branch-heads/2840@{#402}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[add] https://crrev.com/2c34ab544231d1c5e6e0eb438f3d8a34e587b9fa/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-visible-expected.txt
[add] https://crrev.com/2c34ab544231d1c5e6e0eb438f3d8a34e587b9fa/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-visible.html
[modify] https://crrev.com/2c34ab544231d1c5e6e0eb438f3d8a34e587b9fa/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

Project Member

Comment 18 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c34ab544231d1c5e6e0eb438f3d8a34e587b9fa

commit 2c34ab544231d1c5e6e0eb438f3d8a34e587b9fa
Author: allada <allada@chromium.org>
Date: Sat Sep 17 01:11:20 2016

[Devtools] Fixed not showing remoteaddress in network log

Fixed bug where network log view was not showing certain
columns (like remoteaddress).

R=lushnikov
BUG= 623900 
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2330613002
Cr-Commit-Position: refs/heads/master@{#418141}
(cherry picked from commit a5326e37b41001c675d27d0c160daedcbc1b1d97)

Review-Url: https://codereview.chromium.org/2349023003
Cr-Commit-Position: refs/branch-heads/2840@{#402}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[add] https://crrev.com/2c34ab544231d1c5e6e0eb438f3d8a34e587b9fa/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-visible-expected.txt
[add] https://crrev.com/2c34ab544231d1c5e6e0eb438f3d8a34e587b9fa/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-visible.html
[modify] https://crrev.com/2c34ab544231d1c5e6e0eb438f3d8a34e587b9fa/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

Labels: Hotlist-Polish
Status: Fixed (was: Assigned)
Did you closed the bug intentionally? 
In my beta chrome Version 62.0.3188.4 (Official Build) dev (64-Bit)
the port is still not shown as you can see on my newest screenshot.

But the initiator column shows useful information which did not one year ago :)
chromebug623900.png
10.4 KB View Download

Sign in to add a comment