Issue metadata
Sign in to add a comment
|
Please show TCP Port if not default in Dev Tools
Reported by
jeromin....@gmail.com,
Jun 28 2016
|
||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2774.3 Safari/537.36 Steps to reproduce the problem: There are two areas where showing the TCP Port would be nice. They are shown only in mouse tool tip. Network Tab: While initializing a Websocket the Name column shows the Host/IP. If the Port is not 80 it would be nice if the Port is added. Application Tab: Entry "Top" could get the Host/IP (+Port if not default) What is the expected behavior? What went wrong? Screenshot with annotation is added. Did this work before? N/A Chrome version: 53.0.2774.3 Channel: dev OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version: Shockwave Flash 22.0 r0
,
Jul 5 2016
My HTTP and WS Connection is to the IP (no hostname involved), so no problem there. Thanks for your suggestion, but "remote address" is empty for websocket connections. No column has useful information for me. 8-/ My endpoints are two servers with the same API. I am unsure if changing the path has breaking changes.
,
Jul 5 2016
I just tested manipulating the path. The result of URL.path is quite surprising. Should i open another issue for that? I can fake anything in this...
,
Sep 9 2016
Can someone reopen this issue? The suggested fix did not worked as my screenshots shows.
,
Sep 9 2016
Confirmed, This was caused from a regression caused from some refactoring to allow custom columns in network here: https://codereview.chromium.org/2150713002/ I have identified the problem and a patch should hit canary soon. Thanks for this info!
,
Sep 9 2016
Thanks for looking into it! I can't understand how a refactoring in August 19 can produce a bug at June 28. But I am happy when the problem is solved :-)
,
Sep 9 2016
#6 Regardless, the changes I did would have broke it anyway.
,
Sep 9 2016
,
Sep 9 2016
,
Sep 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a5326e37b41001c675d27d0c160daedcbc1b1d97 commit a5326e37b41001c675d27d0c160daedcbc1b1d97 Author: allada <allada@chromium.org> Date: Tue Sep 13 02:10:14 2016 [Devtools] Fixed not showing remoteaddress in network log Fixed bug where network log view was not showing certain columns (like remoteaddress). R=lushnikov BUG= 623900 Review-Url: https://codereview.chromium.org/2330613002 Cr-Commit-Position: refs/heads/master@{#418141} [add] https://crrev.com/a5326e37b41001c675d27d0c160daedcbc1b1d97/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-visible-expected.txt [add] https://crrev.com/a5326e37b41001c675d27d0c160daedcbc1b1d97/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-visible.html [modify] https://crrev.com/a5326e37b41001c675d27d0c160daedcbc1b1d97/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
,
Sep 13 2016
,
Sep 14 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 15 2016
Is the fix in chrome canary d19c087b9bfdf76a8af91e2f0a0e791bf2ffcafa-refs/heads/master@{#418438}? "Remote" column is still empty for websockets and "name" has not changed.
,
Sep 15 2016
#13 I have confirmed that this did not fix it for websockets. Websockets use different protocol messages to alert devtools of requests and websockets protocol commands do not have ip address information which means I need to pipe the info into devtools first which requires a bit more approvals for the CL. I'll put it in my queue, but it is not a high priority at this point. Thanks!
,
Sep 15 2016
Please request a merge when its ready to go.
,
Sep 15 2016
,
Sep 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c34ab544231d1c5e6e0eb438f3d8a34e587b9fa commit 2c34ab544231d1c5e6e0eb438f3d8a34e587b9fa Author: allada <allada@chromium.org> Date: Sat Sep 17 01:11:20 2016 [Devtools] Fixed not showing remoteaddress in network log Fixed bug where network log view was not showing certain columns (like remoteaddress). R=lushnikov BUG= 623900 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2330613002 Cr-Commit-Position: refs/heads/master@{#418141} (cherry picked from commit a5326e37b41001c675d27d0c160daedcbc1b1d97) Review-Url: https://codereview.chromium.org/2349023003 Cr-Commit-Position: refs/branch-heads/2840@{#402} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [add] https://crrev.com/2c34ab544231d1c5e6e0eb438f3d8a34e587b9fa/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-visible-expected.txt [add] https://crrev.com/2c34ab544231d1c5e6e0eb438f3d8a34e587b9fa/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-visible.html [modify] https://crrev.com/2c34ab544231d1c5e6e0eb438f3d8a34e587b9fa/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c34ab544231d1c5e6e0eb438f3d8a34e587b9fa commit 2c34ab544231d1c5e6e0eb438f3d8a34e587b9fa Author: allada <allada@chromium.org> Date: Sat Sep 17 01:11:20 2016 [Devtools] Fixed not showing remoteaddress in network log Fixed bug where network log view was not showing certain columns (like remoteaddress). R=lushnikov BUG= 623900 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2330613002 Cr-Commit-Position: refs/heads/master@{#418141} (cherry picked from commit a5326e37b41001c675d27d0c160daedcbc1b1d97) Review-Url: https://codereview.chromium.org/2349023003 Cr-Commit-Position: refs/branch-heads/2840@{#402} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [add] https://crrev.com/2c34ab544231d1c5e6e0eb438f3d8a34e587b9fa/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-visible-expected.txt [add] https://crrev.com/2c34ab544231d1c5e6e0eb438f3d8a34e587b9fa/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-visible.html [modify] https://crrev.com/2c34ab544231d1c5e6e0eb438f3d8a34e587b9fa/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
,
Dec 2 2016
,
Jul 19 2017
,
Aug 22 2017
Did you closed the bug intentionally? In my beta chrome Version 62.0.3188.4 (Official Build) dev (64-Bit) the port is still not shown as you can see on my newest screenshot. But the initiator column shows useful information which did not one year ago :) |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by paulir...@chromium.org
, Jul 1 2016Status: WontFix (was: Unconfirmed)
156 KB
156 KB View Download