New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 623885 link

Starred by 1 user
Status: Fixed
Owner:
peconn@chromium.org
Closed: Jul 2016
Cc:
█ rachelis@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Toolbar buttons don't move in when unfocusing omnibox

Project Member Reported by bauerb@chromium.org, Jun 28 2016 
When focusing the omnibox, the toolbar buttons (tab switcher / overflow menu button) move away to the side as the omnibox expands. When the omnibox is unfocused though, they suddenly appear again without an animation.

Comment 1 by nepper@chromium.org, Jun 28 2016

Labels: -Pri-3 zine-ntp-pe M-54 Pri-2
Status: Available (was: Untriaged)
Got it. I just verified in Stable 51.0.2703.81 that his is happening.

So, I assume the intended spec is for the toolbar buttons to show up with the "reverse" animation of when they move away.

Marking it as a candidate for our PE Fixit.

Comment 2 by bauerb@chromium.org, Jul 1 2016

Labels: Hotlist-Fixit-PE2016

Comment 3 by peconn@chromium.org, Jul 1 2016

Owner: peconn@chromium.org

Comment 4 by peconn@chromium.org, Jul 6 2016 

Before and after videos for https://codereview.chromium.org/2121283002/ .
623885-before.mp4
4.9 MB View Download
623885-after.mp4
6.4 MB View Download
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56e3c638ef1575429a2ecd5a19ddd069ba42892b

commit 56e3c638ef1575429a2ecd5a19ddd069ba42892b
Author: peconn <peconn@chromium.org>
Date: Thu Jul 07 09:25:29 2016

Reset translation of toolbar_buttons for Url Defocus Animation.

The mToolbarButtonsContainer has its translationY modified during scroll so
when the user scrolls on the NTP, it appears to scroll too. However during
the URL focus and defocus animations it should not be touched. Unfortunately
updateNtpTransitionAnimation() is called a few times after the URL focus
animation has been completed while mUrlFocusChangeInProgress is set to false,
causing translationY to be non-zero at the end.  We reset the translationY
here so the mToolbarButtonsContainer is on screen for the defocusing animation.

BUG= 623885 

Review-Url: https://codereview.chromium.org/2121283002
Cr-Commit-Position: refs/heads/master@{#404113}

[modify] https://crrev.com/56e3c638ef1575429a2ecd5a19ddd069ba42892b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java

Comment 6 by peconn@chromium.org, Jul 7 2016

Status: Fixed (was: Available)

Comment 7 by rachelis@chromium.org, Jul 7 2016 

Thanks Pete! LGTM.
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a53cd10e4514d39102713e77bd9fa56ed2c9d15b

commit a53cd10e4514d39102713e77bd9fa56ed2c9d15b
Author: peconn <peconn@chromium.org>
Date: Fri Jul 08 16:44:02 2016

Set translation of toolbar buttons on Url Animations.

This is a refinement of https://codereview.chromium.org/2121283002/ , which behaves correctly when url focus animations occur when the new tab page is partially scrolled.

BUG= 623885 

Review-Url: https://codereview.chromium.org/2132043002
Cr-Commit-Position: refs/heads/master@{#404409}

[modify] https://crrev.com/a53cd10e4514d39102713e77bd9fa56ed2c9d15b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java
►

Sign in to add a comment