New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 623864 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression:Warning message for wrong passphrase hides behind submit button.

Reported by vku...@etouch.net, Jun 28 2016

Issue description

Chrome Version: 53.0.2781.0 (Official Build) d855b4a44ca015cc874b69b828717bb4293c3092-refs/heads/master@{#402177} (32/64-bit)
OS:Windows(7,8,10), Mac(10.10.5, 10.11.4), Linux(14.04 LTS).

Precondition: Login into browser with credentials which requires passphrase.

What steps will reproduce the problem?
(1)Launch chrome and click on 'update sync..' from wrench menu.
(2)Under encryption option input wrong passphrase and click on 'submit' button 
(3)Observe the warning message.

Actual: Warning message for wrong passphrase hides behind submit button.

Expected: Warning message for wrong passphrase should be properly visible after step 2.

This is a regression issue broken in 'M53' and will soon update other info


 

Comment 1 by vku...@etouch.net, Jun 28 2016

Labels: hasbisect
Owner: dschuyler@chromium.org
Status: Assigned (was: Unconfirmed)
Manual regression range:
Good build:  52.0.2735.0
Bad build:   52.0.2737.0

CL:
https://chromium.googlesource.com/chromium/src/+log/52.0.2735.0..52.0.2737.0?pretty=fuller&n=10000
(Unable to narrow down the range via tool since not able to sign in into chromium builds)

Suspecting: 393623 ?
Kindly help to re-assign, if your changes are not cause for this issue.
Actual_Pass.mov
846 KB Download
Expected_Pass.mov
1.2 MB Download
Labels: Proj-MaterialDesign-WebUI
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 2 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: tommycli@chromium.org
Labels: Hotlist-MD-Settings-People
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00f9c87065284d73bea9b86861f03fc4ca2aad59

commit 00f9c87065284d73bea9b86861f03fc4ca2aad59
Author: tommycli <tommycli@chromium.org>
Date: Thu Aug 18 16:38:48 2016

Settings People Revamp: Fix Submit passphrase button placement.

BUG= 623864 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2248973004
Cr-Commit-Position: refs/heads/master@{#412853}

[modify] https://crrev.com/00f9c87065284d73bea9b86861f03fc4ca2aad59/chrome/browser/resources/settings/people_page/sync_page.html

Status: Fixed (was: Assigned)

Sign in to add a comment