New issue
Advanced search Search tips

Issue 623860 link

Starred by 2 users
Status: Untriaged
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

Remov noisy 'cacheinfo' error boot message

Reported by gs0...@gmail.com, Jun 28 2016 
UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/50.0.2661.102 Chrome/50.0.2661.102 Safari/537.36
Platform: 8396.0.2016_06_01_1315 (Test Build - harrypan) developer-build chell

Steps to reproduce the problem:
1. boot device w/ 3.18 kernel
2. enter root shell, issue command: dmesg | grep -i cacheinfo
3. locate the kernel err msg of "error detecting cacheinfo..cpu0"

What is the expected behavior?

What went wrong?
Grabbed from upstream commit message:

On systems that don't support cacheinfo, this error message can be considered noisy and irrelevant. The error messages can be added to the functions that architectures implement overiding the weak default definition if really required.

Did this work before? N/A 

Chrome version: 50.0.2661.102  Channel: n/a
OS Version: chromeos_v3.18
Flash Version: N/A

cherry-pick upstream commit of 6df43c9b4d87

Comment 1 by gs0...@gmail.com, Jun 28 2016 

Considering current boot dmesg, down below false alarm of kernel error shall be refined:

localhost ~ # dmesg | grep "cpu0"                                                                                                                    
[    0.595762] Failed to find cpu0 device node
[    0.595766] error detecting cacheinfo..cpu0   <- this is annoying false alarm labeled as kernel error.

Considering upstream fix, it is better to be replaced as kernel warning, for fair reason in teams of DT system (Device Tree and Open Firmware support).

i.e.
localhost ~ # dmesg | grep "cpu0\|cache hierarchy"                                                                                                   
[    0.464110] Failed to find cpu0 device node
[    0.464112] Unable to detect cache hierarchy from DT for CPU 0

As this reason, consider to cherry-pick three upstream commits:
2539b258ec02 2015-05-24 Will Deacon drivers/base: cacheinfo: fix annoying typo when DT nodes are absent
8a7d95f95c95 2015-03-25 Sudeep Holla drivers/base: cacheinfo: validate device node for all the caches
6df43c9b4d87 2014-11-24 Sudeep Holla drivers/base: cacheinfo: remove noisy error boot message


That being said, not really a bug, but replace kernel error message as warning one.
https://chromium-review.googlesource.com/#/q/topic:refine_cacheinfo

Comment 2 by dchan@google.com, Sep 3 2016

Components: OS>Kernel
Labels: -Type-Bug Type-Feature

Comment 3 by dchan@google.com, Sep 3 2016

Status: Untriaged (was: Unconfirmed)

Comment 4 by keta...@chromium.org, Feb 17 2017

Status: Archived (was: Untriaged)

Comment 5 by ketakid@google.com, Mar 18 2017

Labels: Pri-3
Status: Available (was: Archived)
Activating. Please assign to the right owner and the appropriate priority.
Project Member

Comment 6 by sheriffbot@chromium.org, Apr 12 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
►

Sign in to add a comment