New issue
Advanced search Search tips

Issue 623848 link

Starred by 1 user
Status: Fixed
Owner:
dominickn@chromium.org
Closed: Jul 2016
Cc:
calamity@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Site engagement doesn't listen for user input if non-main frame resources are loaded after the main frame

Project Member Reported by dominickn@chromium.org, Jun 28 2016 
We need to stop input listening after we check for main frame-ness in DidFinishNavigation.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d014c1cfad770f6516556d5358f10f18e162096e

commit d014c1cfad770f6516556d5358f10f18e162096e
Author: dominickn <dominickn@chromium.org>
Date: Wed Jun 29 08:22:15 2016

Fix a bug in user input detection for the site engagement service.

Sites which lazy-load resources after navigating to the main frame do
not trigger site engagement for user input. This CL fixes the bug by
reordering when the input listening callbacks are stopped.

BUG= 623848 

Review-Url: https://codereview.chromium.org/2104813002
Cr-Commit-Position: refs/heads/master@{#402753}

[modify] https://crrev.com/d014c1cfad770f6516556d5358f10f18e162096e/chrome/browser/engagement/site_engagement_helper.cc

Comment 2 by dominickn@chromium.org, Jul 17 2016

Status: Fixed (was: Started)

Comment 3 by lafo...@chromium.org, Dec 9 2016

Components: -Security>UX
Labels: Team-Security-UX
Security>UX component is deprecated in favor of the Team-Security-UX label
►

Sign in to add a comment