Issue metadata
Sign in to add a comment
|
11.9% regression in tab_switching.tough_energy_cases at 401454:401483 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jun 28 2016
,
Jun 28 2016
=== Auto-CCing suspected CL author alokp@chromium.org === Hi alokp@chromium.org, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Avoid flooding main thread by caching state on media thread. Author : alokp Commit description: OnStatisticsUpdate and OnBufferedTimeRangesChanged fire much more frequently than queried for. Posting all state change notifications to the main thread causes potential performance issues. Cache state not immediately required by PipelineClient on the media thread to avoid having to post all state change notifications. BUG= 619975 Review-Url: https://codereview.chromium.org/2071503003 Cr-Commit-Position: refs/heads/master@{#401457} Commit : 8f268bb64214eab73f00216b96b919a1b2955999 Date : Wed Jun 22 23:30:09 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@401453 1025.2 24.4683 5 good chromium@401455 1007.8 22.1066 5 good chromium@401456 997.2 31.3879 5 good chromium@401457 1124.6 7.4027 5 bad <-- chromium@401461 1113.4 25.9673 5 bad chromium@401468 1151.6 104.77 5 bad chromium@401483 1101.4 31.1737 5 bad Bisect job ran on: mac_hdd_perf_bisect Bug ID: 623839 Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests tab_switching.tough_energy_cases Test Metric: idle_wakeups_total/idle_wakeups_total Relative Change: 7.43% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_hdd_perf_bisect/builds/613 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9008647844602382960 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5289520463872000 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Jun 28 2016
r399376 improved tab_switching.tough_energy_cases (938.2 vs 1095.7) but regressed media.tough_video_cases_extra as documented in bug 619975 . r401457 partially reverted r399376 to fix the regression in media.tough_video_cases_extra benchmark. But also restored the numbers for tab_switching.tough_energy_cases back to 1124.6. Since this is not a regression from m52, marking as WontFix. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by lanwei@google.com
, Jun 28 2016