New issue
Advanced search Search tips

Issue 623831 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jul 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

2.5% regression in page_cycler.tough_layout_cases at 401977:401994

Project Member Reported by lanwei@google.com, Jun 28 2016

Issue description

See the link to graphs below.
 

Comment 1 by lanwei@google.com, Jun 28 2016

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=623831

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgopvQrgoM


Bot(s) for this bug's original alert(s):

chromium-rel-mac-retina
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Jun 28 2016

Cc: creis@chromium.org
Owner: creis@chromium.org

=== Auto-CCing suspected CL author creis@chromium.org ===

Hi creis@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Revert of Enable subframe FrameNavigationEntries by default. (patchset #4 id:60001 of https://codereview.chromium.org/1952533003/ )
Author  : creis
Commit description:
  
Reason for revert:
Caused several layout tests to fail:
https://build.chromium.org/p/chromium.webkit/buildstatus?builder=WebKit%20Mac10.11&number=6083

  fast/history/same-document-iframes-changing-fragment.html [ Failure ]
  fast/history/same-document-iframes-changing-pushstate.html [ Failure ]
  fast/loader/form-state-restore-with-frames.html [ Failure ]
  http/tests/misc/resource-timing-iframe-restored-from-history.html [ Failure ]
  http/tests/navigation/back-to-dynamic-iframe.html [ Failure ]
  http/tests/navigation/back-to-redirect-with-frame.php [ Failure ]
  http/tests/security/mixedContent/insecure-iframe-in-main-frame.html [ Failure ]

Original issue's description:
> Enable subframe FrameNavigationEntries by default.
>
> This is a major change to the navigation logic in Chrome, making
> the browser process responsible for selecting subframes to
> navigate.  Each NavigationEntry now has a tree of
> FrameNavigationEntries representing each frame in the page, and
> these frame entries track per-frame PageState.
>
> HistoryController in content/renderer is no longer used, since
> equivalent code in NavigationController in content/browser now
> determines which frames to navigate.
>
> This CL is designed to be easy to revert if regressions are
> found, though the new path has been in use on 50% of Canary and
> Dev channels for a while.
>
> BUG= 236848 
> TEST=Existing tests pass.
>
> Committed: https://crrev.com/810a396cc50315037a51e55342da6c04d1c9b260
> Cr-Commit-Position: refs/heads/master@{#401969}

TBR=boliu@chromium.org,nick@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 236848 

Review-Url: https://codereview.chromium.org/2092283002
Cr-Commit-Position: refs/heads/master@{#401985}
Commit  : 5e66abf8057e5e904c9539ee8aa2fe92161d208f
Date    : Fri Jun 24 21:54:28 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@401976  2191.8   11.974   5  good
chromium@401981  2204.09  9.55776  8  good
chromium@401983  2208.2   8.88241  8  good
chromium@401984  2205.69  6.75099  5  good
chromium@401985  2223.55  11.1633  8  bad    <--
chromium@401994  2222.62  8.6466   5  bad

Bisect job ran on: mac_retina_perf_bisect
Bug ID: 623831

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests page_cycler.tough_layout_cases
Test Metric: cold_times/page_load_time
Relative Change: 1.41%
Score: 99.0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_bisect/builds/1368
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9008648258876309840


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5863844430217216

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 28 2016

Labels: Hotlist-Google

Comment 4 by creis@chromium.org, Jun 28 2016

Owner: ----
Status: Untriaged (was: Assigned)
This CL almost certainly couldn't have caused the regression.  It reverted a CL that landed only hours before, so it just put us back where we were earlier in the day.

Can someone take a look to run a new bisect?
Project Member

Comment 5 by sheriffbot@chromium.org, Jul 2 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: -creis@chromium.org
Status: WontFix (was: Untriaged)
This has recovered.

Sign in to add a comment