New issue
Advanced search Search tips

Issue 623808 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 623174
Owner:
Closed: Jun 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

12.8%-39.3% regression in memory.long_running_idle_gmail_background_tbmv2 at 401776:401805

Project Member Reported by lanwei@google.com, Jun 28 2016

Issue description

See the link to graphs below.
 
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Jun 28 2016

Mergedinto: 623174
Status: Duplicate (was: Assigned)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Turn on enable begin frame scheduling by default
Author  : enne
Commit description:
  
This turns on --enable-begin-frame-scheduling[1] for all[2] platforms.
This was already on for Android so should only be a real change
for desktop / ChromeOS platforms.

Lots of cleanup can follow from this like removing all commit vsync /
authoritative vsync / CompositorVSyncManager things, but this is a
smaller patch to suss out any performance regressions.

[1] In this case, "begin frame scheduling" means browser->renderer
begin frame ticks instead of sending vsync information and having
a synthetic source on the renderer side.

[2] MUS is not hooked up to begin frame scheduling yet, but
mojo:mash_session in an "oxygen" build still works with this patch
applied.  Blimp also doesn't use begin frame scheduling and will
eventually just be transitioned to a synthetic begin frame source
for its engine half.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/1939253002
Cr-Commit-Position: refs/heads/master@{#401796}
Commit  : f2d7f5e1891703ec4384ededd80f896816921204
Date    : Fri Jun 24 02:43:08 2016


===== TESTED REVISIONS =====
Revision         Mean       Std Dev  N  Good?
chromium@401788  85357703   2493933  5  good
chromium@401793  85776785   2314063  5  good
chromium@401795  89493262   7828639  5  good
chromium@401796  109788693  6871548  5  bad    <--
chromium@401797  114232458  4565316  5  bad

Bisect job ran on: mac_hdd_perf_bisect
Bug ID: 623808

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests memory.long_running_idle_gmail_background_tbmv2
Test Metric: memory:chrome:renderer_processes:reported_by_chrome:v8:allocated_objects_size_avg/memory:chrome:renderer_processes:reported_by_chrome:v8:allocated_objects_size_avg
Relative Change: 33.83%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_hdd_perf_bisect/builds/612
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9008649868152735968


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5885387046649856

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Sign in to add a comment