inspector/elements/elements-panel-correct-case.html is flaky |
||
Issue description
Looking at the output, sometimes one of the expected newline characters is missing:
- \nfunction test()\n{\n InspectorTest.expandElementsTree(step1);\n\n function step1()\n {\n InspectorTest.dumpElementsTree();\n InspectorTest.completeTest();\n }\n}\n
+ function test()\n{\n InspectorTest.expandElementsTree(step1);\n\n function step1()\n {\n InspectorTest.dumpElementsTree();\n InspectorTest.completeTest();\n }\n}\n
I'll mark it flaky in TestExpectations but it would be good to find and fix the root cause.
,
Sep 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3eda8caca348d8c2c2f72d28af48e0757f83d1f2 commit 3eda8caca348d8c2c2f72d28af48e0757f83d1f2 Author: einbinder <einbinder@chromium.org> Date: Wed Sep 07 21:43:01 2016 DevTools: Remove leading newline on scripts immediately The elements panel was waiting for DOMSyntaxHighligher to strip the leading newline from script tags, which made testing flaky. BUG= 623802 Review-Url: https://codereview.chromium.org/2300633005 Cr-Commit-Position: refs/heads/master@{#417052} [modify] https://crrev.com/3eda8caca348d8c2c2f72d28af48e0757f83d1f2/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/3eda8caca348d8c2c2f72d28af48e0757f83d1f2/third_party/WebKit/LayoutTests/inspector/elements/elements-panel-correct-case-expected.txt [modify] https://crrev.com/3eda8caca348d8c2c2f72d28af48e0757f83d1f2/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js [modify] https://crrev.com/3eda8caca348d8c2c2f72d28af48e0757f83d1f2/third_party/WebKit/Source/devtools/front_end/ui/DOMSyntaxHighlighter.js
,
Oct 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e06cd4e4cbe2ca9e13936da2e3d1df5338aeeb18 commit e06cd4e4cbe2ca9e13936da2e3d1df5338aeeb18 Author: einbinder <einbinder@chromium.org> Date: Mon Oct 03 22:52:56 2016 DevTools: Remove unnecessary [ Pass ] from TestExpectations inspector/elements/elements-panel-correct-case.html is no longer flaky BUG= 623802 Review-Url: https://codereview.chromium.org/2386993003 Cr-Commit-Position: refs/heads/master@{#422579} [modify] https://crrev.com/e06cd4e4cbe2ca9e13936da2e3d1df5338aeeb18/third_party/WebKit/LayoutTests/TestExpectations
,
Oct 31
Bulk closing low-priority issues with no activity. Please re-file and refer to the closed issue if it's essential to fix. |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jun 28 2016