New issue
Advanced search Search tips

Issue 623801 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue 623804
Owner:
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

5.4%-533.8% regression in smoothness.top_25_smooth at 401961:402005

Project Member Reported by lanwei@google.com, Jun 28 2016

Issue description

See the link to graphs below.
 

Comment 1 by lanwei@google.com, Jun 28 2016

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=623801

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgormnvwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgwriqiQgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgosbStwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgop3eogoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgorn9rgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgosuXoAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgormOpgkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgwq2epQkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgosakpgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgormOpgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgosLdvQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgosKprAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgwu28sgkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgosuXoAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgwt-JqwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgooiC4AgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgooa_uwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgormSuwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgotSctAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgoqGougoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgwremuwsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgop2gtQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgoqibsAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgorrNpwkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgws_ZoAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgosLipAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgwpvKswkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgwpuTpgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgwpuFuwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgotm1vQoM


Bot(s) for this bug's original alert(s):

chromium-rel-mac-retina
chromium-rel-mac10
chromium-rel-win10
chromium-rel-win7-x64-dual
chromium-rel-win8-dual
Project Member

Comment 2 by sheriffbot@chromium.org, Jun 28 2016

Labels: Hotlist-Google
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 2 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Lan, can you follow up on this?

From the instructions (https://chromium.googlesource.com/chromium/src/+/master/tools/perf/docs/perf_regression_sheriffing.md):
"After your shift, please try to follow up on the bugs you filed weekly. Kick off new bisects if the previous ones failed, and if the bisect picks a likely culprit follow up to ensure the CL author addresses the problem. If you are certain that a specific CL caused a performance regression, and the author does not have an immediate plan to address the problem, please revert the CL."
This shows a clear land-revert-reland pattern... but there's no CLs that do that in the range. I submitted bisects on each of the down/up/down, so we'll have to pay special attention to what comes back to understand this.
Cc: lanwei@chromium.org
 Issue 623800  has been merged into this issue.
Cc: -lanwei@chromium.org waff...@chromium.org
Hmm... there are Flash-related changes from waffles@ in all three of the regression/improvement/regression ranges. waffles, any chance that's related?
Project Member

Comment 11 by 42576172...@developer.gserviceaccount.com, Jul 22 2016

Mergedinto: 629296
Status: Duplicate (was: Assigned)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Fix component-installer-controlled Flash path.
Author  : waffles
Commit description:
  
BUG=627959

Review-Url: https://codereview.chromium.org/2150573004
Cr-Commit-Position: refs/heads/master@{#405419}
Commit  : 3436cd4cbccb4c573185e2faefc248727e1baecb
Date    : Thu Jul 14 02:50:17 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev   N  Good?
chromium@405407  11.5632  0.332087  5  good
chromium@405414  11.6692  0.263937  5  good
chromium@405418  11.3374  0.418154  5  good
chromium@405419  14.1438  0.894812  5  bad    <--
chromium@405420  14.3726  1.30306   5  bad
chromium@405421  14.4664  0.733305  5  bad
chromium@405435  14.7862  0.445155  5  bad

Bisect job ran on: mac_retina_perf_bisect
Bug ID: 623801

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests smoothness.top_25_smooth
Test Metric: mean_input_event_latency/http___answers.yahoo.com
Relative Change: 27.87%
Score: 99.0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_bisect/builds/1436
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9006408100199994256


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5792597885321216

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 12 by 42576172...@developer.gserviceaccount.com, Jul 22 2016

Mergedinto: -629296 623804

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Refactor flash component installer to use DefaultComponentInstaller.
Author  : waffles
Commit description:
  This enables it to use differential updates.

BUG= 601928 

Review-Url: https://codereview.chromium.org/2041573002
Cr-Commit-Position: refs/heads/master@{#401973}
Commit  : 5a2538963cbd28c53ed0f4befc24bd9b4d99f77c
Date    : Fri Jun 24 21:24:53 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev   N  Good?
chromium@401960  11.3612  0.228448  5  good
chromium@401972  12.0342  0.234441  5  good
chromium@401973  19.474   1.07428   5  bad    <--
chromium@401974  18.0938  0.582867  5  bad
chromium@401975  18.5188  1.14121   5  bad
chromium@401978  18.6556  1.26548   5  bad
chromium@401983  18.5164  0.936655  5  bad

Bisect job ran on: mac_retina_perf_bisect
Bug ID: 623801

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests smoothness.top_25_smooth
Test Metric: mean_input_event_latency/Weather.com
Relative Change: 62.98%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_bisect/builds/1435
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9006408139738909008


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5839776490455040

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 13 by 42576172...@developer.gserviceaccount.com, Jul 23 2016

Owner: waff...@chromium.org

=== Auto-CCing suspected CL author waffles@chromium.org ===

Hi waffles@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Fix Flash assert.
Author  : waffles
Commit description:
  
Reland of https://codereview.chromium.org/2109873002/.

BUG= 625201 

Review-Url: https://codereview.chromium.org/2116723002
Cr-Commit-Position: refs/heads/master@{#403476}
Commit  : 4d66c388052c2c22791e859e6918e779fa5e4732
Date    : Fri Jul 01 17:23:56 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev   N  Good?
chromium@403470  97.4098  23.1233   5  good
chromium@403475  83.8455  28.0352   5  good
chromium@403476  16.427   0.365928  5  bad    <--
chromium@403477  16.6434  0.908392  5  bad
chromium@403478  16.4321  0.488524  5  bad
chromium@403480  16.6151  0.569774  5  bad
chromium@403490  16.3391  0.582182  5  bad

Bisect job ran on: win_x64_perf_bisect
Bug ID: 623801

Test Command: src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --also-run-disabled-tests smoothness.top_25_smooth
Test Metric: frame_times/http___answers.yahoo.com
Relative Change: 83.23%
Score: 99.0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/win_x64_perf_bisect/builds/1339
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9006408119187664176


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5257841305190400

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Let's discuss in  issue 623804 .

Sign in to add a comment