New issue
Advanced search Search tips

Issue 623784 link

Starred by 2 users
Status: Fixed
Owner: ----
Closed: Jul 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug
RTL



Sign in to add a comment

Password caps-lock hint in RTL forms should be on left side

Reported by siul...@gmail.com, Jun 28 2016 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.103 Safari/537.36

Example URL:

Steps to reproduce the problem:
1. Load https://ar-ar.facebook.com/
2. Type something in the login password
3. Toggle Caps Lock

What is the expected behavior?
The up-arrow symbol should be on the left of the input field.

What went wrong?
The up-arrow symbol is on the right of the input field, overlapping with the password.

Does it occur on multiple sites: N/A

Is it a problem with a plugin? N/A 

Did this work before? N/A 

Does this work in other browsers? N/A 

Chrome version: 51.0.2704.103  Channel: n/a
OS Version: OS X 10.11.5
Flash Version: Shockwave Flash 22.0 r0

Firefox and Safari work as expected. Chrome/Opera and IE/Edge don't.

Comment 1 by siul...@gmail.com, Jun 28 2016 

screenshot
Screen Shot 2016-06-27 at 16.49.00.png
47.8 KB View Download

Comment 2 by siul...@gmail.com, Jun 28 2016 

Isolated test case
password.html
1.4 KB View Download

Comment 3 by durga.behera@chromium.org, Jun 28 2016

Components: Blink>Forms>Password
Labels: M-53
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on Mac 10.11.5 using stable 51.0.2704.106 and canary 53.0.27782.0.
This is a non-regression issue since M 29.0.1502.0.

Note : Its specific to Mac.

Comment 4 by tkent@chromium.org, Jun 28 2016

Labels: -Pri-2 -Type-Compat -M-53 rtl Hotlist-GoodFirstBug Pri-3 Type-Bug
Status: Available (was: Untriaged)
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dec7875f088d45cd79a82a985c14dfdc7b2c1825

commit dec7875f088d45cd79a82a985c14dfdc7b2c1825
Author: sungmann.cho <sungmann.cho@navercorp.com>
Date: Mon Jul 11 16:02:33 2016

[Mac] Draw the caps lock indicator on the left side for RTL direction.

For RTL direction, the caps lock indicator for password fields should be drawn
on the left side of it, but currently it is always drawn on the right side. This
CL makes it possible to draw the caps lock indicator on the left or right side
depend on current writing direction.

BUG= 623784 

Review-Url: https://codereview.chromium.org/2125533002
Cr-Commit-Position: refs/heads/master@{#404665}

[modify] https://crrev.com/dec7875f088d45cd79a82a985c14dfdc7b2c1825/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/dec7875f088d45cd79a82a985c14dfdc7b2c1825/third_party/WebKit/LayoutTests/fast/text/caps-lock-indicator-enabled-rtl.html
[modify] https://crrev.com/dec7875f088d45cd79a82a985c14dfdc7b2c1825/third_party/WebKit/Source/core/paint/ThemePainterMac.mm
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a58f3739d4f4c7bee66c35766892de03fe8d322d

commit a58f3739d4f4c7bee66c35766892de03fe8d322d
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Tue Jul 12 00:47:08 2016

Auto-rebaseline for r404665

https://chromium.googlesource.com/chromium/src/+/dec7875f0

BUG= 623784 
TBR=sungmann.cho@navercorp.com

Review URL: https://codereview.chromium.org/2141523004 .

Cr-Commit-Position: refs/heads/master@{#404757}

[modify] https://crrev.com/a58f3739d4f4c7bee66c35766892de03fe8d322d/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/a58f3739d4f4c7bee66c35766892de03fe8d322d/third_party/WebKit/LayoutTests/platform/linux/fast/text/caps-lock-indicator-enabled-rtl-expected.png
[add] https://crrev.com/a58f3739d4f4c7bee66c35766892de03fe8d322d/third_party/WebKit/LayoutTests/platform/linux/fast/text/caps-lock-indicator-enabled-rtl-expected.txt
[add] https://crrev.com/a58f3739d4f4c7bee66c35766892de03fe8d322d/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/caps-lock-indicator-enabled-rtl-expected.png
[add] https://crrev.com/a58f3739d4f4c7bee66c35766892de03fe8d322d/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/caps-lock-indicator-enabled-rtl-expected.png
[add] https://crrev.com/a58f3739d4f4c7bee66c35766892de03fe8d322d/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/caps-lock-indicator-enabled-rtl-expected.txt
[add] https://crrev.com/a58f3739d4f4c7bee66c35766892de03fe8d322d/third_party/WebKit/LayoutTests/platform/mac/fast/text/caps-lock-indicator-enabled-rtl-expected.png
[add] https://crrev.com/a58f3739d4f4c7bee66c35766892de03fe8d322d/third_party/WebKit/LayoutTests/platform/mac/fast/text/caps-lock-indicator-enabled-rtl-expected.txt
[add] https://crrev.com/a58f3739d4f4c7bee66c35766892de03fe8d322d/third_party/WebKit/LayoutTests/platform/win/fast/text/caps-lock-indicator-enabled-rtl-expected.png
[add] https://crrev.com/a58f3739d4f4c7bee66c35766892de03fe8d322d/third_party/WebKit/LayoutTests/platform/win/fast/text/caps-lock-indicator-enabled-rtl-expected.txt

Comment 8 by jbroman@chromium.org, Jul 12 2016

Status: Fixed (was: Available)
Layout treat baselines have landed, and look good.
►

Sign in to add a comment