New issue
Advanced search Search tips

Issue 623781 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Update MSE implementation to use TypeError instead of InvalidAccessError per updated spec

Project Member Reported by wolenetz@chromium.org, Jun 28 2016

Issue description

See https://github.com/w3c/media-source/pull/47 for the corresponding spec change
 
A quick survey of currently failing upstream w3c web-platform-tests related to this bug are:
  mediasource-addsourcebuffer.html
   -- .. with empty type
   -- .. with null
  mediasource-appendwindow.html
   -- .. set wrong values to appendWindowStart and appendWindowEnd
  mediasource-duration-boundaryconditions.html
   -- .. set MIN_VALUE - 1
   -- .. Number.NEGATIVE_INFINITY
   -- .. lowest value
   -- .. negative double
   -- .. NaN
  mediasource-remove.html
   -- .. negative start
   -- .. start beyond the duration
   -- .. start larger than the end
   -- .. NEGATIVE_INFINITY end
   -- .. NaN end
   -- .. NaN duration


Note:  bug 607372  tracks fixing mode, when forced to sequence (by generate-timestamps-flag): if app attempts to set mode to segments, throw TypeError.

Status: Started (was: Assigned)
Labels: -M-54 M-55
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf5ee5415899e8e8c9e3ac2385d7092bbd11a3d8

commit bf5ee5415899e8e8c9e3ac2385d7092bbd11a3d8
Author: wolenetz <wolenetz@chromium.org>
Date: Wed Sep 07 22:58:11 2016

MSE: Throw TypeError instead of InvalidAccessError per spec update

Conforms to https://github.com/w3c/media-source/pull/47 spec change for
certain exceptional conditions, leaving a couple pieces for later changes:
1)  bug 607372  "Comply with forcing appendMode to remain 'sequence' for MSE mp3 and adts stream parsers"
2) bug 644863 "Update TrackDefault and TrackDefaultList to use TypeError correctly"

BUG= 623781 
TEST=updated http/tests/media/media-source tests, and current related upstream w3c MSE tests

Review-Url: https://codereview.chromium.org/2315113002
Cr-Commit-Position: refs/heads/master@{#417107}

[modify] https://crrev.com/bf5ee5415899e8e8c9e3ac2385d7092bbd11a3d8/third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-addsourcebuffer.html
[modify] https://crrev.com/bf5ee5415899e8e8c9e3ac2385d7092bbd11a3d8/third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-appendwindow.html
[modify] https://crrev.com/bf5ee5415899e8e8c9e3ac2385d7092bbd11a3d8/third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-duration-boundaryconditions.html
[modify] https://crrev.com/bf5ee5415899e8e8c9e3ac2385d7092bbd11a3d8/third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-remove.html
[modify] https://crrev.com/bf5ee5415899e8e8c9e3ac2385d7092bbd11a3d8/third_party/WebKit/Source/modules/mediasource/MediaSource.cpp
[modify] https://crrev.com/bf5ee5415899e8e8c9e3ac2385d7092bbd11a3d8/third_party/WebKit/Source/modules/mediasource/MediaSource.h
[modify] https://crrev.com/bf5ee5415899e8e8c9e3ac2385d7092bbd11a3d8/third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp

Status: Fixed (was: Started)

Comment 7 Deleted

Comment 8 by njnin...@gmail.com, Sep 13 2016

Vào 12-09-2016 23:03, "njni ngoc" <njningoc@gmail.com> đã viết:

monorail+v2.3152833457@chromium.org> đã viết:

implementation to use TypeError instead of InvalidAccessError per updated
spec

related to this bug are:

generate-timestamps-flag): if app attempts to set mode to segments, throw
TypeError.

Sign in to add a comment