New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 623776 link

Starred by 2 users
Status: Fixed
Owner:
est...@chromium.org
Closed: Jun 2016
Cc:
█ bruthig@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Ink drop highlight not properly centered for views of odd-numbered sizes

Project Member Reported by est...@chromium.org, Jun 28 2016 
This is more noticeable with the shadow hover effect that MD call to action buttons have. If the button is an odd width (e.g. 51) the hover will be slightly off-centered.

This may apply to InkDropRipple as well. I didn't investigate that, but it's probably not as noticeable if it does.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e35190510f4f028f24beac01204f6ef9d6d0643

commit 9e35190510f4f028f24beac01204f6ef9d6d0643
Author: estade <estade@chromium.org>
Date: Tue Jun 28 22:14:12 2016

Fix MD button hover shadow effect on odd-sized buttons.

gfx::Point -> gfx::PointF to fix rounding errors.

BUG= 623776 

Review-Url: https://codereview.chromium.org/2094343005
Cr-Commit-Position: refs/heads/master@{#402567}

[modify] https://crrev.com/9e35190510f4f028f24beac01204f6ef9d6d0643/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
[modify] https://crrev.com/9e35190510f4f028f24beac01204f6ef9d6d0643/chrome/browser/ui/views/download/download_item_view_md.cc
[modify] https://crrev.com/9e35190510f4f028f24beac01204f6ef9d6d0643/ui/views/animation/ink_drop_highlight.cc
[modify] https://crrev.com/9e35190510f4f028f24beac01204f6ef9d6d0643/ui/views/animation/ink_drop_highlight.h
[modify] https://crrev.com/9e35190510f4f028f24beac01204f6ef9d6d0643/ui/views/animation/ink_drop_highlight_unittest.cc
[modify] https://crrev.com/9e35190510f4f028f24beac01204f6ef9d6d0643/ui/views/animation/ink_drop_host_view.cc
[modify] https://crrev.com/9e35190510f4f028f24beac01204f6ef9d6d0643/ui/views/animation/ink_drop_host_view.h
[modify] https://crrev.com/9e35190510f4f028f24beac01204f6ef9d6d0643/ui/views/animation/test/test_ink_drop_host.cc
[modify] https://crrev.com/9e35190510f4f028f24beac01204f6ef9d6d0643/ui/views/controls/button/label_button.cc
[modify] https://crrev.com/9e35190510f4f028f24beac01204f6ef9d6d0643/ui/views/controls/button/md_text_button.cc

Comment 2 by est...@chromium.org, Jun 29 2016

Labels: Proj-MaterialDesign-NativeUI
Status: Fixed (was: Started)
►

Sign in to add a comment