We need to generalize way how we pass additional information about different JS objects via internal properties.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/986d0c88cf902981788863f72ea0c542767e580d commit 986d0c88cf902981788863f72ea0c542767e580d Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Wed Jun 29 02:25:24 2016 [DevTools] Move collectionEntries to internalProperties in protocol BUG= 623763 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2102453003 Cr-Commit-Position: refs/heads/master@{#402671} [modify] https://crrev.com/986d0c88cf902981788863f72ea0c542767e580d/third_party/WebKit/LayoutTests/inspector/console/console-dir-es6-expected.txt [modify] https://crrev.com/986d0c88cf902981788863f72ea0c542767e580d/third_party/WebKit/LayoutTests/inspector/console/console-format-es6-2-expected.txt [modify] https://crrev.com/986d0c88cf902981788863f72ea0c542767e580d/third_party/WebKit/LayoutTests/inspector/console/console-format-es6-expected.txt [modify] https://crrev.com/986d0c88cf902981788863f72ea0c542767e580d/third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js [modify] https://crrev.com/986d0c88cf902981788863f72ea0c542767e580d/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js [modify] https://crrev.com/986d0c88cf902981788863f72ea0c542767e580d/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js [modify] https://crrev.com/986d0c88cf902981788863f72ea0c542767e580d/third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js [modify] https://crrev.com/986d0c88cf902981788863f72ea0c542767e580d/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp [modify] https://crrev.com/986d0c88cf902981788863f72ea0c542767e580d/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js [modify] https://crrev.com/986d0c88cf902981788863f72ea0c542767e580d/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp [modify] https://crrev.com/986d0c88cf902981788863f72ea0c542767e580d/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h [modify] https://crrev.com/986d0c88cf902981788863f72ea0c542767e580d/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp [modify] https://crrev.com/986d0c88cf902981788863f72ea0c542767e580d/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h [modify] https://crrev.com/986d0c88cf902981788863f72ea0c542767e580d/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp [modify] https://crrev.com/986d0c88cf902981788863f72ea0c542767e580d/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.h [modify] https://crrev.com/986d0c88cf902981788863f72ea0c542767e580d/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp [modify] https://crrev.com/986d0c88cf902981788863f72ea0c542767e580d/third_party/WebKit/Source/platform/v8_inspector/injected_script_externs.js [modify] https://crrev.com/986d0c88cf902981788863f72ea0c542767e580d/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af24351730c9de832e6bdfef8003fb7e808cb525 commit af24351730c9de832e6bdfef8003fb7e808cb525 Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Fri Jul 08 01:14:59 2016 [DevTools] Move suspended generator location to internal properties BUG= 623763 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2112673003 Cr-Commit-Position: refs/heads/master@{#404297} [modify] https://crrev.com/af24351730c9de832e6bdfef8003fb7e808cb525/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/function-generator-details-expected.txt [modify] https://crrev.com/af24351730c9de832e6bdfef8003fb7e808cb525/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/function-generator-details.html [modify] https://crrev.com/af24351730c9de832e6bdfef8003fb7e808cb525/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/show-generator-location.html [modify] https://crrev.com/af24351730c9de832e6bdfef8003fb7e808cb525/third_party/WebKit/Source/devtools/front_end/components/ObjectPopoverHelper.js [modify] https://crrev.com/af24351730c9de832e6bdfef8003fb7e808cb525/third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js [modify] https://crrev.com/af24351730c9de832e6bdfef8003fb7e808cb525/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js [modify] https://crrev.com/af24351730c9de832e6bdfef8003fb7e808cb525/third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js [modify] https://crrev.com/af24351730c9de832e6bdfef8003fb7e808cb525/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js [modify] https://crrev.com/af24351730c9de832e6bdfef8003fb7e808cb525/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js [modify] https://crrev.com/af24351730c9de832e6bdfef8003fb7e808cb525/third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js [modify] https://crrev.com/af24351730c9de832e6bdfef8003fb7e808cb525/third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js [modify] https://crrev.com/af24351730c9de832e6bdfef8003fb7e808cb525/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js [modify] https://crrev.com/af24351730c9de832e6bdfef8003fb7e808cb525/third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js [modify] https://crrev.com/af24351730c9de832e6bdfef8003fb7e808cb525/third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js [modify] https://crrev.com/af24351730c9de832e6bdfef8003fb7e808cb525/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp [modify] https://crrev.com/af24351730c9de832e6bdfef8003fb7e808cb525/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js [modify] https://crrev.com/af24351730c9de832e6bdfef8003fb7e808cb525/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp [modify] https://crrev.com/af24351730c9de832e6bdfef8003fb7e808cb525/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h [modify] https://crrev.com/af24351730c9de832e6bdfef8003fb7e808cb525/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp [modify] https://crrev.com/af24351730c9de832e6bdfef8003fb7e808cb525/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h [modify] https://crrev.com/af24351730c9de832e6bdfef8003fb7e808cb525/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp [modify] https://crrev.com/af24351730c9de832e6bdfef8003fb7e808cb525/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.h [modify] https://crrev.com/af24351730c9de832e6bdfef8003fb7e808cb525/third_party/WebKit/Source/platform/v8_inspector/debugger_script_externs.js [modify] https://crrev.com/af24351730c9de832e6bdfef8003fb7e808cb525/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b6a87d77630749c6c5a64ba94a6bb855d18a81d commit 5b6a87d77630749c6c5a64ba94a6bb855d18a81d Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Wed Jul 13 02:45:24 2016 [DevTools] Remove functionDetails from protocol.json BUG= 623763 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2122423002 Cr-Commit-Position: refs/heads/master@{#404926} [modify] https://crrev.com/5b6a87d77630749c6c5a64ba94a6bb855d18a81d/third_party/WebKit/LayoutTests/inspector-protocol/debugger/continueToLocation.html [modify] https://crrev.com/5b6a87d77630749c6c5a64ba94a6bb855d18a81d/third_party/WebKit/LayoutTests/inspector-protocol/debugger/setScriptSource.html [delete] https://crrev.com/a7e6a571947df4ac9a93a8d43882c6d8588514b6/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-getFunctionDetails-expected.txt [delete] https://crrev.com/a7e6a571947df4ac9a93a8d43882c6d8588514b6/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-getFunctionDetails.html [modify] https://crrev.com/5b6a87d77630749c6c5a64ba94a6bb855d18a81d/third_party/WebKit/LayoutTests/inspector/console/console-dir-expected.txt [modify] https://crrev.com/5b6a87d77630749c6c5a64ba94a6bb855d18a81d/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/function-details-expected.txt [modify] https://crrev.com/5b6a87d77630749c6c5a64ba94a6bb855d18a81d/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/function-details.html [modify] https://crrev.com/5b6a87d77630749c6c5a64ba94a6bb855d18a81d/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/watch-expressions-preserve-expansion-expected.txt [modify] https://crrev.com/5b6a87d77630749c6c5a64ba94a6bb855d18a81d/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/watch-expressions-preserve-expansion.html [modify] https://crrev.com/5b6a87d77630749c6c5a64ba94a6bb855d18a81d/third_party/WebKit/LayoutTests/inspector/sources/debugger/properties-special-expected.txt [modify] https://crrev.com/5b6a87d77630749c6c5a64ba94a6bb855d18a81d/third_party/WebKit/LayoutTests/inspector/sources/debugger/properties-special.html [modify] https://crrev.com/5b6a87d77630749c6c5a64ba94a6bb855d18a81d/third_party/WebKit/Source/devtools/front_end/components/EventListenersUtils.js [modify] https://crrev.com/5b6a87d77630749c6c5a64ba94a6bb855d18a81d/third_party/WebKit/Source/devtools/front_end/components/ObjectPopoverHelper.js [modify] https://crrev.com/5b6a87d77630749c6c5a64ba94a6bb855d18a81d/third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js [modify] https://crrev.com/5b6a87d77630749c6c5a64ba94a6bb855d18a81d/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js [modify] https://crrev.com/5b6a87d77630749c6c5a64ba94a6bb855d18a81d/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js [modify] https://crrev.com/5b6a87d77630749c6c5a64ba94a6bb855d18a81d/third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js [modify] https://crrev.com/5b6a87d77630749c6c5a64ba94a6bb855d18a81d/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js [modify] https://crrev.com/5b6a87d77630749c6c5a64ba94a6bb855d18a81d/third_party/WebKit/Source/platform/blink_platform.gypi [modify] https://crrev.com/5b6a87d77630749c6c5a64ba94a6bb855d18a81d/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp [modify] https://crrev.com/5b6a87d77630749c6c5a64ba94a6bb855d18a81d/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js [modify] https://crrev.com/5b6a87d77630749c6c5a64ba94a6bb855d18a81d/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp [modify] https://crrev.com/5b6a87d77630749c6c5a64ba94a6bb855d18a81d/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h [modify] https://crrev.com/5b6a87d77630749c6c5a64ba94a6bb855d18a81d/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp [modify] https://crrev.com/5b6a87d77630749c6c5a64ba94a6bb855d18a81d/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h [modify] https://crrev.com/5b6a87d77630749c6c5a64ba94a6bb855d18a81d/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp [modify] https://crrev.com/5b6a87d77630749c6c5a64ba94a6bb855d18a81d/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.h [add] https://crrev.com/5b6a87d77630749c6c5a64ba94a6bb855d18a81d/third_party/WebKit/Source/platform/v8_inspector/V8InternalValueType.cpp [add] https://crrev.com/5b6a87d77630749c6c5a64ba94a6bb855d18a81d/third_party/WebKit/Source/platform/v8_inspector/V8InternalValueType.h [modify] https://crrev.com/5b6a87d77630749c6c5a64ba94a6bb855d18a81d/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/600fbafd392e6bf2c4586b3a25a9b71932909a1a commit 600fbafd392e6bf2c4586b3a25a9b71932909a1a Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Thu Jul 14 00:13:41 2016 [DevTools] Fix native function console output BUG= 623763 R=lushnikov@chromium.org Review-Url: https://codereview.chromium.org/2139363005 Cr-Commit-Position: refs/heads/master@{#405359} [modify] https://crrev.com/600fbafd392e6bf2c4586b3a25a9b71932909a1a/third_party/WebKit/LayoutTests/inspector/console/console-native-function-expected.txt [modify] https://crrev.com/600fbafd392e6bf2c4586b3a25a9b71932909a1a/third_party/WebKit/LayoutTests/inspector/console/console-native-function.html [modify] https://crrev.com/600fbafd392e6bf2c4586b3a25a9b71932909a1a/third_party/WebKit/Source/devtools/front_end/components/ObjectPopoverHelper.js [modify] https://crrev.com/600fbafd392e6bf2c4586b3a25a9b71932909a1a/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
Comment 1 by bugdroid1@chromium.org
, Jun 29 2016