New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 623753 link

Starred by 3 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Error out if user attempts to run_benchmark try with --reset-results.

Project Member Reported by nedngu...@google.com, Jun 27 2016

Issue description

Example run: https://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus6_perf_bisect/builds/2264

It seems like the culprit is because the "Performance Test (Without Patch) 1 of 1" set "--reset-results" flag, whereas it shouldn't have that flag to preserve the results from  "Performance Test (With Patch) 1 of 1" run.
 
Cc: panicker@chromium.org
Actually the reason is Shubbie run "run_benchmark try... --reset-results". I think the fix here is to error out if people pass in --reset-results in the commandline.
Project Member

Comment 2 by sheriffbot@chromium.org, Jun 28 2016

Labels: Hotlist-Google
Labels: -Hotlist-Google
Owner: eakuefner@chromium.org
Status: Started (was: Untriaged)
Labels: -Pri-1 Pri-2
Summary: E (was: Results.html of trybot run only show results of "TOT (without patch)")
Summary: Error out if user attempts to run_benchmark try with --reset-results. (was: E)
Project Member

Comment 6 by sheriffbot@chromium.org, Jun 29 2016

Labels: Hotlist-Google
Components: Speed>Bisection
Status: Archived (was: Started)

Sign in to add a comment