New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 623736 link

Starred by 1 user
Status: Fixed
Owner:
█ romax@chromium.org
Last visit > 30 days ago
Closed: Jul 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Lack of histogram suffix for async loading crashes chrome when expiring offline pages.

Project Member Reported by fgor...@chromium.org, Jun 27 2016 
We need to add the suffix in histograms.

Right now the problem manifests this way
F/chromium( 8044): [FATAL:histogram_base.cc(73)] Check failed: histogram_name() == name (OfflinePages.ExpirePage.PageLifetime.async_loading vs. OfflinePages.ExpirePage.PageLifetime.last_n)

But all suffix dependent histograms will have this problem.

Comment 1 by fgor...@chromium.org, Jun 27 2016 

Currently corresponding client namespace is only created here:
https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java?dr=C&q=async_loading&sq=package:chromium&l=175

Which complicates matters a little bit.

Comment 2 by fgor...@chromium.org, Jun 29 2016

Labels: -Pri-2 Pri-3
Owner: romax@chromium.org
Status: Assigned (was: Untriaged)
It needs:
* namespace
* histogram suffix
* client policy
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14c0911f78eaf6c704b65ed46b300ed52f0f1626

commit 14c0911f78eaf6c704b65ed46b300ed52f0f1626
Author: romax <romax@chromium.org>
Date: Thu Jul 14 02:01:06 2016

[Offline Pages] Adding metadatas for namespace async_loading.

Added namespace, histogram suffix and client policy for async_loading.
Also fixed a crash when adding suffixes for expiring histograms.

BUG= 623736 

Review-Url: https://codereview.chromium.org/2111653002
Cr-Commit-Position: refs/heads/master@{#405401}

[modify] https://crrev.com/14c0911f78eaf6c704b65ed46b300ed52f0f1626/components/offline_pages/client_namespace_constants.cc
[modify] https://crrev.com/14c0911f78eaf6c704b65ed46b300ed52f0f1626/components/offline_pages/client_namespace_constants.h
[modify] https://crrev.com/14c0911f78eaf6c704b65ed46b300ed52f0f1626/components/offline_pages/client_policy_controller.cc
[modify] https://crrev.com/14c0911f78eaf6c704b65ed46b300ed52f0f1626/components/offline_pages/client_policy_controller_unittest.cc
[modify] https://crrev.com/14c0911f78eaf6c704b65ed46b300ed52f0f1626/components/offline_pages/offline_page_model_impl.cc
[modify] https://crrev.com/14c0911f78eaf6c704b65ed46b300ed52f0f1626/components/offline_pages/offline_page_storage_manager.cc
[modify] https://crrev.com/14c0911f78eaf6c704b65ed46b300ed52f0f1626/components/offline_pages/offline_page_storage_manager_unittest.cc
[modify] https://crrev.com/14c0911f78eaf6c704b65ed46b300ed52f0f1626/tools/metrics/histograms/histograms.xml

Comment 4 by romax@chromium.org, Jul 19 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment