New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 623735 link

Starred by 5 users
Status: Verified
Owner:
█ xiaoyinh@chromium.org
Last visit > 30 days ago
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Chrome web browser does not minimize when touched on Asus Flip

Reported by msmig...@gmail.com, Jun 27 2016 
UserAgent: Mozilla/5.0 (X11; CrOS armv7l 8172.60.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.103 Safari/537.36
Platform: 8172.60.0 (Official Build) stable-channel veyron_minnie

Steps to reproduce the problem:
1. Ensure that you are on an Asus Flip and that the Chrome web browser is pinned to the task bar and running (maximized).
2. Click on the task bar entry for Chrome with the trackpad and notice it minimize. 
3. Open Chrome again.
4. Now, using the touch screen, touch the task bar entry for Chrome and notice it shake in place but not minimize.

What is the expected behavior?
When both clicked with the trackpad and touched, the Chrome web browser should minimize if already running and open.

What went wrong?
The behavior between the trackpad clicks and screen touches is inconsistent when trying to minimize the Chrome web browser. Other apps (Gmail, Youtube) do not have this problem, only the Chrome web browser.

Did this work before? N/A 

Chrome version: 51.0.2704.103  Channel: stable
OS Version: 8172.60.0
Flash Version: Shockwave Flash 22.0 r0

Comment 1 by jim.dan...@gmail.com, Jun 27 2016 

Verified this on my ASUS Flip and also on my Acer R11
I also sent feedback from this email.

#CBC-RS/TC-watchlist

Comment 2 by mgreenwald@google.com, Aug 4 2016

Owner: abodenha@chromium.org
Status: Available (was: Unconfirmed)

Comment 3 by abodenha@chromium.org, Aug 5 2016 

jim.dantin@ you're on 53 right?

Comment 4 by abodenha@chromium.org, Aug 9 2016

Owner: xiaoyinh@chromium.org
Status: Assigned (was: Available)

Comment 5 by dymp...@gmail.com, Aug 19 2016 

Confirming/verifying for this version as well.

Version 54.0.2830.0 dev
Platform 8714.1.0 (Official Build) dev-channel veyron_minnie
ARC Version 3152188
Firmware Google_Veyron_Minnie.6588.197.0
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3738b46fe8caa61fb134498fb45441d9ba8b3390

commit 3738b46fe8caa61fb134498fb45441d9ba8b3390
Author: xiaoyinh <xiaoyinh@chromium.org>
Date: Thu Aug 25 21:18:40 2016

fix for Chrome web browser does not minimize when touched.

event type is not initialized as bitmap, and should be
compared with ==.
In this case, some touch/gesture events are treated as
ui::ET_KEY_RELEASED and web browser did not get activated when touched.

BUG= 623735 

Review-Url: https://codereview.chromium.org/2280493002
Cr-Commit-Position: refs/heads/master@{#414542}

[modify] https://crrev.com/3738b46fe8caa61fb134498fb45441d9ba8b3390/chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc

Comment 7 by xiaoyinh@chromium.org, Aug 25 2016

Status: Fixed (was: Assigned)

Comment 8 by patricia@chromium.org, Aug 29 2016

Labels: VerifyIn-54

Comment 9 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55

Comment 10 by sdantul...@chromium.org, Oct 21 2016

Status: Verified (was: Fixed)
Verified on ChromeOS 8872.18.0, 55.0.2883.20
►

Sign in to add a comment