sidneym@ is dead, long live sdy@{google.com,chromium.org}.

Hi there Sidney, any progress on this?

Hi yyushkina@, and sorry for the lag! I was planning to get to this in the next week or two. Is that OK? If it's urgent, I'd be happy to do it sooner.

Next week or two is fine - thanks!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c635ed1edb8cbcb68fe5a0646cb554b8dd32b8a

commit 7c635ed1edb8cbcb68fe5a0646cb554b8dd32b8a
Author: sdy <sdy@chromium.org>
Date: Mon Aug 15 01:52:10 2016

[Mac] Clean up SadTabView and let SadTabController provide its content

Prep for making the sad tab's content more dynamic, plus some touch-up
and shuffling of responsibilities.

- Adds methods to `SadTabView` to set the text of each interface element
  and the help URL, and makes `SadTabController` responsible for setting
  them. `SadTabView` still controls appearance and layout.

- Gives `SadTabView` a delegate to signal clicks. The button is now
  private, and tests now use a `WebContentsDelegate` to detect a click
  on the help link instead of extending `NSApplication`.

- Removes some uses of `scoped_nsobject` for instance variables that
  just need to be weak references.

BUG= 623690 

Review-Url: https://codereview.chromium.org/2247493003
Cr-Commit-Position: refs/heads/master@{#411932}

[modify] https://crrev.com/7c635ed1edb8cbcb68fe5a0646cb554b8dd32b8a/chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.h
[modify] https://crrev.com/7c635ed1edb8cbcb68fe5a0646cb554b8dd32b8a/chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.mm
[modify] https://crrev.com/7c635ed1edb8cbcb68fe5a0646cb554b8dd32b8a/chrome/browser/ui/cocoa/tab_contents/sad_tab_controller_unittest.mm
[modify] https://crrev.com/7c635ed1edb8cbcb68fe5a0646cb554b8dd32b8a/chrome/browser/ui/cocoa/tab_contents/sad_tab_view_cocoa.h
[modify] https://crrev.com/7c635ed1edb8cbcb68fe5a0646cb554b8dd32b8a/chrome/browser/ui/cocoa/tab_contents/sad_tab_view_cocoa.mm
[modify] https://crrev.com/7c635ed1edb8cbcb68fe5a0646cb554b8dd32b8a/ui/gfx/test/ui_cocoa_test_helper.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26cabf35396e65533b30062b89aee46cbf55b862

commit 26cabf35396e65533b30062b89aee46cbf55b862
Author: sdy <sdy@chromium.org>
Date: Fri Sep 09 16:52:24 2016

Bring the feedback button to the Mac sad tab

The Views implementation of SadTab supports two big things that were
missing in the Mac implementation:

1. The reload button turns into a feedback button on repeated crashes.
2. Histograms for tracking different kinds of crashes.

This moves that logic up into the base SadTab, so that both
implementations can use it.

It also adds new histograms to count when a sad tab with a reload button
or feedback button is displayed, and clicks on the button or help link.

Other changes:

- HISTOGRAM_ENUMERATION_WITH_FLAG uses a new base::underlying_value()
  function to cast scoped enums to their underlying integral values.
  (Unlike classic enums, they don't implicitly convert).

- The Show() and Close() methods of SadTab are gone. Show() was always
  called right after construction, and Close() was always called right
  before destruction, so I merged them with the ctor+dtor.

- SadTabController is gone.

- SadTabView no longer gets a reference to the WebContents; SadTabCocoa
  is now responsible for sizing it and adding it to the view hierarchy.

- The help link text no longer selects when you right click it.

BUG= 623690 
TEST=Trigger sad tabs on each platform either with chrome://crash or by
killing processes in the task manager. Check that the first sad tab
shows a reload button and subsequent sad tabs show a feedback button.
Otherwise, the look and behavior of the sad tab should be the same.

Review-Url: https://codereview.chromium.org/2261793002
Cr-Commit-Position: refs/heads/master@{#417606}

[modify] https://crrev.com/26cabf35396e65533b30062b89aee46cbf55b862/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/7212ed1dbe75a59b2d8694b483554b3d3098eca6/chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.h
[delete] https://crrev.com/7212ed1dbe75a59b2d8694b483554b3d3098eca6/chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.mm
[delete] https://crrev.com/7212ed1dbe75a59b2d8694b483554b3d3098eca6/chrome/browser/ui/cocoa/tab_contents/sad_tab_controller_unittest.mm
[add] https://crrev.com/26cabf35396e65533b30062b89aee46cbf55b862/chrome/browser/ui/cocoa/tab_contents/sad_tab_mac.mm
[add] https://crrev.com/26cabf35396e65533b30062b89aee46cbf55b862/chrome/browser/ui/cocoa/tab_contents/sad_tab_mac_unittest.mm
[modify] https://crrev.com/26cabf35396e65533b30062b89aee46cbf55b862/chrome/browser/ui/cocoa/tab_contents/sad_tab_view_cocoa.h
[modify] https://crrev.com/26cabf35396e65533b30062b89aee46cbf55b862/chrome/browser/ui/cocoa/tab_contents/sad_tab_view_cocoa.mm
[delete] https://crrev.com/7212ed1dbe75a59b2d8694b483554b3d3098eca6/chrome/browser/ui/cocoa/tab_contents/sad_tab_view_cocoa_unittest.mm
[modify] https://crrev.com/26cabf35396e65533b30062b89aee46cbf55b862/chrome/browser/ui/sad_tab.cc
[modify] https://crrev.com/26cabf35396e65533b30062b89aee46cbf55b862/chrome/browser/ui/sad_tab.h
[modify] https://crrev.com/26cabf35396e65533b30062b89aee46cbf55b862/chrome/browser/ui/sad_tab_helper.cc
[modify] https://crrev.com/26cabf35396e65533b30062b89aee46cbf55b862/chrome/browser/ui/views/sad_tab_view.cc
[modify] https://crrev.com/26cabf35396e65533b30062b89aee46cbf55b862/chrome/browser/ui/views/sad_tab_view.h
[modify] https://crrev.com/26cabf35396e65533b30062b89aee46cbf55b862/chrome/test/BUILD.gn
[modify] https://crrev.com/26cabf35396e65533b30062b89aee46cbf55b862/tools/metrics/histograms/histograms.xml

Note for testers: the feedback button should only show up in branded Chrome builds. Chromium builds' sad tab behavior shouldn't change.