New issue
Advanced search Search tips

Issue 623678 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task

Blocking:
issue 608912



Sign in to add a comment

Add MSE EventHandler IDL attributes

Project Member Reported by wolenetz@chromium.org, Jun 27 2016

Issue description

Change description:
Per recent MSE spec change [1], we need to add EventHandler attributes for MSE objects. The logic for the events does not change; this change just adds support for them via EventHandler attributes.
[1]  https://github.com/w3c/media-source/pull/75

Changes to API surface:
Attributes for MediaSource events:
* onsourceopen
* onsourceended
* onsourceclose

Attributes for SourceBuffer events:
* onupdatestart
* onupdate
* onupdateend
* onerror
* onabort

Attributes for SourceBufferList events:
* onaddsourcebuffer
* onremovesourcebuffer

Links:
Public standards discussion: https://github.com/w3c/media-source/issues/66 (and [1], above).

Support in other browsers:
Edge: Expected per discussion on the spec issue and at face-to-face.
 
Blocking: 608912
Cc: wolenetz@chromium.org chcunningham@chromium.org phil...@opera.com
 Issue 608912  has been merged into this issue.
Labels: MSE-compat
Labels: MSE-scrubbed
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00003ed19f12e054784ee59b95c863b380361ef4

commit 00003ed19f12e054784ee59b95c863b380361ef4
Author: wolenetz <wolenetz@chromium.org>
Date: Wed Jun 29 22:17:07 2016

MSE: Add EventHandler attributes to MSE objects

Per intent [3], and due to recent spec change [1] for spec issue [2], this change adds
EventHandler attributes for MSE objects as follows:

Attributes for MediaSource events:
* onsourceopen
* onsourceended
* onsourceclose

Attributes for SourceBuffer events:
* onupdatestart
* onupdate
* onupdateend
* onerror
* onabort

Attributes for SourceBufferList events:
* onaddsourcebuffer
* onremovesourcebuffer

[1] https://github.com/w3c/media-source/pull/75
[2] https://github.com/w3c/media-source/issues/66
[3] https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/dM_8nlXvJIE

R=mlamouri@chromium.org,rbyers@chromium.org,chcunningham@chromium.org
BUG= 623678 

Review-Url: https://codereview.chromium.org/1945523003
Cr-Commit-Position: refs/heads/master@{#402946}

[modify] https://crrev.com/00003ed19f12e054784ee59b95c863b380361ef4/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/00003ed19f12e054784ee59b95c863b380361ef4/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/00003ed19f12e054784ee59b95c863b380361ef4/third_party/WebKit/Source/modules/mediasource/MediaSource.h
[modify] https://crrev.com/00003ed19f12e054784ee59b95c863b380361ef4/third_party/WebKit/Source/modules/mediasource/MediaSource.idl
[modify] https://crrev.com/00003ed19f12e054784ee59b95c863b380361ef4/third_party/WebKit/Source/modules/mediasource/SourceBuffer.h
[modify] https://crrev.com/00003ed19f12e054784ee59b95c863b380361ef4/third_party/WebKit/Source/modules/mediasource/SourceBuffer.idl
[modify] https://crrev.com/00003ed19f12e054784ee59b95c863b380361ef4/third_party/WebKit/Source/modules/mediasource/SourceBufferList.h
[modify] https://crrev.com/00003ed19f12e054784ee59b95c863b380361ef4/third_party/WebKit/Source/modules/mediasource/SourceBufferList.idl

Labels: -MSE-scrubbed MSEscrubbed

Comment 7 by foolip@chromium.org, Nov 11 2016

Cc: foolip@chromium.org

Comment 8 by foolip@chromium.org, Nov 11 2016

Cc: -phil...@opera.com

Comment 9 by owe...@chromium.org, Sep 12 2017

Labels: migrated-launch-owp Type-Task
This issue has been automatically relabelled type=task because type=launch-owp issues are now officially deprecated. The deprecation is because they were creating confusion about how to get launch approvals, which should be instead done via type=launch issues.

We recommend this issue be used for implementation tracking (for public visibility), but if you already have an issue for that, you may mark this as duplicate.

For more details see here: https://docs.google.com/document/d/1JA6RohjtZQc26bTrGoIE_bSXGXUDQz8vc6G0n_sZJ2o/edit

For any questions, please contact owencm, sshruthi, larforge
Status: Fixed (was: Assigned)
This (#5) shipped long ago in M53. Closing.

Sign in to add a comment