New issue
Advanced search Search tips

Issue 623673 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

weave CI: getting e-mails on failed bot runs

Project Member Reported by vapier@chromium.org, Jun 27 2016

Issue description

i thought i filed a bug about this already, but can't find it.  maybe it was just a chat.

we have a brillo bot [1] that sends e-mails when things fail.  i want the weave bot [2] to do the same.  i compared the two configs and i'm not seeing any diff between them.  are there any e-mail creds that need to be deployed to this system too ?

if not, any thoughts on values to check ?

[1] https://uberchromegw.corp.google.com/i/internal.client.brillo/builders/bbuildbot
[2] https://uberchromegw.corp.google.com/i/internal.client.weave/builders/libiota
 
Cc: friedman@chromium.org
I haven't checked logs, but if the configs match, the problem is probably that the weave builder doesn't have credentials to send email with. That's a puppet issue (mostly).
Both these slaves are getting the same classes and credentials so I'm not sure what is going on.  Can you look into the logs?  I'm not ruling out puppet and the creds just yet, but looking at what is being applied, it looks very similar.

https://chrome-internal.googlesource.com/infra/puppet/+/master/testing/enc/expectations/vm20-m7.golo.chromium.org.yaml
vs.
https://chrome-internal.googlesource.com/infra/puppet/+/master/testing/enc/expectations/vm99-m7.golo.chromium.org.yaml

Comment 3 by moberoi@google.com, Jul 22 2016

hey folks - vapier is out on vacation - can someone help us figure out why we are not getting the email for libiota failures ? The logs can be accessed via the links vapier posted. Thanks a lot !

Comment 4 by d...@chromium.org, Jul 22 2016

Worth noting that no failed builds have happened in the week prior to this bug being filed, so we don't have too much data.

What exactly is supposed to be sending e-mails here? "libiota" is running cbuildbot, which is capable of sending its own e-mails. Is it configured to do this for "libiota"? If it is, there should be diagnostic logs regarding its failure to do so in the build, right?
Can you craft a command line script that uses all your credentials etc for sending the email so that we can test?

Comment 6 by d...@chromium.org, Jul 25 2016

Let's figure out #4 first?
Status: Untriaged (was: Unconfirmed)
the poller issue has been resolved now, so we're getting builds on a regular basis

as for how it's expected to work, i think Don is the best guy to answer that.  otherwise, i'll have to start throwing debug code at it.
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/65ab030675bfbaa5991d41e7eff44462e2711a33

commit 65ab030675bfbaa5991d41e7eff44462e2711a33
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed Aug 10 08:00:40 2016

cbuildbot: enable e-mails for weave waterfall

BUG= chromium:623673 
TEST=unittests pass

Change-Id: I55ca37d9ea03cdf5c012c73d7d2bc87c6327b86f
Reviewed-on: https://chromium-review.googlesource.com/367620
Reviewed-by: Don Garrett <dgarrett@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/65ab030675bfbaa5991d41e7eff44462e2711a33/cbuildbot/constants.py

Cc: -d...@chromium.org -friedman@chromium.org
Components: -Infra>Client
Labels: -Pri-3 Pri-2
Owner: vapier@chromium.org
in hacking around a bit, i can get some e-mails out of it, so the gmail creds look like they're working fine now, and it's no longer an issue with Chrome infra.  i'll take it from here.  thanks !
Status: Started (was: Untriaged)
i tracked down a few more manifests that needed updating (probably should reconsider the pinning that we're doing once e-mails work).  only thing left is whitelisting the account that sends the e-mails.
Status: Fixed (was: Started)
moving to b/31066221 to assign to the admins of the iota-eng group.  everything on the chrome side should be all set.
Labels: VerifyIn-54

Comment 14 Deleted

Comment 15 Deleted

Comment 16 Deleted

Comment 17 Deleted

Labels: VerifyIn-55

Comment 19 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 20 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 21 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 22 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 23 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 25 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)
Status: Fixed (was: Archived)

Sign in to add a comment