New issue
Advanced search Search tips

Issue 623672 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

proguard_config in an apk cannot be overriden

Reported by kra...@amazon.com, Jun 27 2016

Issue description

Version: Tip of master
OS: Android

What steps will reproduce the problem?
(1) Build an apk target with a proguard config

What is the expected output?
[1/1] Regenerating ninja files
<Build starts>

What do you see instead?
[1/1] Regenerating ninja files
ERROR at //build/config/android/rules.gni:2319:9: Replacing nonempty list.
        proguard_configs = invoker.proguard_configs
        ^---------------
This overwrites a previously-defined nonempty list (length 1).
See //amazon/mypath/BUILD.gn:156:24: for previous definition
    proguard_configs = [ "//amazon/mypath/java/proguard.flags" ]
                       ^----------------------------------------------
with another one (length 1). Did you mean "+=" to append instead? If you
really want to do this, do
  proguard_configs = []
before reassigning.


Please use labels and text to provide additional information.
 
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef53525821a41adb38fedd2e9b14deb12578da3d

commit ef53525821a41adb38fedd2e9b14deb12578da3d
Author: kraush <kraush@amazon.com>
Date: Tue Jun 28 22:42:27 2016

Remove proguard specific override block

Proguard config is already forwarded using a
separate mechanism. Remove this if-block
to get rid of the duplication.

BUG= 623672 

Review-Url: https://codereview.chromium.org/2101033002
Cr-Commit-Position: refs/heads/master@{#402578}

[modify] https://crrev.com/ef53525821a41adb38fedd2e9b14deb12578da3d/build/config/android/rules.gni

Components: Build
Status: Fixed (was: Untriaged)

Comment 5 Deleted

Sign in to add a comment