New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 623659 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Blocked on:
issue 525752
issue 623661
issue 624274
issue 624478
issue 629709



Sign in to add a comment

Flip official Win builders to GN

Project Member Reported by dpranke@chromium.org, Jun 27 2016

Issue description

This is a bug for tracking flipping the offical win builders (official.desktop.continuous and official.desktop) to GN.
 
Summary: Flip official Win builders to GN (was: Flip offiicial Win builders to GN)
Blockedon: 623661
Blockedon: 525752
Labels: -Pri-1 -M-53 Pri-2
This won't make M-53, so I'm clearing the label.
Labels: -Proj-GN-Migration Proj-GN-Migration-Ship
Blocking: -621677
Blockedon: -623661
Blocking: -354261
Blockedon: 623661 624274
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 11 2016

Project Member

Comment 11 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8524d4afab4f543f93d53f6e97c3c4e03502bfbd

commit 8524d4afab4f543f93d53f6e97c3c4e03502bfbd
Author: dpranke <dpranke@chromium.org>
Date: Wed Jul 13 16:19:11 2016

Flip main remaining Win builders to GN.

Specifically:

- chromium
  - Win
- chromium.perf
  - Win Builder
- official.desktop
  - win
  - win64
- official.desktop.continuous
  - win trunk

There are still various FYI and memory builders on GYP, as well as
the GYP builders on the chromium.win waterfall.

R=brucedawson@chromium.org, brettw@chromium.org
BUG= 623659 

Review-Url: https://codereview.chromium.org/2139833002
Cr-Commit-Position: refs/heads/master@{#405178}

[modify] https://crrev.com/8524d4afab4f543f93d53f6e97c3c4e03502bfbd/tools/mb/mb_config.pyl

Project Member

Comment 12 by bugdroid1@chromium.org, Jul 13 2016

Labels: merge-merged-2795
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8524d4afab4f543f93d53f6e97c3c4e03502bfbd

commit 8524d4afab4f543f93d53f6e97c3c4e03502bfbd
Author: dpranke <dpranke@chromium.org>
Date: Wed Jul 13 16:19:11 2016

Flip main remaining Win builders to GN.

Specifically:

- chromium
  - Win
- chromium.perf
  - Win Builder
- official.desktop
  - win
  - win64
- official.desktop.continuous
  - win trunk

There are still various FYI and memory builders on GYP, as well as
the GYP builders on the chromium.win waterfall.

R=brucedawson@chromium.org, brettw@chromium.org
BUG= 623659 

Review-Url: https://codereview.chromium.org/2139833002
Cr-Commit-Position: refs/heads/master@{#405178}

[modify] https://crrev.com/8524d4afab4f543f93d53f6e97c3c4e03502bfbd/tools/mb/mb_config.pyl

Project Member

Comment 13 by bugdroid1@chromium.org, Jul 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/035316cc9a551e6226c283bb348dc6cc19a27b08

commit 035316cc9a551e6226c283bb348dc6cc19a27b08
Author: dpranke <dpranke@chromium.org>
Date: Thu Jul 14 01:23:57 2016

Revert of Flip main remaining Win builders to GN. (patchset #3 id:40001 of https://codereview.chromium.org/2139833002/ )

Reason for revert:
Build failures on the win and win64 official builders :(

See  crbug.com/628056  and  crbug.com/628055 

Original issue's description:
> Flip main remaining Win builders to GN.
>
> Specifically:
>
> - chromium
>   - Win
> - chromium.perf
>   - Win Builder
> - official.desktop
>   - win
>   - win64
> - official.desktop.continuous
>   - win trunk
>
> There are still various FYI and memory builders on GYP, as well as
> the GYP builders on the chromium.win waterfall.
>
> R=brucedawson@chromium.org, brettw@chromium.org
> BUG= 623659 
>
> Committed: https://crrev.com/8524d4afab4f543f93d53f6e97c3c4e03502bfbd
> Cr-Commit-Position: refs/heads/master@{#405178}

TBR=brettw@chromium.org,brucedawson@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 623659 

Review-Url: https://codereview.chromium.org/2144173002
Cr-Commit-Position: refs/heads/master@{#405386}

[modify] https://crrev.com/035316cc9a551e6226c283bb348dc6cc19a27b08/tools/mb/mb_config.pyl

Labels: -Pri-2 Pri-1
Project Member

Comment 15 by bugdroid1@chromium.org, Jul 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b52a97e191717c23f45eee11b13d565b88a5811

commit 1b52a97e191717c23f45eee11b13d565b88a5811
Author: dpranke <dpranke@chromium.org>
Date: Tue Jul 19 17:11:48 2016

Try again to flip Win x86, x64 official builders to GN.

R=sebmarchand@chromium.org, brucedawson@chromium.org, brettw@chromium.org
BUG= 623659 

Review-Url: https://codereview.chromium.org/2154343004
Cr-Commit-Position: refs/heads/master@{#406299}

[modify] https://crrev.com/1b52a97e191717c23f45eee11b13d565b88a5811/tools/mb/mb_config.pyl

Project Member

Comment 16 by bugdroid1@chromium.org, Jul 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/203dd1dd1cd691b16d12a8bae541fcc75456b36e

commit 203dd1dd1cd691b16d12a8bae541fcc75456b36e
Author: dpranke <dpranke@chromium.org>
Date: Tue Jul 19 19:23:37 2016

Flip Win x86 builder on chromium waterfall to GN.

I missed this when flipping the official builders to GN in r406299.

TBR=brettw@chromium.org
BUG= 623659 

Review-Url: https://codereview.chromium.org/2166493002
Cr-Commit-Position: refs/heads/master@{#406346}

[modify] https://crrev.com/203dd1dd1cd691b16d12a8bae541fcc75456b36e/tools/mb/mb_config.pyl

Status: Started (was: Assigned)
The builders have been flipped, just waiting for the official bots to cycle through ...
Blockedon: 629709
the continuous builders worked, but the actual official builders didn't :(.

Links in bug 629709.
Project Member

Comment 19 by bugdroid1@chromium.org, Jul 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a2eee27b750a28b4321e83e7c7b4730f22fa61d

commit 1a2eee27b750a28b4321e83e7c7b4730f22fa61d
Author: dpranke <dpranke@chromium.org>
Date: Wed Jul 20 01:16:55 2016

Revert of Try again to flip Win x86, x64 official builders to GN. (patchset #1 id:1 of https://codereview.chromium.org/2154343004/ )

Reason for revert:
More official build failures. See the bug for logs.

Original issue's description:
> Try again to flip Win x86, x64 official builders to GN.
>
> R=sebmarchand@chromium.org, brucedawson@chromium.org, brettw@chromium.org
> BUG= 623659 
>
> Committed: https://crrev.com/1b52a97e191717c23f45eee11b13d565b88a5811
> Cr-Commit-Position: refs/heads/master@{#406299}

TBR=brettw@chromium.org,brucedawson@chromium.org,sebmarchand@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 623659 

Review-Url: https://codereview.chromium.org/2161353002
Cr-Commit-Position: refs/heads/master@{#406439}

[modify] https://crrev.com/1a2eee27b750a28b4321e83e7c7b4730f22fa61d/tools/mb/mb_config.pyl

Blockedon: 624478
624478 is blocking this I think. We have an issue on the official x86 build because $root_out_dir/nacl_win64/nacl64.exe.pdb doesn't automatically get copied to %root_out_dir with $root_out_dir/nacl_win64/nacl64.exe.
Project Member

Comment 21 by bugdroid1@chromium.org, Jul 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a25f5add3515acdd6db3da3d916670e5add63ac

commit 7a25f5add3515acdd6db3da3d916670e5add63ac
Author: dpranke <dpranke@chromium.org>
Date: Tue Jul 26 18:40:05 2016

Change FYI win clang builders from official to official_optimize.

This changes the config settings for the builders so that they don't
need to pull internal files.

TBR=thakis@chromium.org, hans@chromium.org, tikuta@chromium.org
NOTRY=true
BUG= 623659 , 630095

Review-Url: https://codereview.chromium.org/2176113005
Cr-Commit-Position: refs/heads/master@{#407862}

[modify] https://crrev.com/7a25f5add3515acdd6db3da3d916670e5add63ac/tools/mb/mb_config.pyl

Project Member

Comment 22 by bugdroid1@chromium.org, Jul 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e28fd5d84cebeb446e2c35cf6b766e35aa56ec5f

commit e28fd5d84cebeb446e2c35cf6b766e35aa56ec5f
Author: dpranke <dpranke@chromium.org>
Date: Thu Jul 28 02:41:15 2016

Try again to flip official win builders to GN.

We believe we've fixed the remaining known issues w/ the upload/
signing scripts, so it's time to try again. This affects:

- chromium.perf
  - Win Builder
- official.desktop
  - win
  - win64
- official.desktop.continuous
  - win beta
  - win stable
  - win trunk
  - win64 trunk

(Though the beta and stable builders aren't actually affected and
won't be until they are on M54).

TBR=sebmarchand@chromium.org, brettw@chromium.org, brucedawson@chromium.org
BUG= 623659 

Review-Url: https://codereview.chromium.org/2187613004
Cr-Commit-Position: refs/heads/master@{#408318}

[modify] https://crrev.com/e28fd5d84cebeb446e2c35cf6b766e35aa56ec5f/tools/mb/mb_config.pyl

Project Member

Comment 23 by bugdroid1@chromium.org, Jul 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f83cc2371fb48bd29fa4f231842909d111756e2f

commit f83cc2371fb48bd29fa4f231842909d111756e2f
Author: dpranke <dpranke@chromium.org>
Date: Thu Jul 28 17:24:32 2016

Flip SyzyASAN builders to GN.

This affects the following builders:

- chromium.lkgr
  - Chromium Win SyzyASAN
- official.desktop
  - win-asan
- tryserver.chromium.win
  - win_chromium_syzyasan_rel

R=sebmarchand@chromium.org
BUG= 605318 ,  623659 

Review-Url: https://codereview.chromium.org/2178393003
Cr-Commit-Position: refs/heads/master@{#408412}

[modify] https://crrev.com/f83cc2371fb48bd29fa4f231842909d111756e2f/tools/mb/mb_config.pyl

Project Member

Comment 24 by bugdroid1@chromium.org, Jul 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3e2b1748049154f9d7ee440e5ffbc7f072688db

commit b3e2b1748049154f9d7ee440e5ffbc7f072688db
Author: dpranke <dpranke@chromium.org>
Date: Fri Jul 29 17:34:52 2016

Revert "Try again to flip official win builders to GN."

It looks like the syzygy build is still incorrect :(.

TBR=sebmarchand@chromium.org
BUG=632566,  623659 

Review-Url: https://codereview.chromium.org/2195713003
Cr-Commit-Position: refs/heads/master@{#408679}

[modify] https://crrev.com/b3e2b1748049154f9d7ee440e5ffbc7f072688db/tools/mb/mb_config.pyl

Project Member

Comment 25 by bugdroid1@chromium.org, Jul 29 2016

Labels: merge-merged-2811
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/981156b66f7933ea786b795a7b7c8c1ff7776841

commit 981156b66f7933ea786b795a7b7c8c1ff7776841
Author: Dirk Pranke <dpranke@chromium.org>
Date: Fri Jul 29 18:29:34 2016

Revert "Try again to flip official win builders to GN."

It looks like the syzygy build is still incorrect :(.

(merge back to branch 2811).

TBR=sebmarchand@chromium.org
BUG=632566,  623659 

Review URL: https://codereview.chromium.org/2189423002 .

Review-Url: https://codereview.chromium.org/2195713003
Cr-Original-Commit-Position: refs/heads/master@{#408679}
Cr-Commit-Position: refs/branch-heads/2811@{#3}
Cr-Branched-From: b19949388aaceb1d0dc2b48ad00b272dd1c72af5-refs/heads/master@{#408553}

[modify] https://crrev.com/981156b66f7933ea786b795a7b7c8c1ff7776841/tools/mb/mb_config.pyl

Project Member

Comment 26 by bugdroid1@chromium.org, Jul 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00b24690630408d352edb0eb825423a71eccecb3

commit 00b24690630408d352edb0eb825423a71eccecb3
Author: dpranke <dpranke@chromium.org>
Date: Fri Jul 29 22:20:29 2016

Try yet again to flip official win builders to GN.

TBR=brettw@chromium.org
NOTRY=true
BUG= 623659 

Review-Url: https://codereview.chromium.org/2192303002
Cr-Commit-Position: refs/heads/master@{#408782}

[modify] https://crrev.com/00b24690630408d352edb0eb825423a71eccecb3/tools/mb/mb_config.pyl

Status: Fixed (was: Started)
Project Member

Comment 28 by bugdroid1@chromium.org, Aug 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30fbb2688486ee1534b3035c9c89a6003181c2f8

commit 30fbb2688486ee1534b3035c9c89a6003181c2f8
Author: tapted <tapted@chromium.org>
Date: Mon Aug 01 00:44:54 2016

Revert of Try yet again to flip official win builders to GN. (patchset #2 id:20001 of https://codereview.chromium.org/2192303002/ )

Reason for revert:
All the NaCl tests are crashing with "Actual: "Plugin crashed. 'NaCl module crashed" since
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/55504

This seems to be the most likely cause :(

There's also an outstanding issue with win-pgo (see BUG=)

BUG=632864

Original issue's description:
> Try yet again to flip official win builders to GN.
>
> TBR=brettw@chromium.org
> NOTRY=true
> BUG= 623659 
>
> Committed: https://crrev.com/00b24690630408d352edb0eb825423a71eccecb3
> Cr-Commit-Position: refs/heads/master@{#408782}

TBR=brettw@chromium.org,dpranke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 623659 
NOTRY=true

Review-Url: https://codereview.chromium.org/2196993002
Cr-Commit-Position: refs/heads/master@{#408896}

[modify] https://crrev.com/30fbb2688486ee1534b3035c9c89a6003181c2f8/tools/mb/mb_config.pyl

Project Member

Comment 29 by bugdroid1@chromium.org, Aug 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f3efb0d272ede1c6df075935a32fb3eba06dc13

commit 3f3efb0d272ede1c6df075935a32fb3eba06dc13
Author: tapted <tapted@chromium.org>
Date: Mon Aug 01 01:27:11 2016

Reland of Try yet again to flip official win builders to GN. (patchset #1 id:1 of https://codereview.chromium.org/2196993002/ )

Reason for revert:
Didn't help - NaCl still crashing.

Original issue's description:
> Revert of Try yet again to flip official win builders to GN. (patchset #2 id:20001 of https://codereview.chromium.org/2192303002/ )
>
> Reason for revert:
> All the NaCl tests are crashing with "Actual: "Plugin crashed. 'NaCl module crashed" since
> https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/55504
>
> This seems to be the most likely cause :(
>
> There's also an outstanding issue with win-pgo (see BUG=)
>
> BUG=632864
>
> Original issue's description:
> > Try yet again to flip official win builders to GN.
> >
> > TBR=brettw@chromium.org
> > NOTRY=true
> > BUG= 623659 
> >
> > Committed: https://crrev.com/00b24690630408d352edb0eb825423a71eccecb3
> > Cr-Commit-Position: refs/heads/master@{#408782}
>
> TBR=brettw@chromium.org,dpranke@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG= 623659 
> NOTRY=true
>
> Committed: https://crrev.com/30fbb2688486ee1534b3035c9c89a6003181c2f8
> Cr-Commit-Position: refs/heads/master@{#408896}

TBR=brettw@chromium.org,dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=632864

Review-Url: https://codereview.chromium.org/2192393003
Cr-Commit-Position: refs/heads/master@{#408897}

[modify] https://crrev.com/3f3efb0d272ede1c6df075935a32fb3eba06dc13/tools/mb/mb_config.pyl

Project Member

Comment 30 by bugdroid1@chromium.org, Aug 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c83a1c10a6be07c4e05536bccc4b209a696d0b47

commit c83a1c10a6be07c4e05536bccc4b209a696d0b47
Author: thakis <thakis@chromium.org>
Date: Mon Aug 01 18:15:18 2016

Revert of Change FYI win clang builders from official to official_optimize. (patchset #1 id:1 of https://codereview.chromium.org/2176113005/ )

Do keep the change for CrWinClangGoma, since that bot doesn't run tests.

Reason for revert:
This was landed without review or motivation and breaks tests on these bots.

Original issue's description:
> Change FYI win clang builders from official to official_optimize.
>
> This changes the config settings for the builders so that they don't
> need to pull internal files.
>
> TBR=thakis@chromium.org, hans@chromium.org, tikuta@chromium.org
> NOTRY=true
> BUG= 623659 , 630095
>
> Committed: https://crrev.com/7a25f5add3515acdd6db3da3d916670e5add63ac
> Cr-Commit-Position: refs/heads/master@{#407862}

TBR=hans@chromium.org,tikuta@chromium.org,dpranke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 623659 , 630095

Review-Url: https://codereview.chromium.org/2198153002
Cr-Commit-Position: refs/heads/master@{#409000}

[modify] https://crrev.com/c83a1c10a6be07c4e05536bccc4b209a696d0b47/tools/mb/mb_config.pyl

Sign in to add a comment