New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 623646 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 464797



Sign in to add a comment

roll clang past r273760

Project Member Reported by p...@chromium.org, Jun 27 2016

Issue description

Commits r273756, r273757, r273758, r273760 were the final pieces of the changes required for CFI to work with whole-program virtual call optimization. We should roll past them in order to unblock the CFI launch.
 

Comment 1 by h...@chromium.org, Jun 27 2016

Nico's currently pushing a roll in  crbug.com/621972 , but the target so far is r273743.

I suppose if that lands it'll be easy to target r273760, otherwise we can try going straight for r273760.

Comment 2 by thakis@chromium.org, Jun 27 2016

Have at it :-)_ I just rolled to 273743 a little over an hour ago ( bug 621972  comment 20), so hopefully things haven't fallen apart since then too much.

Comment 3 by p...@chromium.org, Jun 27 2016

Owner: p...@chromium.org
Okay, I'll take this one.

Comment 5 by p...@chromium.org, Jun 28 2016

The linux_chromium_chromeos_dbg_ng trybot is failing like this:

browser_tests (with patch) on Ubuntu-12.04 browser_tests (with patch) on Ubuntu-12.04 727 disabled 19 flaky failed 1 
failures:
KioskEnterpriseTest.PrivateStore

It's failed the same way 3 times in a row, so I don't think it's a flaky test.

Taking a closer look.

Comment 6 by thakis@chromium.org, Jun 28 2016

If you click on the bot and look at builds not belonging to your cl, does it pass there?

Comment 7 by p...@chromium.org, Jun 28 2016

https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_dbg_ng

My builds were 841, 843 and 846, and it does appear to be passing on the other build in that range that got as far as running the tests (i.e. 842).

Comment 8 by p...@chromium.org, Jun 29 2016

Looks like this has nothing to do with my change. There's a regular bot failing in the same way.

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/15672
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/15675

Also was unable to reproduce any regression locally (i.e. it failed before and after). Proceeding to mail my CL.
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/374dfa5eca34667ec6ed11c1984ce822af5838ce

commit 374dfa5eca34667ec6ed11c1984ce822af5838ce
Author: pcc <pcc@chromium.org>
Date: Wed Jun 29 05:15:42 2016

Roll clang 273743:273760.

Ran `tools/clang/scripts/upload_revision.py 273760`.

BUG= 623646 

Review-Url: https://codereview.chromium.org/2097423003
Cr-Commit-Position: refs/heads/master@{#402733}

[modify] https://crrev.com/374dfa5eca34667ec6ed11c1984ce822af5838ce/tools/clang/scripts/update.py

Comment 10 by h...@chromium.org, Jul 20 2016

Status: Fixed (was: Untriaged)

Sign in to add a comment