New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 623638 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature



Sign in to add a comment

Use Nearby Messages API in the Physical Web in chrome/ directory

Project Member Reported by cco3@chromium.org, Jun 27 2016

Issue description

The Physical Web feature can take advantage of the Nearby API, so let's use that directly in the chrome/ directory.
 

Comment 1 by cco3@chromium.org, Jun 27 2016

Labels: -Type-Bug Type-Feature
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/android_tools/+/b051811088c576c4ac29579d7e8aacc42173f250

commit b051811088c576c4ac29579d7e8aacc42173f250
Author: Conley Owens <cco3@chromium.org>
Date: Wed Jul 20 23:05:26 2016

Add Nearby Messages API to proguard config

The Physical Web feature of Chrome can take advantage of the Nearby
API, so we need to keep proguard from removing it.

BUG= 623638 

Change-Id: I6e9d736d5b36396762aec3415a56149a0137647f
Reviewed-on: https://chromium-review.googlesource.com/356196
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Tested-by: Ross McIlroy <rmcilroy@chromium.org>

[modify] https://crrev.com/b051811088c576c4ac29579d7e8aacc42173f250/proguard.flags

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 26 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/cfd9b08407a229cd9b2932a510c8039fe741c675

commit cfd9b08407a229cd9b2932a510c8039fe741c675
Author: Conley Owens <cco3@google.com>
Date: Tue Jul 26 17:21:11 2016

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 26 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/4871c839feaa638baa012845fa3b5d4d4fdf2fe5

commit 4871c839feaa638baa012845fa3b5d4d4fdf2fe5
Author: Conley Owens <cco3@google.com>
Date: Tue Jul 26 22:00:53 2016

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ea6156fc386b92dfbc42847d77add3bffc7b0cd

commit 7ea6156fc386b92dfbc42847d77add3bffc7b0cd
Author: cco3 <cco3@chromium.org>
Date: Wed Jul 27 22:26:51 2016

Use Nearby to background scan for URLs

This change initiates a background scan through Nearby on startup so
that the Physical Web feature can surface URLs.

BUG= 623638 

Review-Url: https://codereview.chromium.org/2176373007
Cr-Commit-Position: refs/heads/master@{#408253}

[modify] https://crrev.com/7ea6156fc386b92dfbc42847d77add3bffc7b0cd/chrome/android/java/AndroidManifest.xml
[add] https://crrev.com/7ea6156fc386b92dfbc42847d77add3bffc7b0cd/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/NearbyBackgroundSubscription.java
[add] https://crrev.com/7ea6156fc386b92dfbc42847d77add3bffc7b0cd/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/NearbyMessageIntentService.java
[modify] https://crrev.com/7ea6156fc386b92dfbc42847d77add3bffc7b0cd/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/NearbySubscription.java
[modify] https://crrev.com/7ea6156fc386b92dfbc42847d77add3bffc7b0cd/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java
[modify] https://crrev.com/7ea6156fc386b92dfbc42847d77add3bffc7b0cd/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBleClient.java
[modify] https://crrev.com/7ea6156fc386b92dfbc42847d77add3bffc7b0cd/chrome/android/java_sources.gni

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 27 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/d2869f17835646a43f272fc1589248a7910b0bbc

commit d2869f17835646a43f272fc1589248a7910b0bbc
Author: Conley Owens <cco3@google.com>
Date: Tue Jul 26 23:31:15 2016

Project Member

Comment 8 by bugdroid1@chromium.org, Sep 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ba6f35cd7bd0329af5da8e8c451e408bfcc60b0

commit 8ba6f35cd7bd0329af5da8e8c451e408bfcc60b0
Author: cco3 <cco3@chromium.org>
Date: Thu Sep 08 21:55:48 2016

Run Physical Web background subscription

In the transition to use a new class for subscriptions, the background
subscription got dropped because it wasn't actually run.  This change
actually performs the subscription.

BUG= 623638 , 645182 

Review-Url: https://codereview.chromium.org/2316413002
Cr-Commit-Position: refs/heads/master@{#417410}

[modify] https://crrev.com/8ba6f35cd7bd0329af5da8e8c451e408bfcc60b0/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java

Project Member

Comment 9 by bugdroid1@chromium.org, Sep 9 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f0fbae251307c486c4df305e68798c002842ca0

commit 9f0fbae251307c486c4df305e68798c002842ca0
Author: cco3 <cco3@chromium.org>
Date: Fri Sep 09 21:05:41 2016

Run Physical Web background subscription

In the transition to use a new class for subscriptions, the background
subscription got dropped because it wasn't actually run.  This change
actually performs the subscription.

BUG= 623638 , 645182 
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2316413002
Cr-Commit-Position: refs/heads/master@{#417410}
(cherry picked from commit 8ba6f35cd7bd0329af5da8e8c451e408bfcc60b0)

Review-Url: https://codereview.chromium.org/2328803002
Cr-Commit-Position: refs/branch-heads/2840@{#282}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/9f0fbae251307c486c4df305e68798c002842ca0/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java

Comment 10 Deleted

Project Member

Comment 11 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f0fbae251307c486c4df305e68798c002842ca0

commit 9f0fbae251307c486c4df305e68798c002842ca0
Author: cco3 <cco3@chromium.org>
Date: Fri Sep 09 21:05:41 2016

Run Physical Web background subscription

In the transition to use a new class for subscriptions, the background
subscription got dropped because it wasn't actually run.  This change
actually performs the subscription.

BUG= 623638 , 645182 
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2316413002
Cr-Commit-Position: refs/heads/master@{#417410}
(cherry picked from commit 8ba6f35cd7bd0329af5da8e8c451e408bfcc60b0)

Review-Url: https://codereview.chromium.org/2328803002
Cr-Commit-Position: refs/branch-heads/2840@{#282}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/9f0fbae251307c486c4df305e68798c002842ca0/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java

Conley: Is there more work to be done here?

Comment 13 by cco3@chromium.org, Jan 9 2017

Status: Fixed (was: Started)
We've moved everything we can at this point.  We can close this.

Sign in to add a comment