"Press [Esc] to exit fullscreen" bubble should match actual "esc" key on Mac |
|||
Issue descriptionM52beta, OSX 10.11.x The new "Press [Esc] to exit fullscreen" bubble doesn't look like the actual key on mac. It's lowercase, not uppercase. The text/images should read "[esc]" to match the Apple-style naming on the keyboard. It looks really out of place to me every time I see it.
,
Jun 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d54ff1f2aa0ac5bf75f5489b3bbb3d9689c014d commit 8d54ff1f2aa0ac5bf75f5489b3bbb3d9689c014d Author: tapted <tapted@chromium.org> Date: Thu Jun 30 00:36:12 2016 Mac: Use "esc" rather than "Esc" in "Press Esc to exit full screen". Mac keyboards use lowercase for everything except function keys, which are typically reserved for system use. Since |Esc| is placed in a box specifically to make it look like a keyboard key it looks weird to not follow suit. Use base::i18n::ToLower(..) rather than changing IDS_APP_ESC_KEY, since the latter is used by ui::Accelerator::GetShortcutText() for other things. This still isn't perfect. Some macbooks use the ISO symbol for escape, "⎋" (e.g. French Canadian). But we can't assume a user's locale setting always determines how the keyboard looks. Using lowercase gets us pretty close. BUG= 623636 Review-Url: https://codereview.chromium.org/2110743002 Cr-Commit-Position: refs/heads/master@{#403035} [modify] https://crrev.com/8d54ff1f2aa0ac5bf75f5489b3bbb3d9689c014d/chrome/browser/ui/views/exclusive_access_bubble_views.cc
,
Jun 30 2016
,
Jul 7 2016
Tested the issue on Mac 10.11.5 using chrome version 53.0.2785.8.Observed the text as"Press esc to exit full screen" in full screen bubble. Please find the attached screen shot for the same. Adding TE-Verified label. Thanks, |
|||
►
Sign in to add a comment |
|||
Comment 1 by tapted@chromium.org
, Jun 29 2016