eth0 of the moblab could change |
|||||||
Issue descriptionSome moblab code assumes "eth0" is the moblab public port (like in client/common_lib/site_utils.py). However, sometimes, eth0 (direct cable network) and eth1 (USB dongle network) assignment could be swapped. Not a critical issue so far. But for consistency, we should eithe enforce this at upstart init time, or not assume the default assignment always hold.
,
Jun 28 2016
,
Sep 19 2016
,
Dec 12 2016
I am going to add a check on the usb network interface.
,
Dec 14 2016
,
Dec 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/7b549fa6c193531a43f7a173840bfd8e8e6823d5 commit 7b549fa6c193531a43f7a173840bfd8e8e6823d5 Author: Michael Tang <ntang@google.com> Date: Tue Dec 13 07:49:06 2016 Use the moblab public network interface's mac address as identity. BUG= chromium:623632 TEST=unittest. Change-Id: Ib46c5c53bfd5c719b01b55ceefbe275dc4b48cb2 Reviewed-on: https://chromium-review.googlesource.com/418869 Commit-Ready: Michael Tang <ntang@chromium.org> Tested-by: Michael Tang <ntang@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> Reviewed-by: Michael Tang <ntang@chromium.org> [modify] https://crrev.com/7b549fa6c193531a43f7a173840bfd8e8e6823d5/client/common_lib/site_utils_unittest.py [modify] https://crrev.com/7b549fa6c193531a43f7a173840bfd8e8e6823d5/client/common_lib/site_utils.py
,
Dec 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/bf4c10fb83658400ba5a4fd8b71a80c8dd062c1d commit bf4c10fb83658400ba5a4fd8b71a80c8dd062c1d Author: Michael Tang <ntang@google.com> Date: Tue Dec 13 07:49:06 2016 Use the moblab public network interface's mac address as identity. BUG= chromium:623632 TEST=unittest. Change-Id: Ib46c5c53bfd5c719b01b55ceefbe275dc4b48cb2 Reviewed-on: https://chromium-review.googlesource.com/418869 Commit-Ready: Michael Tang <ntang@chromium.org> Tested-by: Michael Tang <ntang@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> Reviewed-by: Michael Tang <ntang@chromium.org> (cherry picked from commit 7b549fa6c193531a43f7a173840bfd8e8e6823d5) Reviewed-on: https://chromium-review.googlesource.com/423107 Reviewed-by: Mohan Konduri <krk@chromium.org> Commit-Queue: Michael Tang <ntang@chromium.org> Trybot-Ready: Michael Tang <ntang@chromium.org> [modify] https://crrev.com/bf4c10fb83658400ba5a4fd8b71a80c8dd062c1d/client/common_lib/site_utils_unittest.py [modify] https://crrev.com/bf4c10fb83658400ba5a4fd8b71a80c8dd062c1d/client/common_lib/site_utils.py
,
Feb 23 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by sbasi@chromium.org
, Jun 27 2016