Issue 623624 link

Starred by 2 users

Issue metadata

Status:	Archived
Owner:	█ kenobi@chromium.org Last visit > 30 days ago
Closed:	Jun 2016
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	1
Type:	Bug
VerifyIn-54 VerifyIn-55 VerifyIn-56 VerifyIn-57 VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

[Options] Fix Android settings visibility

Project Member Reported by kenobi@chromium.org, Jun 27 2016

Issue description

1) Open chrome settings, look for "Android apps"
2) Check the "Enable Android apps" box.  Go through play-store flow.
3) Observe that a new subsection appears, to enable managing android apps ("Manage your Android apps in Settings")
4) Uncheck the "Enable Android apps" checkbox.  When the confirmation dialog appears, click "Cancel".
5) Observe that "Enable Android apps" is still checked, but the "Manage..." section has gone back to being hidden.  It should still be visible.

Project Member

Comment 1 by bugdroid1@chromium.org, Jun 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbdaaa80891607e7f1d3b5cca63636541d716b00

commit bbdaaa80891607e7f1d3b5cca63636541d716b00
Author: kenobi <kenobi@chromium.org>
Date: Thu Jun 30 03:45:28 2016

Options: Fix android app settings visibility.

Only fiddle with the visibility of the setting when an actual change is
committed in preferences.  This avoids problems arising from linking it
to intermediate UI state.

BUG= 623624 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2100803004
Cr-Commit-Position: refs/heads/master@{#403080}

[modify] https://crrev.com/bbdaaa80891607e7f1d3b5cca63636541d716b00/chrome/browser/resources/options/browser_options.js