New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 623619 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Enrollment on chrome with chromeos=1 build fails.

Project Member Reported by pbond@chromium.org, Jun 27 2016

Issue description

Version: the latest chromium master (refs/heads/master@{#402159}),
the problem is appeared after https://codereview.chromium.org/2067843003

OS: Linux

What steps will reproduce the problem?
(1) Build chrome with chromeos=1
(2) ./chrome --user-data-dir=/tmp/$RANDOM-$RANDOM --login-manager --login-profile=user --enterprise-enrollment-skip-robot-auth --disable-policy-key-verification
(3) Enroll to @managedchrome.com account.

What is the expected output?
Successfully enrolled.

What do you see instead?
Crash with error:

[807:875:0627/192044:FATAL:ssl_client_socket_impl.cc(521)] Check failed: cert_transparency_verifier_. 
#0 0x7f63b9cf709e base::debug::StackTrace::StackTrace()
#1 0x7f63b9d3257c logging::LogMessage::~LogMessage()
#2 0x7f63ba1d259f net::SSLClientSocketImpl::SSLClientSocketImpl()
#3 0x7f63ba4f3c0a net::(anonymous namespace)::DefaultClientSocketFactory::CreateSSLClientSocket()
#4 0x7f63bf200561 jingle_glue::XmppClientSocketFactory::CreateSSLClientSocket()
#5 0x7f63bf1fe0f8 jingle_glue::ChromeAsyncSocket::StartTls()
#6 0x7f63bf1d7973 buzz::XmppClient::Private::StartTls()
#7 0x7f63bf1dd837 buzz::XmppEngineImpl::StartTls()
#8 0x7f63bf1e5f70 buzz::XmppLoginTask::Advance()
#9 0x7f63bf1e5a77 buzz::XmppLoginTask::IncomingStanza()
#10 0x7f63bf1dd187 buzz::XmppEngineImpl::IncomingStanza()
#11 0x7f63bf1def61 buzz::XmppEngineImpl::StanzaParseHandler::Stanza()
#12 0x7f63bf1e7b41 buzz::XmppStanzaParser::IncomingEndElement()
#13 0x7f63bf1e7c79 buzz::XmppStanzaParser::ParseHandler::EndElement()
#14 0x7f63bc608dd8 buzz::XmlParser::ExpatEndElement()
#15 0x7f63bc608828 buzz::EndElementCallback()
#16 0x7f63acd806d4 <unknown>
#17 0x7f63acd8167e <unknown>
#18 0x7f63acd8360f XML_ParseBuffer
#19 0x7f63bc6090d9 buzz::XmlParser::Parse()
#20 0x7f63bf1de133 buzz::XmppStanzaParser::Parse()
#21 0x7f63bf1dc5c5 buzz::XmppEngineImpl::HandleInput()
#22 0x7f63bf1d61a2 buzz::XmppClient::Private::OnSocketRead()
#23 0x7f63b452fe75 sigslot::_connection0<>::emit()
#24 0x7f63b45f92ce sigslot::signal0<>::operator()()
#25 0x7f63bf1fc756 jingle_glue::ChromeAsyncSocket::ProcessReadDone()
#26 0x7f63b1d0eb45 _ZNK4base8internal15RunnableAdapterIMN11google_apis19UrlFetchRequestBaseEFvNS2_17DriveApiErrorCodeEEE3RunIRKNS_7WeakPtrIS3_EEJRKS4_EEEvOT_DpOT0_
#27 0x7f63bf1ff28d _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKNS0_15RunnableAdapterIMN11jingle_glue17ChromeAsyncSocketEFviEEERKNS_7WeakPtrIS6_EEJiEEEvOT_OT0_DpOT1_
#28 0x7f63bf1ff226 _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0EEEENS0_9BindStateINS0_15RunnableAdapterIMN11jingle_glue17ChromeAsyncSocketEFviEEEFvPS7_iEJNS_7WeakPtrIS7_EEEEELb1EFviEE3RunEPNS0_13BindStateBaseEOi
#29 0x7f63b1a600a2 base::Callback<>::Run()
#30 0x7f63ba514be5 net::TCPClientSocket::DidCompleteReadWrite()
#31 0x7f63ba51474b net::TCPClientSocket::DidCompleteRead()
#32 0x7f63b3767f30 _ZNK4base8internal15RunnableAdapterIMN7content34PepperTCPServerSocketMessageFilterEFvRKN5ppapi4host19ReplyMessageContextEiEE3RunIPS3_JS8_iEEEvOT_DpOT0_
#33 0x7f63b3767e5c _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKNS0_15RunnableAdapterIMN7content34PepperTCPServerSocketMessageFilterEFvRKN5ppapi4host19ReplyMessageContextEiEEEJPS6_SB_iEEEvOT_DpOT0_
#34 0x7f63ba5151f6 _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0ELm1EEEENS0_9BindStateINS0_15RunnableAdapterIMN3net15TCPClientSocketEFvRKNS_8CallbackIFviELNS0_8CopyModeE1EEEiEEEFvPS7_SD_iEJNS0_17UnretainedWrapperIS7_EESD_EEELb0ES9_E3RunEPNS0_13BindStateBaseEOi
#35 0x7f63b1a600a2 base::Callback<>::Run()
#36 0x7f63ba517b5f net::TCPSocketPosix::ReadCompleted()
#37 0x7f63b5e90ce5 _ZNK4base8internal15RunnableAdapterIMN8remoting8protocol23PseudoTcpChannelFactoryEFvRKSsRKNS_8CallbackIFvSt10unique_ptrINS3_15P2PStreamSocketESt14default_deleteIS9_EEELNS0_8CopyModeE1EEEiEE3RunIPS4_JS6_SH_iEEEvOT_DpOT0_
#38 0x7f63b5e90c21 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKNS0_15RunnableAdapterIMN8remoting8protocol23PseudoTcpChannelFactoryEFvRKSsRKNS_8CallbackIFvSt10unique_ptrINS6_15P2PStreamSocketESt14default_deleteISC_EEELNS0_8CopyModeE1EEEiEEEJPS7_S9_SK_iEEEvOT_DpOT0_
#39 0x7f63ba51b3c6 _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0ELm1ELm2EEEENS0_9BindStateINS0_15RunnableAdapterIMN3net14TCPSocketPosixEFvRK13scoped_refptrINS6_8IOBufferEERKNS_8CallbackIFviELNS0_8CopyModeE1EEEiEEEFvPS7_SC_SI_iEJNS0_17UnretainedWrapperIS7_EESA_SI_EEELb0ESE_E3RunEPNS0_13BindStateBaseEOi
#40 0x7f63b1a600a2 base::Callback<>::Run()
#41 0x7f63ba79bb12 net::SocketPosix::ReadCompleted()
#42 0x7f63ba79b6d9 net::SocketPosix::OnFileCanReadWithoutBlocking()
#43 0x7f63b9d5c581 base::MessagePumpLibevent::FileDescriptorWatcher::OnFileCanReadWithoutBlocking()
#44 0x7f63b9d5d89f base::MessagePumpLibevent::OnLibeventNotification()
#45 0x7f63b1af363e event_process_active
#46 0x7f63b1af2c87 event_base_loop
#47 0x7f63b9d5db70 base::MessagePumpLibevent::Run()
#48 0x7f63b9d4721a base::MessageLoop::RunHandler()
#49 0x7f63b9dc04f4 base::RunLoop::Run()
#50 0x7f63b9d463c1 base::MessageLoop::Run()
#51 0x7f63b9e1bb49 base::Thread::Run()
#52 0x7f63b2c8e7d8 content::BrowserThreadImpl::IOThreadRun()
#53 0x7f63b2c8eb11 content::BrowserThreadImpl::Run()
#54 0x7f63b9e1be61 base::Thread::ThreadMain()
#55 0x7f63b9e0b4ba base::(anonymous namespace)::ThreadFunc()
#56 0x7f63ab32b184 start_thread
#57 0x7f63ab05837d clone
 
Cc: sergeyu@chromium.org
Owner: rsleevi@chromium.org
Status: Started (was: Untriaged)
Sergey: Is there a more specific component for this jingle glue? How it's using a URLRequestContext is pretty dangerous and, judging by the code, has at least two bugs.

I'm going to fix the low-hanging fruit of the CHECK failure, but we'll have to figure out a better component long-term.
Components: Services>Sync
This looks related to Sync, but I'm not sure why it still uses XMPP
Components: Services>CloudPrint
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0364ad9c02e4d0374ef6daebcd24e79cb10d7fd4

commit 0364ad9c02e4d0374ef6daebcd24e79cb10d7fd4
Author: rsleevi <rsleevi@chromium.org>
Date: Mon Jun 27 21:17:22 2016

Fixup ChromeOS enrollment and renderer p2p sockets

Both of these codepaths mint new SSL socket pools from
existing URLRequestContexts, which is already buggy
and error prone (improperly handling channel ID and
TLS session caches). However, ensure they also copy
over the Certificate Transparency state, so that the
socket does not crash when it tries to verify the
Certificate Transparency information.

BUG=623463,  623619 

Review-Url: https://codereview.chromium.org/2104493002
Cr-Commit-Position: refs/heads/master@{#402285}

[modify] https://crrev.com/0364ad9c02e4d0374ef6daebcd24e79cb10d7fd4/content/browser/renderer_host/p2p/socket_host_tcp.cc
[modify] https://crrev.com/0364ad9c02e4d0374ef6daebcd24e79cb10d7fd4/jingle/glue/xmpp_client_socket_factory.cc

Status: Fixed (was: Started)

Sign in to add a comment