New issue
Advanced search Search tips

Issue 623613 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocking:
issue 360762
issue 618366



Sign in to add a comment

Builder "WebKit Win - WPTServe" fails to run layout tests due to no "openssl" command

Project Member Reported by qyears...@chromium.org, Jun 27 2016

Issue description

Recent builds:
 https://build.chromium.org/p/chromium.fyi/builders/WebKit%20Win%20-%20WPTServe

Log excerpt:

09:34:52.177 3800 "E:\b\build\slave\WebKit_Win_-_WPTServe\build\src\out\Release\content_shell.exe --check-layout-test-sys-deps" took 0.19s
09:34:52.177 3800 System dependencies check failed.
09:34:52.177 3800 To override, invoke with --nocheck-sys-deps
09:34:52.177 3800 
09:34:52.177 3800 Must use normal size fonts (96 dpi).

Must use either the Aero or Basic theme.
 
Components: Blink>Infra
Labels: -Pri-3 Pri-2
Other possibly-related issues:  bug 621174 , bug   bug 620271 .
Cc: no...@chromium.org
Labels: Infra-Troopers Infra-Labs
 bug 621174  seems likely to be the same issue. Given that this is happening reliably on vm114-m1, this seems like a good machine to start with.
Labels: -Pri-2 Pri-1
Blocking: 621174

Comment 5 by no...@chromium.org, Jun 27 2016

trooper here, talked to dpranke trying to understand what's going on:

> [machine] seems to be configured differently than we expect it to be
> this particular builder is new and has never run a successful build.
> so there may (likely) be something wrong w/ the image, or at least the image is 
> different than what is on many other machines and what we expect

looks like builder owner and labs need to work together to figure out why it does not work as expected

Comment 6 by d...@chromium.org, Jun 27 2016

I swapped the vm to use the 'basic' theme, and now it fails with the following:

14:34:57.848 3268 Using port 'win-win7'
14:34:57.848 3268 Test configuration: <win7, x86, release>
14:34:57.848 3268 View the test results at file://E:\b\build\slave\WebKit_Win_-_WPTServe\build\layout-test-results/results.html
14:34:57.848 3268 View the archived results dashboard at file://E:\b\build\slave\WebKit_Win_-_WPTServe\build\layout-test-results/dashboard.html
14:34:57.848 3268 Baseline search path: win7 -> win -> generic
14:34:57.848 3268 Using Release build
14:34:57.848 3268 Pixel tests enabled
14:34:57.848 3268 Regular timeout: 6000, slow test timeout: 30000
14:34:57.848 3268 Command line: E:\b\build\slave\WebKit_Win_-_WPTServe\build\src\out\Release\content_shell.exe --run-layout-test --enable-direct-write --enable-crash-reporter --crash-dumps-dir=E:\b\build\slave\WebKit_Win_-_WPTServe\build\src\out\Release\crash-dumps -
14:34:57.848 3268 
14:34:57.848 3268 Collecting tests ...
14:35:06.787 3268 Parsing expectations ...
14:35:10.235 3268 Found 47230 tests; running 40883, skipping 6347.
14:35:10.235 3268 Checking build ...
14:35:10.360 3268 
14:35:10.391 3268 Ruby is not installed; can't generate pretty patches.
14:35:10.391 3268 
14:35:10.485 3268 "E:\b\build\slave\WebKit_Win_-_WPTServe\build\src\third_party\cygwin\bin\wdiff.exe --help" took 0.09s
14:35:10.547 3268 "C:\Program Files\Debugging Tools For Windows (x64)\cdb.exe -version" took 0.06s
14:35:10.594 3268 "E:\b\build\slave\WebKit_Win_-_WPTServe\build\src\third_party\apache-win32\bin\httpd.exe -v" took 0.05s
14:35:10.594 3268 Starting pixel test helper ...
14:35:10.594 3268 Checking system dependencies ...
14:35:11.358 3268 "E:\b\build\slave\WebKit_Win_-_WPTServe\build\src\out\Release\content_shell.exe --check-layout-test-sys-deps" took 0.72s
14:35:11.358 3268 Clobbering excess archived results in E:\b\build\slave\WebKit_Win_-_WPTServe\build
14:35:11.358 3268 No results.html file found in previous run, skipping it.
14:35:11.358 3268 all ports are available
14:35:11.358 3268 Starting CrashService server, cmd="['E:\\b\\build\\slave\\WebKit_Win_-_WPTServe\\build\\src\\out\\Release\\content_shell_crash_service.exe', '--dumps-dir=E:\\b\\build\\slave\\WebKit_Win_-_WPTServe\\build\\src\\out\\Release\\crash-dumps', '--no-window']"
14:35:11.389 3268 CrashService successfully started (pid = 1900)
14:35:11.421 3268 Starting WPTServe ...
14:35:11.436 3268 all ports are available
14:35:11.436 3268 Starting wptserve server, cmd="['E:\\b\\depot_tools\\python276_bin\\python.exe', '-u', 'E:\\b\\build\\slave\\WebKit_Win_-_WPTServe\\build\\src\\third_party\\WebKit\\Tools\\Scripts\\webkitpy\\thirdparty\\wpt\\wpt\\serve', '--config', 'E:\\b\\build\\slave\\WebKit_Win_-_WPTServe\\build\\src\\third_party\\WebKit\\Tools\\Scripts\\webkitpy\\thirdparty\\wpt\\wpt.config.json', '--doc_root', 'E:\\b\\build\\slave\\WebKit_Win_-_WPTServe\\build\\src\\third_party\\WebKit\\LayoutTests\\imported\\wpt']"
14:35:12.466 3268 Server NOT running on 8001: [Errno 10061] No connection could be made because the target machine actively refused it
14:35:12.466 3268 Waiting for action: <bound method WPTServe._is_server_running_on_all_ports of <webkitpy.layout_tests.servers.wptserve.WPTServe object at 0x06971B30>>
14:35:14.510 3268 Server NOT running on 8001: [Errno 10061] No connection could be made because the target machine actively refused it
14:35:14.510 3268 Waiting for action: <bound method WPTServe._is_server_running_on_all_ports of <webkitpy.layout_tests.servers.wptserve.WPTServe object at 0x06971B30>>
14:35:16.538 3268 Server NOT running on 8001: [Errno 10061] No connection could be made because the target machine actively refused it
14:35:16.538 3268 Waiting for action: <bound method WPTServe._is_server_running_on_all_ports of <webkitpy.layout_tests.servers.wptserve.WPTServe object at 0x06971B30>>
14:35:18.566 3268 Server NOT running on 8001: [Errno 10061] No connection could be made because the target machine actively refused it
14:35:18.566 3268 Waiting for action: <bound method WPTServe._is_server_running_on_all_ports of <webkitpy.layout_tests.servers.wptserve.WPTServe object at 0x06971B30>>
14:35:20.609 3268 Server NOT running on 8001: [Errno 10061] No connection could be made because the target machine actively refused it
14:35:20.609 3268 Waiting for action: <bound method WPTServe._is_server_running_on_all_ports of <webkitpy.layout_tests.servers.wptserve.WPTServe object at 0x06971B30>>
14:35:22.637 3268 Server NOT running on 8001: [Errno 10061] No connection could be made because the target machine actively refused it
14:35:22.637 3268 Waiting for action: <bound method WPTServe._is_server_running_on_all_ports of <webkitpy.layout_tests.servers.wptserve.WPTServe object at 0x06971B30>>
14:35:24.681 3268 Server NOT running on 8001: [Errno 10061] No connection could be made because the target machine actively refused it
14:35:24.681 3268 Waiting for action: <bound method WPTServe._is_server_running_on_all_ports of <webkitpy.layout_tests.servers.wptserve.WPTServe object at 0x06971B30>>
14:35:26.709 3268 Server NOT running on 8001: [Errno 10061] No connection could be made because the target machine actively refused it
14:35:26.709 3268 Waiting for action: <bound method WPTServe._is_server_running_on_all_ports of <webkitpy.layout_tests.servers.wptserve.WPTServe object at 0x06971B30>>
14:35:28.737 3268 Server NOT running on 8001: [Errno 10061] No connection could be made because the target machine actively refused it
14:35:28.737 3268 Waiting for action: <bound method WPTServe._is_server_running_on_all_ports of <webkitpy.layout_tests.servers.wptserve.WPTServe object at 0x06971B30>>
14:35:30.781 3268 Server NOT running on 8001: [Errno 10061] No connection could be made because the target machine actively refused it
14:35:30.781 3268 Waiting for action: <bound method WPTServe._is_server_running_on_all_ports of <webkitpy.layout_tests.servers.wptserve.WPTServe object at 0x06971B30>>
14:35:31.795 3268 logging wptserve errors, if any
14:35:31.795 3268 wptserve returncode None
14:35:31.795 3268 wptserve no stderr handle
14:35:31.795 3268 wptserve no error log
14:35:31.795 3268 Flushing stdout
14:35:31.795 3268 Flushing stderr
14:35:31.795 3268 Stopping helper
14:35:31.795 3268 Cleaning up port
14:35:31.795 3268 Attempting to shut down CrashService server at pid 1900
14:35:31.795 3268 pid 1900 is running, killing it
14:35:32.060 3268 "taskkill.exe /f /t /pid 1900" took 0.26s
14:35:32.060 3268 Waiting for action: <bound method CrashService._check_and_kill of <webkitpy.layout_tests.servers.crash_service.CrashService object at 0x06971C90>>
14:35:33.074 3268 pid 1900 is not running
14:35:33.074 3268 CrashService server at pid 1900 stopped

ServerError raised: Failed to start wptserve server
Traceback (most recent call last):
  File "E:\b\build\slave\WebKit_Win_-_WPTServe\build\src\third_party\WebKit\Tools\Scripts\webkitpy\layout_tests\run_webkit_tests.py", line 69, in main
    return run(port, options, args, stderr, stdout).exit_code
  File "E:\b\build\slave\WebKit_Win_-_WPTServe\build\src\third_party\WebKit\Tools\Scripts\webkitpy\layout_tests\run_webkit_tests.py", line 553, in run
    run_details = _run_tests(port, options, args, printer)
  File "E:\b\build\slave\WebKit_Win_-_WPTServe\build\src\third_party\WebKit\Tools\Scripts\webkitpy\layout_tests\run_webkit_tests.py", line 544, in _run_tests
    return manager.run(args)
  File "E:\b\build\slave\WebKit_Win_-_WPTServe\build\src\third_party\WebKit\Tools\Scripts\webkitpy\layout_tests\controllers\manager.py", line 130, in run
    self._start_servers(tests_to_run)
  File "E:\b\build\slave\WebKit_Win_-_WPTServe\build\src\third_party\WebKit\Tools\Scripts\webkitpy\layout_tests\controllers\manager.py", line 374, in _start_servers
    self._port.start_wptserve()
  File "E:\b\build\slave\WebKit_Win_-_WPTServe\build\src\third_party\WebKit\Tools\Scripts\webkitpy\layout_tests\port\base.py", line 1185, in start_wptserve
    server.start()
  File "E:\b\build\slave\WebKit_Win_-_WPTServe\build\src\third_party\WebKit\Tools\Scripts\webkitpy\layout_tests\servers\server_base.py", line 110, in start
    raise ServerError('Failed to start %s server' % self._name)
ServerError: Failed to start wptserve server
step returned non-zero exit code: 255
@@@STEP_FAILURE@@@
Alright, that's progress.

The error "Server NOT running on 8001: [Errno 10061] No connection could be made because the target machine actively refused it" is logged at https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/server_base.py&l=260.

It would be helpful to be able to reproduce this locally in order to find out what might need to be different to run wptserve on windows.

Note, we didn't successfully run run-webkit-tests --enable-wptserve on Windows before.
Cc: qyears...@chromium.org
Labels: -Pri-1 -Infra-Labs -Infra-Troopers Pri-2
Owner: ----
Status: Available (was: Assigned)
Summary: Builder "WebKit Win - WPTServe" fails to run layout tests. (was: On builder "WebKit Win - WPTServe", layout tests don't run due to system dependency check)
In order to investigate this, I think it would be helpful to have a Windows workstation; I don't have one now but plan to request one later.
Blocking: -621174
Cc: -raikiri@google.com -dcampb@google.com

Comment 11 Deleted

Cc: jsb...@chromium.org
 Issue 655042  has been merged into this issue.
Blocking: 360762

Comment 14 by tkent@chromium.org, Oct 13 2016

Blocking: 618366

Comment 15 by tkent@chromium.org, Oct 13 2016

I observed the 'serve' subprocess aborted because of lack of openssl command.
I avoided it by
 * Add ...\depot_tools\git-2.10.0-64_bin/mingw64/bin to PATH
 * Add "ssl/openssl/base_conf_path":".../depot_tools/git-2.10.0-64_bin/mingw64/ssl/openssl.cnf" to wpt.config.json.

See https://github.com/w3c/web-platform-tests#windows-notes

I still have other issues.



Project Member

Comment 16 by bugdroid1@chromium.org, Oct 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a45e615bbeb1011695bca6259599ea61c26feb2

commit 1a45e615bbeb1011695bca6259599ea61c26feb2
Author: tkent <tkent@chromium.org>
Date: Thu Oct 13 16:49:30 2016

wptserve: Do not supress 'serve' command output on Windows.

BUG= 623613 

Review-Url: https://codereview.chromium.org/2408133005
Cr-Commit-Position: refs/heads/master@{#425060}

[modify] https://crrev.com/1a45e615bbeb1011695bca6259599ea61c26feb2/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/wptserve.py

Comment 17 by tkent@chromium.org, Oct 13 2016

Well, the current error of 'serve' command invocation is:

15:12:12.684 4560 wptserve stderr:
15:12:12.684 4560   Traceback (most recent call last):
15:12:12.684 4560     File "E:\b\c\b\WebKit_Win___WPTServe\src\third_party\WebKit\Tools\Scripts\webkitpy\thirdparty\wpt\wpt\serve", line 2, in <module>
15:12:12.684 4560       import serve
15:12:12.684 4560     File "E:\b\c\b\WebKit_Win___WPTServe\src\third_party\WebKit\Tools\Scripts\webkitpy\thirdparty\wpt\wpt\serve.py", line 1, in <module>
15:12:12.684 4560       from tools.serve import serve
15:12:12.684 4560     File "E:\b\c\b\WebKit_Win___WPTServe\src\third_party\WebKit\Tools\Scripts\webkitpy\thirdparty\wpt\wpt\tools\serve\__init__.py", line 1, in <module>
15:12:12.684 4560       import serve
15:12:12.684 4560     File "E:\b\c\b\WebKit_Win___WPTServe\src\third_party\WebKit\Tools\Scripts\webkitpy\thirdparty\wpt\wpt\tools\serve\serve.py", line 11, in <module>
15:12:12.684 4560       import urllib2
15:12:12.684 4560     File "E:\b\depot_tools\python276_bin\lib\urllib2.py", line 94, in <module>
15:12:12.684 4560       import httplib
15:12:12.684 4560     File "E:\b\depot_tools\python276_bin\lib\httplib.py", line 79, in <module>
15:12:12.684 4560       import mimetools
15:12:12.684 4560     File "E:\b\depot_tools\python276_bin\lib\mimetools.py", line 6, in <module>
15:12:12.684 4560       import tempfile
15:12:12.684 4560     File "E:\b\depot_tools\python276_bin\lib\tempfile.py", line 35, in <module>
15:12:12.684 4560       from random import Random as _Random
15:12:12.684 4560     File "E:\b\depot_tools\python276_bin\lib\random.py", line 880, in <module>
15:12:12.684 4560       _inst = Random()
15:12:12.684 4560     File "E:\b\depot_tools\python276_bin\lib\random.py", line 97, in __init__
15:12:12.684 4560       self.seed(x)
15:12:12.684 4560     File "E:\b\depot_tools\python276_bin\lib\random.py", line 111, in seed
15:12:12.684 4560       a = long(_hexlify(_urandom(16)), 16)
15:12:12.684 4560   WindowsError: [Error -2146893818] Invalid Signature

I'll fix it.

Awesome -- as soon as wptserve can run on Windows, then it'll be possible to switch to enable wptserve by default ( bug 618366 ). (Although before enabling it by default we may want to limit the set of tests that wptserve is used for, for performance reasons.)

Comment 19 by no...@chromium.org, Oct 13 2016

Cc: -no...@chromium.org
Project Member

Comment 20 by bugdroid1@chromium.org, Oct 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e372c95d95d2f58f7b2bfc622cedccd4eed23d83

commit e372c95d95d2f58f7b2bfc622cedccd4eed23d83
Author: tkent <tkent@chromium.org>
Date: Fri Oct 14 16:20:13 2016

wptserve: Do not drop environment variables on running 'serve' command.

Especially, 'PATH' is necessary to find required DLLs.

BUG= 623613 
NOTRY=true

Review-Url: https://codereview.chromium.org/2417153002
Cr-Commit-Position: refs/heads/master@{#425344}

[modify] https://crrev.com/e372c95d95d2f58f7b2bfc622cedccd4eed23d83/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/wptserve.py

Project Member

Comment 21 by bugdroid1@chromium.org, Oct 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e372c95d95d2f58f7b2bfc622cedccd4eed23d83

commit e372c95d95d2f58f7b2bfc622cedccd4eed23d83
Author: tkent <tkent@chromium.org>
Date: Fri Oct 14 16:20:13 2016

wptserve: Do not drop environment variables on running 'serve' command.

Especially, 'PATH' is necessary to find required DLLs.

BUG= 623613 
NOTRY=true

Review-Url: https://codereview.chromium.org/2417153002
Cr-Commit-Position: refs/heads/master@{#425344}

[modify] https://crrev.com/e372c95d95d2f58f7b2bfc622cedccd4eed23d83/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/wptserve.py

Comment 22 by tkent@chromium.org, Oct 14 2016

The next error is:

10:03:25.748 3776 wptserve stderr:
10:03:25.748 3776   DEBUG:web-platform-tests:Going to use port 53046
10:03:25.748 3776   INFO:web-platform-tests:Generating new CA in E:\b\c\b\WebKit_Win___WPTServe\src\third_party\WebKit\Tools\Scripts\webkitpy\thirdparty\wpt\wpt\_certs
10:03:25.748 3776   Traceback (most recent call last):
10:03:25.748 3776     File "E:\b\c\b\WebKit_Win___WPTServe\src\third_party\WebKit\Tools\Scripts\webkitpy\thirdparty\wpt\wpt\serve", line 5, in <module>
10:03:25.748 3776       serve.main()
10:03:25.748 3776     File "E:\b\c\b\WebKit_Win___WPTServe\src\third_party\WebKit\Tools\Scripts\webkitpy\thirdparty\wpt\wpt\serve.py", line 4, in main
10:03:25.748 3776       serve.main()
10:03:25.748 3776     File "E:\b\c\b\WebKit_Win___WPTServe\src\third_party\WebKit\Tools\Scripts\webkitpy\thirdparty\wpt\wpt\tools\serve\serve.py", line 490, in main
10:03:25.748 3776       config_, servers = start(config, ssl_env, default_routes(), **kwargs)
10:03:25.748 3776     File "E:\b\c\b\WebKit_Win___WPTServe\src\third_party\WebKit\Tools\Scripts\webkitpy\thirdparty\wpt\wpt\tools\serve\serve.py", line 371, in start
10:03:25.748 3776       ssl_config = get_ssl_config(config, external_config["domains"].values(), ssl_environment)
10:03:25.748 3776     File "E:\b\c\b\WebKit_Win___WPTServe\src\third_party\WebKit\Tools\Scripts\webkitpy\thirdparty\wpt\wpt\tools\serve\serve.py", line 355, in get_ssl_config
10:03:25.748 3776       key_path, cert_path = ssl_environment.host_cert_path(external_domains)
10:03:25.748 3776     File "E:\b\c\b\WebKit_Win___WPTServe\src\third_party\WebKit\Tools\Scripts\webkitpy\thirdparty\wpt\wpt\tools\sslutils\openssl.py", line 350, in host_cert_path
10:03:25.748 3776       key, cert = self._generate_host_cert(hosts)
10:03:25.748 3776     File "E:\b\c\b\WebKit_Win___WPTServe\src\third_party\WebKit\Tools\Scripts\webkitpy\thirdparty\wpt\wpt\tools\sslutils\openssl.py", line 370, in _generate_host_cert
10:03:25.748 3776       self._generate_ca()
10:03:25.748 3776     File "E:\b\c\b\WebKit_Win___WPTServe\src\third_party\WebKit\Tools\Scripts\webkitpy\thirdparty\wpt\wpt\tools\sslutils\openssl.py", line 321, in _generate_ca
10:03:25.748 3776       "-passout", "pass:%s" % self.password)
10:03:25.748 3776     File "E:\b\c\b\WebKit_Win___WPTServe\src\third_party\WebKit\Tools\Scripts\webkitpy\thirdparty\wpt\wpt\tools\sslutils\openssl.py", line 64, in __call__
10:03:25.748 3776       env=env)
10:03:25.748 3776     File "E:\b\depot_tools\python276_bin\lib\subprocess.py", line 709, in __init__
10:03:25.748 3776       errread, errwrite)
10:03:25.748 3776     File "E:\b\depot_tools\python276_bin\lib\subprocess.py", line 957, in _execute_child
10:03:25.748 3776       startupinfo)
10:03:25.748 3776   WindowsError: [Error 2] The system cannot find the file specified

This is what I wrote in #15.

Comment 23 by tkent@chromium.org, Oct 17 2016

Cc: vadimsh@chromium.org iannucci@chromium.org
Summary: Builder "WebKit Win - WPTServe" fails to run layout tests due to no "openssl" command (was: Builder "WebKit Win - WPTServe" fails to run layout tests.)
We need openssl command on Windows.  I confirmed openssl command is necessary even if a local machine has certificates, in order to check certificate validity.

Infra team, can we add depot_tools/openssl.bat, which kicks git-*_bin/mingw64/bin/openssl.exe like depot_tools/git.bat ?

Is there a way to avoid this?

Here's what will happen:
1. We add openssl to depot tools.
2. Random code from random places starts to grow dependencies on it (as happens to stuff in depot tools).
3. Everything in depot tools it is essentially ownerless (well, "team" owns it, not single individuals => ~= ownerless).
4. It ends up stuck at some ancient version (because no one cares to update it often).
5. Dependencies mentioned in (2) end up using vulnerable old OpenSSL version.

Comment 25 by tkent@chromium.org, Oct 18 2016

well, I found a way to avoid openssl invocation.  I'm still not sure if it works well in all cases, but we should try it, and reconsider if it doesn't work.

For now, I withdraw the request of depot_tools/openssl.bat.

Project Member

Comment 26 by bugdroid1@chromium.org, Oct 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bac33e60430a3002079824d18afc2cbb7aa6f3f7

commit bac33e60430a3002079824d18afc2cbb7aa6f3f7
Author: tkent <tkent@chromium.org>
Date: Tue Oct 18 21:29:52 2016

wptserve: Add pre-generated private keys and certificates for testing.

This CL removes runtime openssl dependency from wptserve.
This adds pre-generated keys and certificates which are valid until January 2025.
We'll need to re-generated these files manually before January 2025.

BUG= 623613 

Review-Url: https://codereview.chromium.org/2428513003
Cr-Commit-Position: refs/heads/master@{#426054}

[add] https://crrev.com/bac33e60430a3002079824d18afc2cbb7aa6f3f7/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/certs/01.pem
[add] https://crrev.com/bac33e60430a3002079824d18afc2cbb7aa6f3f7/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/certs/02.pem
[add] https://crrev.com/bac33e60430a3002079824d18afc2cbb7aa6f3f7/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/certs/127.0.0.1.key
[add] https://crrev.com/bac33e60430a3002079824d18afc2cbb7aa6f3f7/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/certs/127.0.0.1.pem
[add] https://crrev.com/bac33e60430a3002079824d18afc2cbb7aa6f3f7/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/certs/cacert.pem
[add] https://crrev.com/bac33e60430a3002079824d18afc2cbb7aa6f3f7/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/certs/cakey.pem
[add] https://crrev.com/bac33e60430a3002079824d18afc2cbb7aa6f3f7/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/certs/index.txt
[add] https://crrev.com/bac33e60430a3002079824d18afc2cbb7aa6f3f7/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/certs/index.txt.attr
[add] https://crrev.com/bac33e60430a3002079824d18afc2cbb7aa6f3f7/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/certs/index.txt.attr.old
[add] https://crrev.com/bac33e60430a3002079824d18afc2cbb7aa6f3f7/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/certs/index.txt.old
[add] https://crrev.com/bac33e60430a3002079824d18afc2cbb7aa6f3f7/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/certs/serial
[add] https://crrev.com/bac33e60430a3002079824d18afc2cbb7aa6f3f7/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/certs/serial.old
[modify] https://crrev.com/bac33e60430a3002079824d18afc2cbb7aa6f3f7/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt.config.json

Comment 27 by tkent@chromium.org, Oct 18 2016

Cc: -iannucci@chromium.org -vadimsh@chromium.org

Comment 28 by tkent@chromium.org, Oct 19 2016

Ok, Build #8332 and #8333 ran layout tests expectedly.
However these builds didn't finish correctly because of hang after green "Failure reason" step.  Maybe it's an infra/bot issue rather than Blink>Infra issue?


Project Member

Comment 29 by bugdroid1@chromium.org, Oct 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ab94e918f4ec8d13ff9951900829e31b1f38df5

commit 0ab94e918f4ec8d13ff9951900829e31b1f38df5
Author: tkent <tkent@chromium.org>
Date: Wed Oct 19 01:43:30 2016

Revert of wptserve: Do not supress 'serve' command output on Windows. (patchset #1 id:1 of https://codereview.chromium.org/2408133005/ )

Reason for revert:
This diagnostic change isn't necessary any longer.

Original issue's description:
> wptserve: Do not supress 'serve' command output on Windows.
>
> BUG= 623613 
>
> Committed: https://crrev.com/1a45e615bbeb1011695bca6259599ea61c26feb2
> Cr-Commit-Position: refs/heads/master@{#425060}

TBR=qyearsley@chromium.org,jsbell@chromium.org
NOTRY=true
BUG= 623613 

Review-Url: https://chromiumcodereview.appspot.com/2427133002
Cr-Commit-Position: refs/heads/master@{#426112}

[modify] https://crrev.com/0ab94e918f4ec8d13ff9951900829e31b1f38df5/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/wptserve.py

Project Member

Comment 30 by bugdroid1@chromium.org, Oct 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d4219faf726ee04070450faa8d023d167da6b1f

commit 6d4219faf726ee04070450faa8d023d167da6b1f
Author: tkent <tkent@chromium.org>
Date: Wed Oct 19 16:04:31 2016

wptserve: Fix Python process leak on Windows.

According to a comment in Executive.interrupt(), it doesn't look to
work on Windows. We use Executive.kill_process() like apache_http.py
does.

BUG= 623613 
NOTRY=true

Review-Url: https://chromiumcodereview.appspot.com/2428223003
Cr-Commit-Position: refs/heads/master@{#426212}

[modify] https://crrev.com/6d4219faf726ee04070450faa8d023d167da6b1f/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/wptserve.py

Comment 31 by tkent@chromium.org, Oct 19 2016

Owner: tkent@chromium.org
Status: Fixed (was: Available)
r426212 magically fixed the bot hang issue.  We need to kill all of invoked processes?

This issue was fixed!
https://build.chromium.org/p/chromium.fyi/builders/WebKit%20Win%20-%20WPTServe

Yay! Good news :-)
Project Member

Comment 33 by bugdroid1@chromium.org, Oct 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54b4c65a2bfe9f4cb89f4b9877dbf40f9e321879

commit 54b4c65a2bfe9f4cb89f4b9877dbf40f9e321879
Author: tkent <tkent@chromium.org>
Date: Thu Oct 20 16:49:34 2016

wptserve: Document how to re-generate keys and certs.

BUG= 623613 
NOTRY=true

Review-Url: https://chromiumcodereview.appspot.com/2434933002
Cr-Commit-Position: refs/heads/master@{#426502}

[modify] https://crrev.com/54b4c65a2bfe9f4cb89f4b9877dbf40f9e321879/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/README.chromium

Project Member

Comment 34 by bugdroid1@chromium.org, Oct 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a13132dfe41eec9d9c21ecf07c483589b5ffedbd

commit a13132dfe41eec9d9c21ecf07c483589b5ffedbd
Author: tkent <tkent@chromium.org>
Date: Tue Oct 25 03:56:56 2016

Improve README.chromium for WPTServe.

Also, wptserve.py shows a warning before certificate expiration.

BUG= 623613 
NOTRY=true

Review-Url: https://codereview.chromium.org/2443863002
Cr-Commit-Position: refs/heads/master@{#427270}

[modify] https://crrev.com/a13132dfe41eec9d9c21ecf07c483589b5ffedbd/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/wptserve.py
[modify] https://crrev.com/a13132dfe41eec9d9c21ecf07c483589b5ffedbd/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/README.chromium

Sign in to add a comment