New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 623606 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Remove code for managed bookmarks for supervised users

Project Member Reported by treib@chromium.org, Jun 27 2016

Issue description

Managed bookmarks for supervised users (issue 443606) was abandoned and never launched. We should remove the corresponding code.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jun 28 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by treib@chromium.org, Jun 28 2017

Cc: fhorschig@chromium.org
Components: UI>Browser>Bookmarks
Labels: -Hotlist-Recharge-Cold
Status: Available (was: Untriaged)
Still relevant, just not very high priority...

Comment 3 by treib@chromium.org, Oct 4 2017

Labels: -OS-All OS-Chrome OS-Linux OS-Mac OS-Windows
Owner: treib@chromium.org
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ce49017c22219f016675e11a9029378a3552b31

commit 1ce49017c22219f016675e11a9029378a3552b31
Author: Marc Treib <treib@chromium.org>
Date: Fri Oct 06 09:55:48 2017

Cleanup: Remove "Supervised Bookmarks"

This was implemented years ago but never launched, and it doesn't look
like it ever will. Time to get rid of the code.

This essentially reverts https://codereview.chromium.org/769153007

Bug:  623606 
Change-Id: Ibb9184a7ffc79bd8d5bfacde41f2a129a5b4342b
Reviewed-on: https://chromium-review.googlesource.com/695107
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507020}
[delete] https://crrev.com/86d4682e7e788af99f059605595ad8aac30ea7eb/chrome/app/theme/default_100_percent/mac/bookmark_bar_folder_supervised.png
[delete] https://crrev.com/86d4682e7e788af99f059605595ad8aac30ea7eb/chrome/app/theme/default_100_percent/mac/bookmark_bar_folder_supervised_white.png
[delete] https://crrev.com/86d4682e7e788af99f059605595ad8aac30ea7eb/chrome/app/theme/default_100_percent/win/bookmark_bar_folder_supervised.png
[delete] https://crrev.com/86d4682e7e788af99f059605595ad8aac30ea7eb/chrome/app/theme/default_200_percent/mac/bookmark_bar_folder_supervised.png
[delete] https://crrev.com/86d4682e7e788af99f059605595ad8aac30ea7eb/chrome/app/theme/default_200_percent/mac/bookmark_bar_folder_supervised_white.png
[delete] https://crrev.com/86d4682e7e788af99f059605595ad8aac30ea7eb/chrome/app/theme/default_200_percent/win/bookmark_bar_folder_supervised.png
[modify] https://crrev.com/1ce49017c22219f016675e11a9029378a3552b31/chrome/app/theme/theme_resources.grd
[modify] https://crrev.com/1ce49017c22219f016675e11a9029378a3552b31/chrome/browser/BUILD.gn
[modify] https://crrev.com/1ce49017c22219f016675e11a9029378a3552b31/chrome/browser/about_flags.cc
[modify] https://crrev.com/1ce49017c22219f016675e11a9029378a3552b31/chrome/browser/android/bookmarks/bookmark_bridge.cc
[modify] https://crrev.com/1ce49017c22219f016675e11a9029378a3552b31/chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc
[modify] https://crrev.com/1ce49017c22219f016675e11a9029378a3552b31/chrome/browser/extensions/api/bookmarks/bookmark_apitest.cc
[modify] https://crrev.com/1ce49017c22219f016675e11a9029378a3552b31/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc
[modify] https://crrev.com/1ce49017c22219f016675e11a9029378a3552b31/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/1ce49017c22219f016675e11a9029378a3552b31/chrome/browser/flag_descriptions.h
[delete] https://crrev.com/86d4682e7e788af99f059605595ad8aac30ea7eb/chrome/browser/supervised_user/supervised_user_bookmarks_handler.cc
[delete] https://crrev.com/86d4682e7e788af99f059605595ad8aac30ea7eb/chrome/browser/supervised_user/supervised_user_bookmarks_handler.h
[delete] https://crrev.com/86d4682e7e788af99f059605595ad8aac30ea7eb/chrome/browser/supervised_user/supervised_user_bookmarks_handler_unittest.cc
[modify] https://crrev.com/1ce49017c22219f016675e11a9029378a3552b31/chrome/browser/supervised_user/supervised_user_pref_store.cc
[modify] https://crrev.com/1ce49017c22219f016675e11a9029378a3552b31/chrome/browser/ui/bookmarks/bookmark_utils.cc
[modify] https://crrev.com/1ce49017c22219f016675e11a9029378a3552b31/chrome/browser/ui/bookmarks/bookmark_utils.h
[modify] https://crrev.com/1ce49017c22219f016675e11a9029378a3552b31/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h
[modify] https://crrev.com/1ce49017c22219f016675e11a9029378a3552b31/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
[modify] https://crrev.com/1ce49017c22219f016675e11a9029378a3552b31/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm
[modify] https://crrev.com/1ce49017c22219f016675e11a9029378a3552b31/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.mm
[modify] https://crrev.com/1ce49017c22219f016675e11a9029378a3552b31/chrome/browser/ui/view_ids.h
[modify] https://crrev.com/1ce49017c22219f016675e11a9029378a3552b31/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
[modify] https://crrev.com/1ce49017c22219f016675e11a9029378a3552b31/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h
[modify] https://crrev.com/1ce49017c22219f016675e11a9029378a3552b31/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc
[modify] https://crrev.com/1ce49017c22219f016675e11a9029378a3552b31/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.h
[modify] https://crrev.com/1ce49017c22219f016675e11a9029378a3552b31/chrome/common/chrome_switches.cc
[modify] https://crrev.com/1ce49017c22219f016675e11a9029378a3552b31/chrome/common/chrome_switches.h
[modify] https://crrev.com/1ce49017c22219f016675e11a9029378a3552b31/chrome/common/extensions/api/bookmarks.json
[modify] https://crrev.com/1ce49017c22219f016675e11a9029378a3552b31/chrome/test/BUILD.gn
[modify] https://crrev.com/1ce49017c22219f016675e11a9029378a3552b31/chrome/test/data/extensions/api_test/bookmarks/test.js
[modify] https://crrev.com/1ce49017c22219f016675e11a9029378a3552b31/components/bookmark_bar_strings.grdp
[modify] https://crrev.com/1ce49017c22219f016675e11a9029378a3552b31/components/bookmarks/browser/bookmark_utils.cc
[modify] https://crrev.com/1ce49017c22219f016675e11a9029378a3552b31/components/bookmarks/common/bookmark_pref_names.cc
[modify] https://crrev.com/1ce49017c22219f016675e11a9029378a3552b31/components/bookmarks/common/bookmark_pref_names.h
[modify] https://crrev.com/1ce49017c22219f016675e11a9029378a3552b31/components/bookmarks/managed/managed_bookmark_service.cc
[modify] https://crrev.com/1ce49017c22219f016675e11a9029378a3552b31/components/bookmarks/managed/managed_bookmark_service.h
[modify] https://crrev.com/1ce49017c22219f016675e11a9029378a3552b31/components/bookmarks/managed/managed_bookmark_util.cc
[modify] https://crrev.com/1ce49017c22219f016675e11a9029378a3552b31/components/bookmarks/managed/managed_bookmarks_tracker.cc
[modify] https://crrev.com/1ce49017c22219f016675e11a9029378a3552b31/components/bookmarks/managed/managed_bookmarks_tracker.h
[modify] https://crrev.com/1ce49017c22219f016675e11a9029378a3552b31/components/bookmarks/managed/managed_bookmarks_tracker_unittest.cc

Comment 5 by treib@chromium.org, Oct 6 2017

Status: Fixed (was: Started)

Sign in to add a comment