DevTools: hosted development mode broken |
||
Issue descriptionThe hosted mode for devtools development lowers the barrier of entry dramatically to casual contributors. Since it was broken during the protocol refactoring, we've gotten a number of feedbacks and reports. The primary thread on the mailing list is here: * https://groups.google.com/forum/#!topic/google-chrome-developer-tools/sP1J63c636Y But I've had a number of developers reach out to me personally to help resolving this. I'd like to restore this mechanism (or offer an easier alternative) to keep the devtools hackable.
,
Jul 2 2016
Glad to hear this is being worked on!
,
Jul 7 2016
An alternative approach: https://codereview.chromium.org/2124203002/
,
Jul 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/72620f081343cac603df3e17dfbd8b2607e2ab2d commit 72620f081343cac603df3e17dfbd8b2607e2ab2d Author: lushnikov <lushnikov@chromium.org> Date: Fri Jul 08 18:28:12 2016 DevTools: copy protocol files to front-end to fix hosted mode DevTools "hosted mode" is broken in a multiple ways: - it uses sync XHR from inside the microtask (this was recentrly forbidden) - as the protocol was split and moved around, the InspectorBackendHostedMode.js is not able to generate proper inspector backend commands The patch fixes both problems. Here we: - manually copy browser_protocol.json and js_protocol.json to the front-end folder so that hosted mode can rely on it - preload protocol files into Runtime.cachedResources in hosted mode for future use of InspectorBackendHostedMode.js BUG= 623602 R=dgozman, pfeldman Review-Url: https://codereview.chromium.org/2124203002 Cr-Commit-Position: refs/heads/master@{#404447} [modify] https://crrev.com/72620f081343cac603df3e17dfbd8b2607e2ab2d/third_party/WebKit/Source/devtools/front_end/Runtime.js [modify] https://crrev.com/72620f081343cac603df3e17dfbd8b2607e2ab2d/third_party/WebKit/Source/devtools/front_end/inspector.js [modify] https://crrev.com/72620f081343cac603df3e17dfbd8b2607e2ab2d/third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackendHostedMode.js [add] https://crrev.com/72620f081343cac603df3e17dfbd8b2607e2ab2d/third_party/WebKit/Source/devtools/front_end/sdk/protocol/README.md [add] https://crrev.com/72620f081343cac603df3e17dfbd8b2607e2ab2d/third_party/WebKit/Source/devtools/front_end/sdk/protocol/browser_protocol.json [add] https://crrev.com/72620f081343cac603df3e17dfbd8b2607e2ab2d/third_party/WebKit/Source/devtools/front_end/sdk/protocol/js_protocol.json
,
Jul 8 2016
,
Jul 9 2016
I'm not seeing this working the same. I have this open: http://localhost:9999/front_end/inspector.html?experiments=true&loadTimelineFromURL=http://localhost:9999/nyt.json And things fail. Debugging it.. It's doing an XHR for .../inspector.json which means above front_end, but the actual file is in front_end/sdk ?
,
Jul 11 2016
@paul: I bet you're serving an old front-end (or the one from your browser cache) |
||
►
Sign in to add a comment |
||
Comment 1 by lushnikov@chromium.org
, Jul 1 2016