Enable "share" in menu by default in the support library |
||
Issue descriptionTracking bug: I think it would be good to include share in the menu by default from the support library. Implementations can override, but it means developers won't forget it.
,
Jul 11 2016
Might get tricky if the menu items are localized. Then when it's tested in English it works... Is there a way we can make sure we have an ACK of new behavior without being too annoying? Bad(?) example: aborting with an error when a CCT is launched and the user hasn't set share menu item visibility.
,
Jul 21 2016
Approved at UI review as of 7/20. Strawman: Deprecate addDefaultShareMenuItem and add setDefaultShareVisibility(boolean visible [true]) On CustomTabsIntent#build, log a warning(?) to the console if setDefaultShareVisibility has not been called: "The Custom Tabs intent builder defaults to building with a default share menu item as of 24.1. The visibility of this menu item can be controlled with setDefaultShareVisibility. See <link to doc>."
,
Jan 25 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by yus...@chromium.org
, Jul 11 2016Owner: sbirch@chromium.org