New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 623584 link

Starred by 4 users

Issue metadata

Status: Assigned
Owner:
Last visit 21 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Enable "share" in menu by default in the support library

Project Member Reported by sbirch@chromium.org, Jun 27 2016

Issue description

Tracking bug: I think it would be good to include share in the menu by default from the support library. Implementations can override, but it means developers won't forget it.
 

Comment 1 by yus...@chromium.org, Jul 11 2016

Cc: yus...@chromium.org
Owner: sbirch@chromium.org
One thing we should be careful about is communicating this to apps clearly, so that they don't end up with multiple Share items.

Should we be doing any checks here in code? (We can look for descriptions that start with "share" and not add it by default maybe? Then that means adding it by default and adding it through the call should be different extras to track it right.) 

Comment 2 by sbirch@chromium.org, Jul 11 2016

Might get tricky if the menu items are localized. Then when it's tested in English it works...

Is there a way we can make sure we have an ACK of new behavior without being too annoying? Bad(?) example: aborting with an error when a CCT is launched and the user hasn't set share menu item visibility.

Comment 3 by sbirch@chromium.org, Jul 21 2016

Approved at UI review as of 7/20.

Strawman:

Deprecate addDefaultShareMenuItem and add setDefaultShareVisibility(boolean visible [true])

On CustomTabsIntent#build, log a warning(?) to the console if setDefaultShareVisibility has not been called: "The Custom Tabs intent builder defaults to building with a default share menu item as of 24.1. The visibility of this menu item can be controlled with setDefaultShareVisibility. See <link to doc>."
Status: Assigned (was: Untriaged)

Sign in to add a comment