remote_run_factory's build dir names are too long on Windows (and gn generates pretty long rsp file names too) |
|||||
Issue descriptionhttps://build.chromium.org/p/chromium.fyi/builders/CrWinAsan%28dll%29/builds/4433/steps/compile/logs/stdio ninja: error: WriteFile(autofill_content_test_types_mojo_bindings_target_autofill_content_test_types_mojo_bindings_mojom_bindings_generator_139be6600a7ee33658cd8d73ff603358.bf20bed81831f4b249d2f5723190a6d9.rsp): Unable to create file. No such file or directory That string is 185 characters, and after https://codereview.chromium.org/2095373002 the build dir is C:\b\cache\chromium\builder_cache\checkouts\CrWinAsan_dll_\src\out\Release which is 72 characters, which is probably over the 260 char limit counting all the combining chars and whatnot. We had several problems with long path names ( bug 399990 ...) so I think this is more due to remote_run_factory than gn. I'll revert the remote_run_factory thing for now.
,
Jun 27 2016
,
Jun 27 2016
Uploaded https://codereview.chromium.org/2100153002 and https://codereview.chromium.org/2102613002 to address this.
,
Jun 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/aa0b3b6bd0111a0fd7aa6151f7b87a9247300cad commit aa0b3b6bd0111a0fd7aa6151f7b87a9247300cad Author: phajdan.jr <phajdan.jr@chromium.org> Date: Mon Jun 27 16:08:42 2016 infra_paths: keep cache paths super short to avoid long path issues BUG= 623575 Review-Url: https://codereview.chromium.org/2102613002 [modify] https://crrev.com/aa0b3b6bd0111a0fd7aa6151f7b87a9247300cad/recipe_modules/infra_paths/path_config.py
,
Jun 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/44954fc89223477c6331a30e74b00c549de42aac commit 44954fc89223477c6331a30e74b00c549de42aac Author: phajdan.jr <phajdan.jr@chromium.org> Date: Mon Jun 27 16:08:55 2016 chromium_tests: remove unnecessary path component from cache checkout path Also allows to customize checkout dir per builder to keep it even shorter if needed. BUG= 623575 Review-Url: https://codereview.chromium.org/2100153002 [modify] https://crrev.com/44954fc89223477c6331a30e74b00c549de42aac/scripts/slave/recipe_modules/chromium_tests/api.py [modify] https://crrev.com/44954fc89223477c6331a30e74b00c549de42aac/scripts/slave/recipes/chromium.expected/kitchen_path_config.json
,
Jun 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/fc254e91cc263bfc5f3c5de636001003a569c567 commit fc254e91cc263bfc5f3c5de636001003a569c567 Author: recipe-roller <recipe-roller@chromium.org> Date: Mon Jun 27 16:14:35 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) depot_tools: https://crrev.com/aa0b3b6bd0111a0fd7aa6151f7b87a9247300cad infra_paths: keep cache paths super short to avoid long path issues (phajdan.jr@chromium.org) R=phajdan.jr@chromium.org BUG= 623575 TBR=martiniss@chromium.org,phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/2095423002 [modify] https://crrev.com/fc254e91cc263bfc5f3c5de636001003a569c567/infra/config/recipes.cfg
,
Jun 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/460d557eecd35efcacb1a0d04b5c7a0ad0fcd84d commit 460d557eecd35efcacb1a0d04b5c7a0ad0fcd84d Author: nodir <nodir@chromium.org> Date: Mon Jun 27 21:07:21 2016 Revert of infra_paths: keep cache paths super short to avoid long path issues (patchset #1 id:1 of https://codereview.chromium.org/2102613002/ ) Reason for revert: /b/cache dir on slaves were not cleaned up and now disk alerts are firing please come up with a cleanup strategy before re-landing this CL Original issue's description: > infra_paths: keep cache paths super short to avoid long path issues > > BUG= 623575 > > Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/aa0b3b6bd0111a0fd7aa6151f7b87a9247300cad TBR=emso@chromium.org,sergiyb@chromium.org,tandrii@chromium.org,thakis@chromium.org,phajdan.jr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 623575 Review-Url: https://codereview.chromium.org/2100793004 [modify] https://crrev.com/460d557eecd35efcacb1a0d04b5c7a0ad0fcd84d/recipe_modules/infra_paths/path_config.py
,
Jun 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/4d51dcf3869d1b66376f1d2c3d4b98961a2ebec1 commit 4d51dcf3869d1b66376f1d2c3d4b98961a2ebec1 Author: recipe-roller <recipe-roller@chromium.org> Date: Mon Jun 27 21:34:41 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/44954fc89223477c6331a30e74b00c549de42aac chromium_tests: remove unnecessary path component from cache checkout path (phajdan.jr@chromium.org) https://crrev.com/9f21596e6064488a182a9ac7ee3ab52e34eb4a9d Fix adb_path to not make assumptions about directory layout on the bot (phajdan.jr@chromium.org) https://crrev.com/fc254e91cc263bfc5f3c5de636001003a569c567 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) https://crrev.com/46753393a62aaa7299e4a4d07f95789d8289788a zip_build: explicitly set staging dir instead of guessing it (phajdan.jr@chromium.org) depot_tools: https://crrev.com/aa0b3b6bd0111a0fd7aa6151f7b87a9247300cad infra_paths: keep cache paths super short to avoid long path issues (phajdan.jr@chromium.org) R=recipe-roller@chromium.org,martiniss@chromium.org,phajdan.jr@chromium.org BUG= 623575 ,584079 TBR=martiniss@chromium.org,phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/2094403002 [modify] https://crrev.com/4d51dcf3869d1b66376f1d2c3d4b98961a2ebec1/infra/config/recipes.cfg
,
Jun 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/5934ca1eb6587a02ea079745db921e829d54c031 commit 5934ca1eb6587a02ea079745db921e829d54c031 Author: recipe-roller <recipe-roller@chromium.org> Date: Mon Jun 27 22:17:11 2016 Roll recipe dependencies (nontrivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). Please review the expectation changes, and LGTM as normal. The recipe roller will *NOT* CQ the change itself, so you must commit the change manually. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) depot_tools: https://crrev.com/460d557eecd35efcacb1a0d04b5c7a0ad0fcd84d Revert of infra_paths: keep cache paths super short to avoid long path issues (patchset #1 id:1 of https://codereview.chromium.org/2102613002/ ) (nodir@chromium.org) R=tandrii@chromium.org,emso@chromium.org,thakis@chromium.org,nodir@chromium.org,phajdan.jr@chromium.org,sergiyb@chromium.org BUG= 623575 Review-Url: https://codereview.chromium.org/2104483003 [modify] https://crrev.com/5934ca1eb6587a02ea079745db921e829d54c031/infra/config/recipes.cfg
,
Jun 28 2016
Aboe changes should address this, but we need to confirm (converting chromium.fyi to remote_run has been reverted).
,
Jun 28 2016
,
Jun 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/4f00aa0b495e75c0944fcc4cc3188a9c57efaf7d commit 4f00aa0b495e75c0944fcc4cc3188a9c57efaf7d Author: phajdan.jr <phajdan.jr@chromium.org> Date: Wed Jun 29 08:00:10 2016 infra_paths: keep cache paths super short to avoid long path issues (attempt #2) This is a reland of https://codereview.chromium.org/2102613002/ . See https://goto.google.com/ljfzu (Google-internal) for more context. Summary: - the only builders with chromium checkout affected by this are on chromium.fyi - we can't clean up old cache directories before switching to new ones Also see https://goto.google.com/oyxwm why so short directory names are OK. Similarly https://codereview.chromium.org/2061213002 . BUG= 623575 Review-Url: https://codereview.chromium.org/2102403002 [modify] https://crrev.com/4f00aa0b495e75c0944fcc4cc3188a9c57efaf7d/recipe_modules/infra_paths/path_config.py
,
Jun 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/1a696d63a41aa05248f20a536c6f753ff15c2fae commit 1a696d63a41aa05248f20a536c6f753ff15c2fae Author: recipe-roller <recipe-roller@chromium.org> Date: Wed Jun 29 08:06:40 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) depot_tools: https://crrev.com/4f00aa0b495e75c0944fcc4cc3188a9c57efaf7d infra_paths: keep cache paths super short to avoid long path issues (attempt #2) (phajdan.jr@chromium.org) R=phajdan.jr@chromium.org BUG= 623575 TBR=martiniss@chromium.org,phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/2108113003 [modify] https://crrev.com/1a696d63a41aa05248f20a536c6f753ff15c2fae/infra/config/recipes.cfg
,
Jun 29 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/ddc50a5bfca5e59234c4847de74c7d0338bffd54 commit ddc50a5bfca5e59234c4847de74c7d0338bffd54 Author: recipe-roller <recipe-roller@chromium.org> Date: Wed Jun 29 08:18:20 2016
,
Jun 29 2016
How about using \\?\ prefix instead? This would limit our path length to 32k characters, see https://msdn.microsoft.com/en-us/library/aa365247.aspx#maxpath. IMHO, this is a better long-term solution. WDYT?
,
Jun 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/1c879101442ffd8de3df4c87208ac6ce0eddff8d commit 1c879101442ffd8de3df4c87208ac6ce0eddff8d Author: recipe-roller <recipe-roller@chromium.org> Date: Wed Jun 29 08:32:26 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/a9898ce1ccedb91babfc418cfbf694b5b2870220 zip_build: explicitly pass gsutil.py path (phajdan.jr@chromium.org) https://crrev.com/1a696d63a41aa05248f20a536c6f753ff15c2fae Roll recipe dependencies (trivial). (recipe-roller@chromium.org) depot_tools: https://crrev.com/4f00aa0b495e75c0944fcc4cc3188a9c57efaf7d infra_paths: keep cache paths super short to avoid long path issues (attempt #2) (phajdan.jr@chromium.org) R=recipe-roller@chromium.org,martiniss@chromium.org,phajdan.jr@chromium.org BUG= chromium:593999 , 623575 ,chromium:585401 TBR=martiniss@chromium.org,phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/2101923005 [modify] https://crrev.com/1c879101442ffd8de3df4c87208ac6ce0eddff8d/infra/config/recipes.cfg
,
Jul 7 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by thakis@chromium.org
, Jun 27 2016