theme developer documentation needs updating re: tints |
|||
Issue descriptionBad docs here[1]. The reference to kTint* no longer makes sense because those have been removed and the strings are no longer in that file. Now they reside here[2]. I'm not sure how to make these docs resilient against code changes. Even if we list the strings directly in the documentation they are no less subject to change or removal. We might need to add a comment in the code to remind developers to update the docs if they move the strings. [1]https://developer.chrome.com/extensions/themes#tints [2] https://cs.chromium.org/chromium/src/chrome/browser/themes/browser_theme_pack.cc?rcl=0&l=256
,
Sep 4 2017
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 13
Archiving old bugs that haven't been actively assigned in over 180 days. If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks! |
|||
►
Sign in to add a comment |
|||
Comment 1 by benhenry@chromium.org
, Sep 1 2016