That screenshot shows the existing issue 614690. I've attached a movie that shows the regression.

Deleted: 2016_06_27_issue623571.mp4 341 KB

	2016_06_27_issue623571.mp4 341 KB View Download

I've tracked this down to https://codereview.chromium.org/2045733002, which changed the toolbar border assets. I can't quite make out from the images on the CL whether that added a visible border?

Yeah, it looks like a visible border was added to the asset. I'll request one be made without it.

Is that from Rebecca?

I don't believe so! But mdjones@ reached out and we're talking about possibilities.

Thanks for working on new assets!

FYI: This is unfortunately blocking our Zine NTP launch :/. So would be great to see this fixed asap.

Let me know in case I can help in any way.

Thanks!

+ Chris, in case the assets in https://codereview.chromium.org/2045733002 are from him.

The assets are from bettes@, I tested fading the inner border myself and it fixes the problem. I just need the new assets made. I sent an email, but bettes@ is ooo for a couple more days.

Ok, great! Sounds like this would really just be an assets change then. In which case it seems totally fine to merge back to M-53 after branchpoint.

Adding kerz so that he knows this will be coming next week.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d5b29c851ddac9e34aa303e9d6f1ce504d08be8

commit 1d5b29c851ddac9e34aa303e9d6f1ce504d08be8
Author: mdjones <mdjones@chromium.org>
Date: Thu Jun 30 17:48:04 2016

Update tab switcher border asset

This change updates the tab switcher asset to minimize the visibility
of the inner border.

BUG= 623571 

Review-Url: https://codereview.chromium.org/2110683009
Cr-Commit-Position: refs/heads/master@{#403216}

[modify] https://crrev.com/1d5b29c851ddac9e34aa303e9d6f1ce504d08be8/chrome/android/java/res/drawable-hdpi/tabswitcher_border_frame.9.png
[modify] https://crrev.com/1d5b29c851ddac9e34aa303e9d6f1ce504d08be8/chrome/android/java/res/drawable-mdpi/tabswitcher_border_frame.9.png
[modify] https://crrev.com/1d5b29c851ddac9e34aa303e9d6f1ce504d08be8/chrome/android/java/res/drawable-xhdpi/tabswitcher_border_frame.9.png
[modify] https://crrev.com/1d5b29c851ddac9e34aa303e9d6f1ce504d08be8/chrome/android/java/res/drawable-xxhdpi/tabswitcher_border_frame.9.png
[modify] https://crrev.com/1d5b29c851ddac9e34aa303e9d6f1ce504d08be8/chrome/android/java/res/drawable-xxxhdpi/tabswitcher_border_frame.9.png

Hi Matthew,

unfortunately, I still see this issue in the latest Canary 54.0.2793.0 - I think this release should already have your change from June 30, so it seems like this is not fixed as hoped.

Can you have a look?

Thanks

Patrick

Hm, I see it on dev but not ToT. I'll investigate.

Hi Matthew,

thanks for looking into this. Any updates? FYI: M53 Beta is scheduled for next week.

Thanks

Patrick

FTR, I still can't reproduce this on Canary or trunk (and Dev is fairly old right now).

Bernhard, I still see this on Canary 54.0.2796.0. I see the same behavior you captured in the video in Comment 1.

Video:

Deleted: shamuMOB30Onepper07192016115352.mp4 1.3 MB

	shamuMOB30Onepper07192016115352.mp4 1.3 MB View Download

The line just seems to be lighter maybe.

I can't reproduce the issue in anything past 53.0.2785.0. Right now my dev is at 53.0.2782.0 (which explains why I still see the issue). I'll keep an eye on it.

Ugh, it's really hard to go through the video frame-by-frame :-/ Is it possible that the very faint border now is coming from transitioning between the tab switcher (which has a border around the tab contents by design) and the regular view of the tab?

Yes, and that line has always been there to some degree. The problem is that the asset with the dark inner border appears to be sticking around.

Why is this line then not visible on stable? On stable the background is white, so it should be even more visible than on Canary if this line comes from the border of the tab switcher screenshot.

The fine line is visible in the video at 0:05. I'm attaching a screenshot.

Deleted: Screen Shot 2016-07-20 at 1.16.39 PM.png 197 KB

	Screen Shot 2016-07-20 at 1.16.39 PM.png 197 KB View Download

Friendly ping.

Bernhard, can you comment since you alleged that this gray line may be coming from the tab switcher?

So, I looked into this in more detail. Please find attached a video from the current Clank Stable release.

Stable: the tab switcher screenshot is white (#FFF) as is the top toolbar after transition and the resulting NTP background after transition. There is no line visible in the last frame before the screenshot gets replaced by the actual view.

Canary: the tab switcher background is gray (#F1F1F1) while the top toolbar and the resulting NTP background after transition are both (#F2F2F2). For some reason in the last couple of frames before the transition ends you can see gray line between the #F1F1F1 and #F2F2F2 regions: it's colored #EEEEEE at its darkest 1px middle line, and fades 2px in both directions vertically.

Is it possible that there is some algorithm that tries to fade the screenshot "rim" into its surroundings as it touches the top toolbar?

Deleted: shamuMOB30Onepper07222016131907.mp4 4.9 MB

	shamuMOB30Onepper07222016131907.mp4 4.9 MB View Download

ping @bauerb :-)

Chatted with bauerb@. He ran out of ideas.

@mdjones: Can you comment on nepper's latest remarks? Any idea how we can move forward?

Hi Matthew,

M53 Beta promotion period is starting today (no Beta release scheduled for Android, yet, but I'm sure TPMs want to close in :).

Please have a look at my Comment 28 and the screenshot in Comment 25.

I discussed this with Bernhard yesterday and he thinks the way this looks it may well be another line somewhere on an asset.

Can you have a look?

Thanks

Patrick

I'll try to take a look at it today.

Awesome, let me know in case I can assist in any way. :)

nepper@ in c#31 is correct - all beta blockers must be fixed *on branch* by Monday @ 5 PM.  Can we get a fix landed on trunk ASAP?

Hi Matt,

sorry for the ping: what did you find end of last week?

Thanks a lot

Patrick

I'll have a fix in by the end of the day.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47010a663bdb4a65e5ff866a34add015c3089eb4

commit 47010a663bdb4a65e5ff866a34add015c3089eb4
Author: mdjones <mdjones@chromium.org>
Date: Mon Aug 01 18:54:18 2016

Exclude border from tab switcher asset

The inner border of the tab switcher is a separate asset and
therefore does not need to be included at all in the main tab
switcher asset.

BUG= 623571 

Review-Url: https://codereview.chromium.org/2197263002
Cr-Commit-Position: refs/heads/master@{#409012}

[modify] https://crrev.com/47010a663bdb4a65e5ff866a34add015c3089eb4/chrome/android/java/res/drawable-hdpi/tabswitcher_border_frame.9.png
[modify] https://crrev.com/47010a663bdb4a65e5ff866a34add015c3089eb4/chrome/android/java/res/drawable-mdpi/tabswitcher_border_frame.9.png
[modify] https://crrev.com/47010a663bdb4a65e5ff866a34add015c3089eb4/chrome/android/java/res/drawable-xhdpi/tabswitcher_border_frame.9.png
[modify] https://crrev.com/47010a663bdb4a65e5ff866a34add015c3089eb4/chrome/android/java/res/drawable-xxhdpi/tabswitcher_border_frame.9.png
[modify] https://crrev.com/47010a663bdb4a65e5ff866a34add015c3089eb4/chrome/android/java/res/drawable-xxxhdpi/tabswitcher_border_frame.9.png

Your change meets the bar and is auto-approved for M53 (branch: 2785)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/216008f235ac709e284d09300e400a47e51a6e1c

commit 216008f235ac709e284d09300e400a47e51a6e1c
Author: Matthew Jones <mdjones@chromium.org>
Date: Mon Aug 01 20:21:58 2016

Exclude border from tab switcher asset

The inner border of the tab switcher is a separate asset and
therefore does not need to be included at all in the main tab
switcher asset.

BUG= 623571 

Review-Url: https://codereview.chromium.org/2197263002
Cr-Commit-Position: refs/heads/master@{#409012}
(cherry picked from commit 47010a663bdb4a65e5ff866a34add015c3089eb4)

Review URL: https://codereview.chromium.org/2199943002 .

Cr-Commit-Position: refs/branch-heads/2785@{#442}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/216008f235ac709e284d09300e400a47e51a6e1c/chrome/android/java/res/drawable-hdpi/tabswitcher_border_frame.9.png
[modify] https://crrev.com/216008f235ac709e284d09300e400a47e51a6e1c/chrome/android/java/res/drawable-mdpi/tabswitcher_border_frame.9.png
[modify] https://crrev.com/216008f235ac709e284d09300e400a47e51a6e1c/chrome/android/java/res/drawable-xhdpi/tabswitcher_border_frame.9.png
[modify] https://crrev.com/216008f235ac709e284d09300e400a47e51a6e1c/chrome/android/java/res/drawable-xxhdpi/tabswitcher_border_frame.9.png
[modify] https://crrev.com/216008f235ac709e284d09300e400a47e51a6e1c/chrome/android/java/res/drawable-xxxhdpi/tabswitcher_border_frame.9.png

Matt, awesome! Thanks for tracking this down. I'm looking forward to the next Canary or Dev to pick this up :).

Issue 633972 has been merged into this issue.

Yay, I can't reproduce this anymore in the latest Canary 54.0.2817.0.

Thanks a bunch for fixing this and for merging it back to M53, Matt!