Issue metadata
Sign in to add a comment
|
v8.top_25_smooth failure on chromium.perf: Mac |
||||||||||||||||||||
Issue descriptionhttps://build.chromium.org/p/chromium.perf/builders/Mac%20HDD%20Perf%20%283%29?numbuilds=200 https://build.chromium.org/p/chromium.perf/builders/Mac%20HDD%20Perf%20%285%29?numbuilds=200 https://build.chromium.org/p/chromium.perf/builders/Mac%20Retina%20Perf%20%283%29 https://build.chromium.org/p/chromium.perf/builders/Mac%20Retina%20Perf%20%285%29 https://build.chromium.org/p/chromium.perf/builders/Mac%2010.11%20Perf%20%285%29 https://build.chromium.org/p/chromium.perf/builders/Mac%2010.10%20Perf%20%283%29 https://build.chromium.org/p/chromium.perf/builders/Mac%2010.10%20Perf%20%285%29
,
Jun 27 2016
=== Auto-CCing suspected CL author bokan@chromium.org === Hi bokan@chromium.org, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Make all gesture scrolls use customization path internally Author : bokan Commit description: This patch removes the physicalScroll code path in ScrollManager. This means that all gesture scrolls are now taking the ScrollCustomization path through scrolling; building a scroll chain, calling distribute and apply scroll. Some notable changes here: iframes now also scroll like the main frame, using a ViewportScrollCallback but without affecting top controls or overscroll. The ScrollChain calculated in ScrollCustomization used to end on the scrollingElement. It now terminates at the RootScroller. This is so that 1) the RootScroller API works as expected when the page sets a root scroller and 2) if the scrollingElement is <body>, we still want to chain the scroll up to the documentElement (assuming it's the root scroller) since that'll actually scroll the frame and top controls. Clear m_deltaConsumedForScrollSequence on GestureScrollBegin. Otherwise, this doesn't get cleared during a fling gesture so a new scroll during the fling will get dropped in the ScrollCustomization path. BUG= 620721 Review-Url: https://codereview.chromium.org/2069713002 Cr-Commit-Position: refs/heads/master@{#401997} Commit : c81f2158da2b43ae5a8b0c5d0e0fcf3b5d2c8b98 Date : Fri Jun 24 22:46:56 2016 ===== TESTED REVISIONS ===== Revision Exit Code Std Dev N Good? chromium@401985 0 N/A 5 good chromium@401994 0 N/A 5 good chromium@401996 0 N/A 5 good chromium@401997 1 N/A 5 bad <-- chromium@401999 1 N/A 5 bad chromium@402003 1 N/A 5 bad Bisect job ran on: mac_10_10_perf_bisect Bug ID: 623570 Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests v8.top_25_smooth Test Metric: cpu_time/cpu_time Relative Change: Zero to non-zero Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_10_perf_bisect/builds/2167 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9008691225403564112 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5776830406066176 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Jun 27 2016
Almost certainly issue 623460. Fix has already landed, any chance you can cancel the revert?
,
Jun 27 2016
,
Jun 27 2016
Nope but I can revert it, which I'll do now!
,
Jun 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7122e19fe09e0e3e5e99eaf3b3fce888b5eed03e commit 7122e19fe09e0e3e5e99eaf3b3fce888b5eed03e Author: simonhatch <simonhatch@chromium.org> Date: Mon Jun 27 21:16:30 2016 Revert of Disabled v8.top_25_smooth/smoothness.top_25_smooth on mac. (patchset #1 id:1 of https://codereview.chromium.org/2103463002/ ) Reason for revert: Fix has landed. Original issue's description: > Disabled v8.top_25_smooth/smoothness.top_25_smooth on mac. > > TBR=sullivan@chromium.org > BUG= 623570 > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq > > Committed: https://crrev.com/57bced4e4650ed73e3c4bc568645136810eb5fb0 > Cr-Commit-Position: refs/heads/master@{#402250} TBR=sullivan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 623570 Review-Url: https://codereview.chromium.org/2102433004 Cr-Commit-Position: refs/heads/master@{#402284} [modify] https://crrev.com/7122e19fe09e0e3e5e99eaf3b3fce888b5eed03e/tools/perf/benchmarks/smoothness.py [modify] https://crrev.com/7122e19fe09e0e3e5e99eaf3b3fce888b5eed03e/tools/perf/benchmarks/v8.py
,
Jun 29 2016
Bots look green; closing. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by simonhatch@chromium.org
, Jun 27 2016