New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 623564 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 597721



Sign in to add a comment

Compute and cache animation scale on demand

Project Member Reported by sunxd@chromium.org, Jun 27 2016

Issue description

This issue is to track the changes of moving animation scale out of transform tree. See https://docs.google.com/a/chromium.org/document/d/1bJrNCo4076Ida75S8j8WUb_tb86g8EsNFn5Jwo1YtGU/edit?usp=sharing
 

Comment 1 by sunxd@chromium.org, Jun 27 2016

Labels: -Pri-3 Pri-2

Comment 2 by ajuma@chromium.org, Jun 27 2016

Labels: -Type-Bug Type-Feature

Comment 3 by ajuma@chromium.org, Jun 27 2016

Status: Assigned (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f468675e51ff897ceee05906de62d19b62b238e9

commit f468675e51ff897ceee05906de62d19b62b238e9
Author: sunxd <sunxd@chromium.org>
Date: Thu Jun 30 23:56:18 2016

cc:: Compute animation scale on demand

As we are cleaning up transform tree logic, we need to remove animation
scale computation and data from transform tree. And instead, we compute
it when we need it.

However, computing animation scale may reuse animation scale data which
belongs to other transform nodes, so we need a PropertyTreesCachedData
to store this information, and invalidate it every time we update the
transform tree.

BUG= 623564 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2105673003
Cr-Commit-Position: refs/heads/master@{#403354}

[modify] https://crrev.com/f468675e51ff897ceee05906de62d19b62b238e9/cc/layers/draw_properties.cc
[modify] https://crrev.com/f468675e51ff897ceee05906de62d19b62b238e9/cc/layers/draw_properties.h
[modify] https://crrev.com/f468675e51ff897ceee05906de62d19b62b238e9/cc/layers/layer.cc
[modify] https://crrev.com/f468675e51ff897ceee05906de62d19b62b238e9/cc/layers/layer_impl.cc
[modify] https://crrev.com/f468675e51ff897ceee05906de62d19b62b238e9/cc/layers/picture_layer_impl.cc
[modify] https://crrev.com/f468675e51ff897ceee05906de62d19b62b238e9/cc/layers/picture_layer_impl_unittest.cc
[modify] https://crrev.com/f468675e51ff897ceee05906de62d19b62b238e9/cc/proto/property_tree.proto
[modify] https://crrev.com/f468675e51ff897ceee05906de62d19b62b238e9/cc/test/layer_tree_host_common_test.h
[modify] https://crrev.com/f468675e51ff897ceee05906de62d19b62b238e9/cc/trees/draw_property_utils.cc
[modify] https://crrev.com/f468675e51ff897ceee05906de62d19b62b238e9/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/f468675e51ff897ceee05906de62d19b62b238e9/cc/trees/property_tree.cc
[modify] https://crrev.com/f468675e51ff897ceee05906de62d19b62b238e9/cc/trees/property_tree.h
[modify] https://crrev.com/f468675e51ff897ceee05906de62d19b62b238e9/cc/trees/property_tree_builder.cc
[modify] https://crrev.com/f468675e51ff897ceee05906de62d19b62b238e9/cc/trees/property_tree_unittest.cc
[modify] https://crrev.com/f468675e51ff897ceee05906de62d19b62b238e9/cc/trees/tree_synchronizer_unittest.cc

Comment 5 by sunxd@chromium.org, Jul 4 2016

Status: Fixed (was: Assigned)

Sign in to add a comment