New issue
Advanced search Search tips

Issue 623553 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[PlzNavigate] Properly handle navigation for cid: URLs

Project Member Reported by blundell@chromium.org, Jun 27 2016

Issue description

PlzNavigate does not currently properly handle navigation for cid: URLs (i.e, URLs with the content ID scheme that occur in MHTML documents).

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ef36cb49aff9e2daeb0f449bfa2ac68c2b52222

commit 5ef36cb49aff9e2daeb0f449bfa2ac68c2b52222
Author: blundell <blundell@chromium.org>
Date: Mon Jun 27 15:37:14 2016

Add content ID scheme to //url/url_constants.*

This CL adds the content ID scheme to //url/url_constants.*. This scheme is
specified in https://tools.ietf.org/html/rfc2392. The concrete motivation for
this CL is that an upcoming CL needs to reference the content ID scheme in
order to correctly handle navigations within MHTML documents when using
browser-side navigation.

BUG= 623553 

Review-Url: https://codereview.chromium.org/2098723003
Cr-Commit-Position: refs/heads/master@{#402185}

[modify] https://crrev.com/5ef36cb49aff9e2daeb0f449bfa2ac68c2b52222/url/gurl_unittest.cc
[modify] https://crrev.com/5ef36cb49aff9e2daeb0f449bfa2ac68c2b52222/url/url_constants.cc
[modify] https://crrev.com/5ef36cb49aff9e2daeb0f449bfa2ac68c2b52222/url/url_constants.h

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/000b07903ead3a349dc6a786c843cdf57900f143

commit 000b07903ead3a349dc6a786c843cdf57900f143
Author: blundell <blundell@chromium.org>
Date: Tue Jun 28 10:32:49 2016

PlzNavigate: Handle navigation within MHTML documents

Within MHTML documents, the content ID scheme ("cid:") is used to specify
navigations to another part of the document. Blink understands how to load
such resources (cf. MHTMLArchive.cpp and ResourceFetcher.cpp), so //content
doesn't need to anything special for them. In particular, it does not need
to make a network request when navigating to such URLs. This CL adds that
behavior so that PlzNavigate correctly handles such navigations.

BUG= 623553 

Review-Url: https://codereview.chromium.org/2098543003
Cr-Commit-Position: refs/heads/master@{#402438}

[modify] https://crrev.com/000b07903ead3a349dc6a786c843cdf57900f143/content/common/navigation_params.cc
[modify] https://crrev.com/000b07903ead3a349dc6a786c843cdf57900f143/content/common/navigation_params.h
[add] https://crrev.com/000b07903ead3a349dc6a786c843cdf57900f143/content/common/navigation_params_unittest.cc
[modify] https://crrev.com/000b07903ead3a349dc6a786c843cdf57900f143/content/content_tests.gypi
[modify] https://crrev.com/000b07903ead3a349dc6a786c843cdf57900f143/testing/buildbot/filters/browser-side-navigation.linux.content_browsertests.filter

Status: Fixed (was: Started)

Sign in to add a comment