New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 623541 link

Starred by 1 user
Status: Fixed
Owner:
tommycli@chromium.org
Closed: Jun 2016
Cc:
nyerramilli@chromium.org
█ tkonch...@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Advance sync settings checkboxes are not working as intended on chrome://md-settings page.

Reported by dchau...@etouch.net, Jun 27 2016 
Chrome Version: 53.0.2780.0 (Official Build)5453dc6abc2d7c797c7f9f16df8aed8e6358a217-refs/heads/master@{#402053} 32/64-bit.
OS: Windows(7,8,10), Mac(10.10.5, 10.11.4), Linux(14.04 LTS).

What steps will reproduce the problem?
1. Launch chrome, sign in to chrome with valid credentials and go to chrome://md-settings page.
2. Go to 'Advanced Sync settings' by clicking on 'Sync' option under 'People' section and uncheck the 'Sync everything' checkbox.
3. Now uncheck the 'Apps' checkbox (or any) and then check the 'Sync everything' checkbox.
4. Now again uncheck the 'Sync everything' checkbox and observe the 'Apps' checkbox.

Unnecessary 'Apps' checkbox is checked. 
'Apps' checkbox should not get checked. 

This is a regression issue, broken in M-48 series, below is bisect info.

Good build: 48.0.2534.0
Bad build: 48.0.2535.0 

Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/9229728f513f6139d8226c1d188387b03b8331a9..37f5227e665fab5e3399a03fed72ce253a6669d0?pretty=fuller&n=10

Suspecting: r353781

Kindly review the attached screen-cast for reference.
Actual behavior.mp4
1.5 MB View Download
Expected behavior.mp4
1.0 MB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f202ab267491fb469ffcb321560d9f0cfccf825

commit 0f202ab267491fb469ffcb321560d9f0cfccf825
Author: tommycli <tommycli@chromium.org>
Date: Wed Jun 29 18:48:54 2016

Settings People Revamp: Cache the selected Sync individual data types.

Checking and unchecking "Sync All" should not forget which individual
data types to sync were previously selected.

This patch fixes that bug.

BUG= 623541 ,563721
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2104173002
Cr-Commit-Position: refs/heads/master@{#402880}

[modify] https://crrev.com/0f202ab267491fb469ffcb321560d9f0cfccf825/chrome/browser/resources/settings/people_page/sync_page.js

Comment 2 by tommycli@chromium.org, Jun 30 2016

Status: Fixed (was: Assigned)
TE plz verify.

Comment 3 by ranjitkan@chromium.org, Jul 7 2016

Cc: ranjitkan@chromium.org
Labels: TE-Verified-53.0.2785.8 TE-Verified-M53
Rechecked this on chrome version 53.0.2785.8 on Windows 7, MAC 10.11.5, Ubuntu 14.04. Fix is working as intended. Option which were unchecked are not getting checked once we recheck the "Sync-everything" option.

Adding TE-Verified labels.
►

Sign in to add a comment