Issue metadata
Sign in to add a comment
|
SVG not displayed as content of ::after elements
Reported by
l...@codelitt.com,
Jun 27 2016
|
||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.103 Safari/537.36 Example URL: https://jsfiddle.net/L78wzjxh/ Steps to reproduce the problem: 1. Navigate to https://jsfiddle.net/L78wzjxh/ 2. Check the rendered "Label" box What is the expected behavior? The rendered "Label" box should display a cross "X" icon to the right What went wrong? The cross "X" icon is not displayed. We believe the problem happens when the icon is a SVG file Does it occur on multiple sites: N/A Is it a problem with a plugin? No Did this work before? Yes We tried with a random Chromium build and it worked as of 48.0.2542.0 Does this work in other browsers? Yes Chrome version: 51.0.2704.103 Channel: stable OS Version: OS X 10.11.0 Flash Version: Shockwave Flash 22.0 r0
,
Jun 27 2016
Sorry, stupid mistake to refer to our secured area... It *does* happen when the content URL is not restricted. I'll update the jsfiddle with a version that doesn't use a secured area
,
Jun 27 2016
Thanks. I'm assuming that will be https://jsfiddle.net/L78wzjxh/1/ ? (Appears to)
,
Jun 27 2016
And that one is served as text/plain =)
,
Jun 27 2016
I stashed it on my local webserver, but then the problem did not reproduce.
,
Jun 27 2016
Just updated the jsfiddle with an unrestricted resource URL. You can also check the problem at this URL: https://lrmunoz.github.io/temp/ Regards, Luis
,
Jun 27 2016
To clarify, the updated jsfiddle is at: https://jsfiddle.net/L78wzjxh/4/ Also, worth noting that I'm clearing the cache to test the problem
,
Jun 27 2016
Thanks! I could reproduce using that URL (actually, both). It does seems to be a bit flaky though. Bisected: You are probably looking for a change made after 379799 (known good), but no later than 379801 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/84f2cfba1b8749ed115a0cca316c2dca0c12d674..3c7b1342b32dd6174efa9a47a4b476c940462b9c So I guess it's related to r379801.
,
Jun 28 2016
What is also strange, for me opening the test page from here or from `data:text/html,<a href="https://lrmunoz.github.io/temp/">click</a>` into a new tab by middle mouse button reliably yields correctly displayed page. Refresh breaks it again. Subsequent refreshes in Canary occasionally repairs it again, approx one in thirty refreshes. 51.0.2704.106 (Official Build) m (64-bit) 53.0.2782.0 (Official Build) canary (64-bit)
,
Jun 28 2016
Yes, I observed the same. I suspect the cause has some relation to loading delay/resource handling.
,
Jul 5 2016
,
Jul 5 2016
I suspect this is: // TODO(davve): Find out the default object size, if any, in this context. in LayoutImageResourceStyleImage::imageSize(). The flakiness observed probably depends on when in the painting (invalidation) system the SVG is rendered.
,
Jul 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da6dc5be059c4dd6a6b7f1a4ba9c1f12be3d67ae commit da6dc5be059c4dd6a6b7f1a4ba9c1f12be3d67ae Author: davve <davve@opera.com> Date: Fri Jul 08 14:25:03 2016 Fallback to 300x150 instead of 0x0 size for SVG inside content() Prior to r379801, the fallback 300x150 in SVGImage::dataChanged() was used. Post r379801 we instead used the empty rect as fallback. Both are probably wrong but 300x150 matches what we did previously more closely and we are less likely to end up with an empty image. BUG= 623528 Review-Url: https://codereview.chromium.org/2121973002 Cr-Commit-Position: refs/heads/master@{#404374} [add] https://crrev.com/da6dc5be059c4dd6a6b7f1a4ba9c1f12be3d67ae/third_party/WebKit/LayoutTests/http/tests/misc/resources/svg-no-store.pl [add] https://crrev.com/da6dc5be059c4dd6a6b7f1a4ba9c1f12be3d67ae/third_party/WebKit/LayoutTests/http/tests/misc/svg-image-in-content-expected.html [add] https://crrev.com/da6dc5be059c4dd6a6b7f1a4ba9c1f12be3d67ae/third_party/WebKit/LayoutTests/http/tests/misc/svg-image-in-content.html [modify] https://crrev.com/da6dc5be059c4dd6a6b7f1a4ba9c1f12be3d67ae/third_party/WebKit/Source/core/layout/LayoutImageResourceStyleImage.cpp [modify] https://crrev.com/da6dc5be059c4dd6a6b7f1a4ba9c1f12be3d67ae/third_party/WebKit/Source/core/layout/LayoutImageResourceStyleImage.h [modify] https://crrev.com/da6dc5be059c4dd6a6b7f1a4ba9c1f12be3d67ae/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp
,
Jul 11 2016
,
Jul 19 2016
Is there an estimate available for when this fix will be released?
,
Jul 19 2016
Currently the fix is only in M54 (est. release mid-October), but we should probably try for a merge to M53 (est. release early September.)
,
Jul 19 2016
The sooner the better. This adversely affects our UI for a large number of users across all platforms running Chrome.
,
Jul 19 2016
Agreed, this fix is critical and is a highly visible problem for all users.
,
Jul 20 2016
,
Jul 20 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Jul 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7815a45a74afc00768f304acc60272ca653bec86 commit 7815a45a74afc00768f304acc60272ca653bec86 Author: Fredrik Söderquist <fs@opera.com> Date: Wed Jul 20 11:56:26 2016 Fallback to 300x150 instead of 0x0 size for SVG inside content() Prior to r379801, the fallback 300x150 in SVGImage::dataChanged() was used. Post r379801 we instead used the empty rect as fallback. Both are probably wrong but 300x150 matches what we did previously more closely and we are less likely to end up with an empty image. BUG= 623528 Review-Url: https://codereview.chromium.org/2121973002 Cr-Commit-Position: refs/heads/master@{#404374} (cherry picked from commit da6dc5be059c4dd6a6b7f1a4ba9c1f12be3d67ae) Review URL: https://codereview.chromium.org/2168603002 . Cr-Commit-Position: refs/branch-heads/2785@{#243} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [add] https://crrev.com/7815a45a74afc00768f304acc60272ca653bec86/third_party/WebKit/LayoutTests/http/tests/misc/resources/svg-no-store.pl [add] https://crrev.com/7815a45a74afc00768f304acc60272ca653bec86/third_party/WebKit/LayoutTests/http/tests/misc/svg-image-in-content-expected.html [add] https://crrev.com/7815a45a74afc00768f304acc60272ca653bec86/third_party/WebKit/LayoutTests/http/tests/misc/svg-image-in-content.html [modify] https://crrev.com/7815a45a74afc00768f304acc60272ca653bec86/third_party/WebKit/Source/core/layout/LayoutImageResourceStyleImage.cpp [modify] https://crrev.com/7815a45a74afc00768f304acc60272ca653bec86/third_party/WebKit/Source/core/layout/LayoutImageResourceStyleImage.h [modify] https://crrev.com/7815a45a74afc00768f304acc60272ca653bec86/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp
,
Jul 20 2016
,
Jul 26 2016
Tested the issue on windows 7, Linux Ubuntu 14.04 and Mac 10.11.5 using chrome version 53.0.2785.30.Able to see the 'X' icon in label box. Please find the attached screen shot for the same. Adding TE-Verified label. Thanks,
,
Aug 5 2016
Issue 634325 has been merged into this issue. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by f...@opera.com
, Jun 27 2016Labels: -OS-Mac